[arquillian-issues] [JBoss JIRA] (ARQ-2186) Consider stopping manual mode containers within @AfterSuite event, not @AfterClass

[Vlastislav Ramik (JIRA)]

     [ https://issues.jboss.org/browse/ARQ-2186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vlastislav Ramik updated ARQ-2186:
----------------------------------
    Description: 
IMO it would be good to stop all manual containers within @AfterSuite event here: https://github.com/arquillian/arquillian-core/blob/master/container/test-impl-base/src/main/java/org/jboss/arquillian/container/test/impl/client/ContainerEventController.java#L86-L88

not here: https://github.com/arquillian/arquillian-core/blob/master/container/test-impl-base/src/main/java/org/jboss/arquillian/container/test/impl/client/ContainerEventController.java#L103

As a workaround I use 
{noformat}
!org.jboss.arquillian.container.test.impl.ContainerTestExtension
org.jboss.my.custom.CustomContainerTestExtension
{noformat}
in org.jboss.arquillian.core.spi.LoadableExtension

CustomContainerTestExtension registers 
* everything what's in ContainerTestExtension except ContainerEventController. 
* CustomContainerEventController (where described functionality is implemented)


  was:
IMO it would be good to stop all manual containers within @AfterSuite event here: https://github.com/arquillian/arquillian-core/blob/master/container/test-impl-base/src/main/java/org/jboss/arquillian/container/test/impl/client/ContainerEventController.java#L86-L88

not here: https://github.com/arquillian/arquillian-core/blob/master/container/test-impl-base/src/main/java/org/jboss/arquillian/container/test/impl/client/ContainerEventController.java#L103

As a workaround I use 
{noformat}
!org.jboss.arquillian.container.test.impl.ContainerTestExtension
org.jboss.my.custom.CustomContainerTestExtension
{noformat}

CustomContainerTestExtension registers 
* everything what's in ContainerTestExtension except ContainerEventController. 
* CustomContainerEventController (where described functionality is implemented)




> Consider stopping manual mode containers within @AfterSuite event, not @AfterClass
> ----------------------------------------------------------------------------------
>
>                 Key: ARQ-2186
>                 URL: https://issues.jboss.org/browse/ARQ-2186
>             Project: Arquillian
>          Issue Type: Enhancement
>    Affects Versions: 1.4.0.Final
>            Reporter: Vlastislav Ramik
>
> IMO it would be good to stop all manual containers within @AfterSuite event here: https://github.com/arquillian/arquillian-core/blob/master/container/test-impl-base/src/main/java/org/jboss/arquillian/container/test/impl/client/ContainerEventController.java#L86-L88
> not here: https://github.com/arquillian/arquillian-core/blob/master/container/test-impl-base/src/main/java/org/jboss/arquillian/container/test/impl/client/ContainerEventController.java#L103
> As a workaround I use 
> {noformat}
> !org.jboss.arquillian.container.test.impl.ContainerTestExtension
> org.jboss.my.custom.CustomContainerTestExtension
> {noformat}
> in org.jboss.arquillian.core.spi.LoadableExtension
> CustomContainerTestExtension registers 
> * everything what's in ContainerTestExtension except ContainerEventController. 
> * CustomContainerEventController (where described functionality is implemented)



--
This message was sent by Atlassian JIRA
(v7.5.0#75005)