<div dir="ltr">I am somewhat attracted to Sebastian's suggestion of illegal identifier characters. My suggestion would be "<result>".<br><br>Matt<br></div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Fri, Feb 8, 2013 at 9:21 AM, Hardy Ferentschik <span dir="ltr"><<a href="mailto:hardy@hibernate.org" target="_blank">hardy@hibernate.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I don't want to introduce a name for the return value to allow things like<br>
<br>
if(node.getName.equals("retval")) {<br>
ReturnValueDescriptor descriptor = (ReturnValueDescriptor) node.getElementDescriptor();<br>
}<br>
<br>
The actual type of a node is still given by it ElementDescriptor. The name cannot be used for that. It is more for convenience<br>
and "nice" toString implementation. Yes it could be ambiguous, but I don't think it matters. Any code relying on the property path<br>
as string is potentially wrong anyways. A white space seems odd, especially in the light of toString.<br>
<br>
In that light $retval might be a legal java identifier, but chances are slim someone uses it.<br>
<span class="HOEnZb"><font color="#888888"><br>
--Hardy<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
<br>
On 8 Jan 2013, at 4:07 PM, Sebastian Thomschke <<a href="mailto:sebastian.thomschke@web.de">sebastian.thomschke@web.de</a>> wrote:<br>
<br>
> What if there is a property or method called "returnValue"? I think the constant string returned should contain a character that is not legal for java identifier names. E.g. a white space.<br>
><br>
> seb<br>
><br>
> On 08.02.2013 12:51, Gunnar Morling wrote:<br>
>> Experts,<br>
>><br>
>> another issue where we need some feedback is BVAL-368, which is about the name of path nodes representing return values.<br>
>><br>
>> As per the current draft, Node#getName() returns null in that case. Question is, whether we should return something more meaningful, and if so, which value.<br>
>><br>
>> The RI used to return "$retval" before we change this to match the spec. Another obvious option would be "returnValue". Having a standardized node name for return value nodes would also help with better toString() implementations for j.v.Path (although that's not standardized).<br>
>><br>
>> Any thoughts?<br>
>><br>
>> Thanks,<br>
>><br>
>> --Gunnar<br>
>><br>
>> [1] <a href="https://hibernate.onjira.com/browse/BVAL-368" target="_blank">https://hibernate.onjira.com/browse/BVAL-368</a><br>
>><br>
>><br>
>> _______________________________________________<br>
>> beanvalidation-dev mailing list<br>
>><br>
>> <a href="mailto:beanvalidation-dev@lists.jboss.org">beanvalidation-dev@lists.jboss.org</a><br>
>> <a href="https://lists.jboss.org/mailman/listinfo/beanvalidation-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/beanvalidation-dev</a><br>
><br>
> _______________________________________________<br>
> beanvalidation-dev mailing list<br>
> <a href="mailto:beanvalidation-dev@lists.jboss.org">beanvalidation-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/beanvalidation-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/beanvalidation-dev</a><br>
<br>
<br>
_______________________________________________<br>
beanvalidation-dev mailing list<br>
<a href="mailto:beanvalidation-dev@lists.jboss.org">beanvalidation-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/beanvalidation-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/beanvalidation-dev</a><br>
</div></div></blockquote></div><br></div>