<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">+1 for "<return value>" too<br>
<br>
seb<br>
<br>
On 09.02.2013 12:03, Gunnar Morling wrote:<br>
</div>
<blockquote
cite="mid:CADGJaX_230KyFgT6OvDWQFgFebEvctK5PQFappLyE-Qn_m9_Hg@mail.gmail.com"
type="cite">
<div dir="ltr">+1 for <span
style="font-family:arial,sans-serif;font-size:13px"><return
value>.</span>
<div><span style="font-family:arial,sans-serif;font-size:13px"><br>
</span></div>
<div style=""><span
style="font-family:arial,sans-serif;font-size:13px">--Gunnar</span></div>
<div style=""><span
style="font-family:arial,sans-serif;font-size:13px"><br>
</span></div>
</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">2013/2/8 Emmanuel Bernard <span
dir="ltr"><<a moz-do-not-send="true"
href="mailto:emmanuel@hibernate.org" target="_blank">emmanuel@hibernate.org</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">I am not a
big fan of the retval which reminds me of Gollum skeaping
his<br>
name ;)<br>
<br>
- <return value><br>
- <return><br>
- (return value)<br>
- (return)<br>
<br>
I think I like <return value> the best.<br>
<br>
As Hardy said, the name is not critical as nodes are
identified by their<br>
elementDescriptor.kind.<br>
<span class="HOEnZb"><font color="#888888"><br>
Emmanuel<br>
</font></span>
<div class="HOEnZb">
<div class="h5"><br>
On Fri 2013-02-08 11:19, Matt Benson wrote:<br>
> I am somewhat attracted to Sebastian's suggestion
of illegal identifier<br>
> characters. My suggestion would be
"<result>".<br>
><br>
> Matt<br>
><br>
><br>
> On Fri, Feb 8, 2013 at 9:21 AM, Hardy Ferentschik
<<a moz-do-not-send="true"
href="mailto:hardy@hibernate.org">hardy@hibernate.org</a>>wrote:<br>
><br>
> > I don't want to introduce a name for the
return value to allow things like<br>
> ><br>
> > if(node.getName.equals("retval")) {<br>
> > ReturnValueDescriptor descriptor =
(ReturnValueDescriptor)<br>
> > node.getElementDescriptor();<br>
> > }<br>
> ><br>
> > The actual type of a node is still given by it
ElementDescriptor. The name<br>
> > cannot be used for that. It is more for
convenience<br>
> > and "nice" toString implementation. Yes it
could be ambiguous, but I don't<br>
> > think it matters. Any code relying on the
property path<br>
> > as string is potentially wrong anyways. A
white space seems odd,<br>
> > especially in the light of toString.<br>
> ><br>
> > In that light $retval might be a legal java
identifier, but chances are<br>
> > slim someone uses it.<br>
> ><br>
> > --Hardy<br>
> ><br>
> ><br>
> > On 8 Jan 2013, at 4:07 PM, Sebastian Thomschke
<<a moz-do-not-send="true"
href="mailto:sebastian.thomschke@web.de">sebastian.thomschke@web.de</a>><br>
> > wrote:<br>
> ><br>
> > > What if there is a property or method
called "returnValue"? I think the<br>
> > constant string returned should contain a
character that is not legal for<br>
> > java identifier names. E.g. a white space.<br>
> > ><br>
> > > seb<br>
> > ><br>
> > > On <a moz-do-not-send="true"
href="tel:08.02.2013%2012" value="+49802201312">08.02.2013
12</a>:51, Gunnar Morling wrote:<br>
> > >> Experts,<br>
> > >><br>
> > >> another issue where we need some
feedback is BVAL-368, which is about<br>
> > the name of path nodes representing return
values.<br>
> > >><br>
> > >> As per the current draft,
Node#getName() returns null in that case.<br>
> > Question is, whether we should return
something more meaningful, and if so,<br>
> > which value.<br>
> > >><br>
> > >> The RI used to return "$retval"
before we change this to match the<br>
> > spec. Another obvious option would be
"returnValue". Having a standardized<br>
> > node name for return value nodes would also
help with better toString()<br>
> > implementations for j.v.Path (although that's
not standardized).<br>
> > >><br>
> > >> Any thoughts?<br>
> > >><br>
> > >> Thanks,<br>
> > >><br>
> > >> --Gunnar<br>
> > >><br>
> > >> [1] <a moz-do-not-send="true"
href="https://hibernate.onjira.com/browse/BVAL-368"
target="_blank">https://hibernate.onjira.com/browse/BVAL-368</a><br>
> > >><br>
> > >><br>
</div>
</div>
</blockquote>
</div>
</div>
</blockquote>
<br>
</body>
</html>