<div dir="ltr">Come on, Hardy, join me in supporting <result> which avoids whitespace and encompasses the full meaning of "return value". :)<br><br>Matt<br></div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Sun, Feb 10, 2013 at 4:42 AM, Hardy Ferentschik <span dir="ltr"><<a href="mailto:hardy@hibernate.org" target="_blank">hardy@hibernate.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Personally I don't like the whitespace in <return value>. I would prefer <return>.<br>
However, if the majority agrees to <return value> that's fine with me. I like the the use of <>.<br>
<span class="HOEnZb"><font color="#888888"><br>
--Hardy<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
<br>
On 9 Jan 2013, at 3:05 PM, Sebastian Thomschke <<a href="mailto:sebastian.thomschke@web.de">sebastian.thomschke@web.de</a>> wrote:<br>
<br>
> +1 for "<return value>" too<br>
><br>
> seb<br>
><br>
> On 09.02.2013 12:03, Gunnar Morling wrote:<br>
>> +1 for <return value>.<br>
>><br>
>> --Gunnar<br>
>><br>
>><br>
>><br>
>> 2013/2/8 Emmanuel Bernard <<a href="mailto:emmanuel@hibernate.org">emmanuel@hibernate.org</a>><br>
>> I am not a big fan of the retval which reminds me of Gollum skeaping his<br>
>> name ;)<br>
>><br>
>> - <return value><br>
>> - <return><br>
>> - (return value)<br>
>> - (return)<br>
>><br>
>> I think I like <return value> the best.<br>
>><br>
>> As Hardy said, the name is not critical as nodes are identified by their<br>
>> elementDescriptor.kind.<br>
>><br>
>> Emmanuel<br>
>><br>
>> On Fri 2013-02-08 11:19, Matt Benson wrote:<br>
>> > I am somewhat attracted to Sebastian's suggestion of illegal identifier<br>
>> > characters. My suggestion would be "<result>".<br>
>> ><br>
>> > Matt<br>
>> ><br>
>> ><br>
>> > On Fri, Feb 8, 2013 at 9:21 AM, Hardy Ferentschik <<a href="mailto:hardy@hibernate.org">hardy@hibernate.org</a>>wrote:<br>
>> ><br>
>> > > I don't want to introduce a name for the return value to allow things like<br>
>> > ><br>
>> > > if(node.getName.equals("retval")) {<br>
>> > > ReturnValueDescriptor descriptor = (ReturnValueDescriptor)<br>
>> > > node.getElementDescriptor();<br>
>> > > }<br>
>> > ><br>
>> > > The actual type of a node is still given by it ElementDescriptor. The name<br>
>> > > cannot be used for that. It is more for convenience<br>
>> > > and "nice" toString implementation. Yes it could be ambiguous, but I don't<br>
>> > > think it matters. Any code relying on the property path<br>
>> > > as string is potentially wrong anyways. A white space seems odd,<br>
>> > > especially in the light of toString.<br>
>> > ><br>
>> > > In that light $retval might be a legal java identifier, but chances are<br>
>> > > slim someone uses it.<br>
>> > ><br>
>> > > --Hardy<br>
>> > ><br>
>> > ><br>
>> > > On 8 Jan 2013, at 4:07 PM, Sebastian Thomschke <<a href="mailto:sebastian.thomschke@web.de">sebastian.thomschke@web.de</a>><br>
>> > > wrote:<br>
>> > ><br>
>> > > > What if there is a property or method called "returnValue"? I think the<br>
>> > > constant string returned should contain a character that is not legal for<br>
>> > > java identifier names. E.g. a white space.<br>
>> > > ><br>
>> > > > seb<br>
>> > > ><br>
>> > > > On 08.02.2013 12:51, Gunnar Morling wrote:<br>
>> > > >> Experts,<br>
>> > > >><br>
>> > > >> another issue where we need some feedback is BVAL-368, which is about<br>
>> > > the name of path nodes representing return values.<br>
>> > > >><br>
>> > > >> As per the current draft, Node#getName() returns null in that case.<br>
>> > > Question is, whether we should return something more meaningful, and if so,<br>
>> > > which value.<br>
>> > > >><br>
>> > > >> The RI used to return "$retval" before we change this to match the<br>
>> > > spec. Another obvious option would be "returnValue". Having a standardized<br>
>> > > node name for return value nodes would also help with better toString()<br>
>> > > implementations for j.v.Path (although that's not standardized).<br>
>> > > >><br>
>> > > >> Any thoughts?<br>
>> > > >><br>
>> > > >> Thanks,<br>
>> > > >><br>
>> > > >> --Gunnar<br>
>> > > >><br>
>> > > >> [1] <a href="https://hibernate.onjira.com/browse/BVAL-368" target="_blank">https://hibernate.onjira.com/browse/BVAL-368</a><br>
>> > > >><br>
>> > > >><br>
><br>
</div></div><div class="HOEnZb"><div class="h5">> _______________________________________________<br>
> beanvalidation-dev mailing list<br>
> <a href="mailto:beanvalidation-dev@lists.jboss.org">beanvalidation-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/beanvalidation-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/beanvalidation-dev</a><br>
<br>
<br>
_______________________________________________<br>
beanvalidation-dev mailing list<br>
<a href="mailto:beanvalidation-dev@lists.jboss.org">beanvalidation-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/beanvalidation-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/beanvalidation-dev</a><br>
</div></div></blockquote></div><br></div>