<div dir="ltr">I agree with what Hardy said.<div><br></div><div>Alternatively we could have one annotation with two attributes:<div><br></div><div style>@ValidateExecutables(enabled=true/false, types=ALL|CONSTRUCTORS|GETTERS|NON_GETTERS)</div>
</div><div style><br></div><div style>Where enabled = true by default and types = ALL by default. types would only be considered if enabled = true.</div><div style><br></div><div style>//enable validation for type</div><div style>
@ValidateExecutables </div><div style>public class Foo {</div><div style><br></div><div style>}</div><div style><br></div><div style>//exclude getters</div><div style><div><div>@ValidateExecutables(types={CONSTRUCTORS, NON_GETTERS})</div>
<div>public class Foo {</div><div><br></div><div>}</div></div><div><br></div><div><div>@ValidateExecutables</div><div>public class Foo {</div><div><br></div><div style> @ValidateExecutables(enabled=false)</div><div style>
public getFoo() { ... }</div><div>}</div></div><div><br></div><div style>This would avoid the mixing of two things in one enum as mentioned by Hardy and also circumvent the naming issue. On a single method, @ValidateExecutables(enabled=false) is still a bit lengthy, but I think it's better than @ValidateExecutables(types = NONE).</div>
<div style><br></div><div style>--Gunnar</div><div style><br></div></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">2013/2/15 Hardy Ferentschik <span dir="ltr"><<a href="mailto:hardy@hibernate.org" target="_blank">hardy@hibernate.org</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
<br>
To have a enum which truly makes sense we would have to go for two annotations.<br>
<br>
We try to mix two semantics into a single emum. One is the on/off switch and one<br>
is the types of executables to validate. No matter how you rename the enum will always<br>
read awkward unless we separate these two things.<br>
<br>
I could live with @ValidateExecutables and @ValidateExecutable. I don't think that it<br>
is a problem that in other contexts the @Xs is a list of @X annotations.<br>
<span class="HOEnZb"><font color="#888888"><br>
--Hardy<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
<br>
On 14 Jan 2013, at 5:55 PM, Emmanuel Bernard <<a href="mailto:emmanuel@hibernate.org">emmanuel@hibernate.org</a>> wrote:<br>
<br>
> Pete from CDI gave me the same feedback.<br>
><br>
> There are a few competing alternatives<br>
><br>
> ## enum adjustments<br>
><br>
> @ValidateExecutable.type defaults to ALL<br>
> and rename ElementType.NONE to ElementType.OFF or NO<br>
><br>
> We can even rename type to value to make the user even easier at the<br>
> risk of harder evolutions if we need to add more parameters down the<br>
> road.<br>
><br>
> ## two annotations<br>
><br>
> @ValidateExecutable(ON|OFF) targeting methods and constructors<br>
> @ValidateExecutables(ALL|NON_GETTER_METHODS|...)<br>
><br>
> The downside is that the @Xxxs convention is used to add several times<br>
> the same annotation. This is widely used in EE for example.<br>
><br>
> We could try and find better (different) names for these annotations but<br>
> I could not find a good set.<br>
><br>
> What are your preferences?<br>
><br>
> On Mon 2013-02-11 11:04, Emmanuel Bernard wrote:<br>
>> Santiago from the JAX-RS EG is concerned that we have created an<br>
>> over-engineered solution to enable / disable method validation on a per<br>
>> method basis.<br>
>> We have good reasons for it but I am wondering if we can make it a bit<br>
>> easier to enable or disable methods out of the box.<br>
>><br>
>> Remember, the default is to ignore getters. If we make<br>
>> @ValidateExecutable.type default to ALL, enabling it on a getter would<br>
>> be<br>
>><br>
>> @NotEmpty @ValidateExecutable<br>
>> public String getAction() {...}<br>
>><br>
>> instead of<br>
>><br>
>><br>
>> @NotEmpty @ValidateExecutable(type=ExecutableType.ALL)<br>
>> public String getAction() {...}<br>
>><br>
>> We would still need the verbose approach to disable validation<br>
>><br>
>> @NotEmpty @ValidateExecutable(type=ExecutableType.NONE)<br>
>> public String getAction() {...}<br>
>><br>
>> I am open to suggestions to make that easier on methods. I don't think<br>
>> an additional annotation will make anything easier<br>
>><br>
>> Maybe renaming NONE with OFF might help? It's a bit weirder on a<br>
>> class-level but that might work.<br>
>><br>
>> Thoughts?<br>
>><br>
>> Emmanuel<br>
>> _______________________________________________<br>
>> beanvalidation-dev mailing list<br>
>> <a href="mailto:beanvalidation-dev@lists.jboss.org">beanvalidation-dev@lists.jboss.org</a><br>
>> <a href="https://lists.jboss.org/mailman/listinfo/beanvalidation-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/beanvalidation-dev</a><br>
> _______________________________________________<br>
> beanvalidation-dev mailing list<br>
> <a href="mailto:beanvalidation-dev@lists.jboss.org">beanvalidation-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/beanvalidation-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/beanvalidation-dev</a><br>
<br>
<br>
_______________________________________________<br>
beanvalidation-dev mailing list<br>
<a href="mailto:beanvalidation-dev@lists.jboss.org">beanvalidation-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/beanvalidation-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/beanvalidation-dev</a><br>
</div></div></blockquote></div><br></div>