<div><div><div>hi gunnar,</div><div><br></div><div>imo that's too verbose and maybe not that clear/intuitive due to the different (implicit) constellations.</div><div><br></div><div>regards,</div><div>gerhard</div></div>
</div><div><br></div><div><br></div><div><br></div><div><div class="gmail_quote">2013/3/13 Gunnar Morling <span dir="ltr"><<a href="mailto:gunnar@hibernate.org" target="_blank">gunnar@hibernate.org</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><div class="im"><div><span style="font-family:arial,sans-serif;font-size:13px">> but we would need then probably another object in BootstrapConfiguration wrapping the</span></div><div>> e<span style="font-family:arial,sans-serif;font-size:13px">xecutable-validation config. I am not sure this is worth it.</span><span style="color:rgb(80,0,80);font-family:arial,sans-serif;font-size:13px"><br>
</span></div></div><span style="color:rgb(80,0,80);font-family:arial,sans-serif;font-size:13px"><div><span style="color:rgb(80,0,80);font-family:arial,sans-serif;font-size:13px"><br></span></div><div><span style="color:rgb(80,0,80);font-family:arial,sans-serif;font-size:13px">We could also do</span></div>
<div><span style="color:rgb(80,0,80);font-family:arial,sans-serif;font-size:13px"><br></span></div> <executable-validation enabled="true|false"></span><br style="color:rgb(80,0,80);font-family:arial,sans-serif;font-size:13px">
<span style="font-size:13px;color:rgb(80,0,80);font-family:arial,sans-serif"> <executable-type>GETTER_METHODS</</span><span style="font-size:13px;color:rgb(80,0,80);font-family:arial,sans-serif">executable-type></span><div>
<span style="font-size:13px;color:rgb(80,0,80);font-family:arial,sans-serif"> <executable-type>CONSTRUCTORS</</span><span style="font-size:13px;color:rgb(80,0,80);font-family:arial,sans-serif">executable-type></span><br style="color:rgb(80,0,80);font-family:arial,sans-serif;font-size:13px">
<span style="color:rgb(80,0,80);font-family:arial,sans-serif;font-size:13px"> </executable-validation></span><br></div><div><span style="color:rgb(80,0,80);font-family:arial,sans-serif;font-size:13px"><br></span></div>
<div><font color="#500050" face="arial, sans-serif">I'd slightly prefer an explicit list element for the executable types. I think this reads better, should we add another sub-element to <executable-validation> one day. But I could also live with the simpler form I guess.</font></div>
<div><span style="color:rgb(80,0,80);font-family:arial,sans-serif;font-size:13px"><br></span></div><div><span style="color:rgb(80,0,80);font-family:arial,sans-serif;font-size:13px"><br></span></div></div><div class="HOEnZb">
<div class="h5"><div class="gmail_extra">
<br><br><div class="gmail_quote">2013/3/13 Hardy Ferentschik <span dir="ltr"><<a href="mailto:hardy@hibernate.org" target="_blank">hardy@hibernate.org</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><br>
On 13 Jan 2013, at 11:54 AM, Gunnar Morling <<a href="mailto:gunnar@hibernate.org" target="_blank">gunnar@hibernate.org</a>> wrote:<br>
<br>
> What I like about approach #2 is that it bundles the configuration related to executable validation in one element.<br>
><br>
> Maybe an attribute could be used for the flag:<br>
><br>
> <executable-validation enabled="true|false"><br>
> <default-validated-executables><br>
> <executable-type>NONE</executable-type><br>
> </default-validated-executables><br>
> </executable-validation><br>
<br>
</div>the enabled flag seems need, but we would need then probably another object in BootstrapConfiguration wrapping the<br>
executable-validation config. I am not sure this is worth it.<br>
<div><br>
> Generally I like "positive" flag names better than negated ones (i.e. "enabled" instead of "disabled").<br>
<br>
</div>In this case I actually prefer isValidationExecutionDisabled(). That's the more relevant/interesting case.<br>
<div><div><br>
--Hardy<br>
_______________________________________________<br>
beanvalidation-dev mailing list<br>
<a href="mailto:beanvalidation-dev@lists.jboss.org" target="_blank">beanvalidation-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/beanvalidation-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/beanvalidation-dev</a><br>
</div></div></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
beanvalidation-dev mailing list<br>
<a href="mailto:beanvalidation-dev@lists.jboss.org">beanvalidation-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/beanvalidation-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/beanvalidation-dev</a><br></blockquote></div><br></div>