<div dir="ltr">Hey Guillaume,<br><div><br></div><div>this looks VERY good! I like like the idea of using "<span style="font-size:12.8px">orPresent" instead of "</span><span style="font-size:12.8px">nowIsValid".</span></div><div><span style="font-size:12.8px"><br></span></div><div><span style="font-size:12.8px">Great work!</span></div><div><span style="font-size:12.8px"><br></span></div><div><span style="font-size:12.8px">Christian</span></div></div><div class="gmail_extra"><br><div class="gmail_quote">2016-11-10 0:29 GMT+01:00 Guillaume Smet <span dir="ltr"><<a href="mailto:guillaume.smet@gmail.com" target="_blank">guillaume.smet@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><div>Hi,<br><br></div>So I started to work on a first implementation in the API, the TCK and in HV.<br><br></div>It's a bit different from the latest draft of Michael but I think it should be a good base for our discussions.<br><br>* Bean Validation API: <a href="https://github.com/beanvalidation/beanvalidation-api/pull/70" target="_blank">https://github.com/<wbr>beanvalidation/beanvalidation-<wbr>api/pull/70</a><br></div>* Bean Validation TCK: <a href="https://github.com/beanvalidation/beanvalidation-tck/pull/77" target="_blank">https://github.com/<wbr>beanvalidation/beanvalidation-<wbr>tck/pull/77</a><br><div>* HV: <a href="https://github.com/hibernate/hibernate-validator/pull/576" target="_blank">https://github.com/hibernate/<wbr>hibernate-validator/pull/576</a><br><br>Main differences are:<br>* I didn't use introspection to build the now object from the Clock and get the compareTo method. It would save some code but I don't think it's a good idea. I agree that it limits the support to officially supported types but I like it better this way. AbstractJavaTimeValidator makes it easy to add support for other types if required;<br>* I implemented all the default java.time types in this first round but I'll add optional support for threeten-extras as a proprietary extension in a followup-up patch if we decide to keep this approach;<br>* I named the nowIsValid option orPresent leading to having something like @Past(orPresent = true) which does not look too bad.<br><br></div><div>Comments welcome!<br><br>-- <br></div><div>Guillaume<br></div><div><div><div><div><div class="gmail_extra"><br><div class="gmail_quote"><span class="">On Wed, Oct 19, 2016 at 11:24 AM, Gunnar Morling <span dir="ltr"><<a href="mailto:gunnar@hibernate.org" target="_blank">gunnar@hibernate.org</a>></span> wrote:<br></span><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hi Michael,<div><br></div><span class=""><div>+1 for splitting it up into two parts and have the discussion around Duration et al. separately. Based on that, do you think you could send a PR with the first pieces some time soon?</div><div><br></div><div>I think it'd be great to put out an Alpha1 of the spec and the RI containing this change and the other things we have so far. It's just the first steps, but pushing it out demonstrates progress and allows to get feedback early on. </div><div><br></div><div>My idea would be to do an Alpha1 with these changes around the end of this month. WDYT?</div><div><br></div><div>Thanks,</div><div><br></div><div>--Gunnar</div></span></div></blockquote></div></div></div></div></div></div></div>
<br>______________________________<wbr>_________________<br>
beanvalidation-dev mailing list<br>
<a href="mailto:beanvalidation-dev@lists.jboss.org">beanvalidation-dev@lists.<wbr>jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/beanvalidation-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/<wbr>beanvalidation-dev</a><br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div>Christian Kaltepoth</div><div>Blog: <a href="http://blog.kaltepoth.de/" target="_blank">http://blog.kaltepoth.de/</a></div><div>Twitter: <a href="http://twitter.com/chkal" target="_blank">http://twitter.com/chkal</a></div><div>GitHub: <a href="https://github.com/chkal" target="_blank">https://github.com/chkal</a></div><div><br></div></div>
</div>