<div dir="ltr">Hey Gunnar,<div><ul><li>I agree with Marco and Guillaume: I don't think that there is a real benefit if we use constraint composition. Why not let providers implement it directly?</li><li>I'm fine with regexp. One question regarding flags: Wouldn't it be simpler for users to specify flags simply by using embedded flag expressions directly in the regular expression? At least this is how I would do it. ;-)</li><li>I'm fine with leaving them out for now. However, even if they are just syntactic sugar, I think it would be valuable to have them in the long term, because they are much easier to read.</li></ul><div>Christian</div></div><div><br></div><div><br></div><div class="gmail_extra"><br><div class="gmail_quote">2017-03-24 19:20 GMT+01:00 Marco Molteni <span dir="ltr"><<a href="mailto:moltenma@gmail.com" target="_blank">moltenma@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Gunnar,<div><br></div><div>1. Constraint composition: I agree with Guillaume, I thinks is better let the providers do their own implementation.</div><div>2. Email regex: Good for me.</div><div>3. @Positive/@Negative: Ok.</div><div><br></div><div>Thanks!</div><span class="m_7188633493606010990HOEnZb"><font color="#888888"><div><br></div><div>Marco</div><div><br></div><div><br></div></font></span></div><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="m_7188633493606010990h5">On Fri, Mar 24, 2017 at 3:54 PM, Guillaume Smet <span dir="ltr"><<a href="mailto:guillaume.smet@gmail.com" target="_blank">guillaume.smet@gmail.com</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="m_7188633493606010990h5"><div dir="ltr">Hi Gunnar,<br><div><div class="gmail_extra"><br><div class="gmail_quote"><span>On Fri, Mar 24, 2017 at 2:43 PM, Gunnar Morling <span dir="ltr"><<a href="mailto:gunnar@hibernate.org" target="_blank">gunnar@hibernate.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
* Should @NotEmpty mandate the usage of constraint composition (as<br>
it's done in the PRs)? It essentially prescribes an "implementation",<br>
i.e. providers wouldn't even need a constraint validator for it. But<br>
then this excludes any more efficient implementation a provider may<br>
have (well, they could by special-handling this constraint).<br></blockquote><div><br></div></span><div>I'm not convinced it's such a good idea to use constraint composition for @NotBlank and @NotEmpty. I would let the implementation to the providers, especially since using constraint composition does not really buy us anything in this case.<span class="m_7188633493606010990m_3478835731303259554HOEnZb"><font color="#888888"><br><br>-- <br></font></span></div><span class="m_7188633493606010990m_3478835731303259554HOEnZb"><font color="#888888"><div>Guillaume<br></div></font></span></div></div></div></div>
<br></div></div><span>______________________________<wbr>_________________<br>
beanvalidation-dev mailing list<br>
<a href="mailto:beanvalidation-dev@lists.jboss.org" target="_blank">beanvalidation-dev@lists.jboss<wbr>.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/beanvalidation-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailma<wbr>n/listinfo/beanvalidation-dev</a><br></span></blockquote></div><br></div>
<br>______________________________<wbr>_________________<br>
beanvalidation-dev mailing list<br>
<a href="mailto:beanvalidation-dev@lists.jboss.org" target="_blank">beanvalidation-dev@lists.jboss<wbr>.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/beanvalidation-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailma<wbr>n/listinfo/beanvalidation-dev</a><br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="m_7188633493606010990gmail_signature" data-smartmail="gmail_signature"><div>Christian Kaltepoth</div><div>Blog: <a href="http://blog.kaltepoth.de/" target="_blank">http://blog.kaltepoth.de/</a></div><div>Twitter: <a href="http://twitter.com/chkal" target="_blank">http://twitter.com/chkal</a></div><div>GitHub: <a href="https://github.com/chkal" target="_blank">https://github.com/chkal</a></div><div><br></div></div>
</div></div>