<div dir="auto"><div><br><div class="gmail_extra"><br><div class="gmail_quote">On Apr 26, 2017 4:13 AM, "Guillaume Smet" <<a href="mailto:guillaume.smet@gmail.com">guillaume.smet@gmail.com</a>> wrote:<br type="attribution"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi,<br><div><div class="gmail_extra"><br><div class="gmail_quote"><div class="quoted-text">On Wed, Apr 26, 2017 at 10:40 AM, Gunnar Morling <span dir="ltr"><<a href="mailto:gunnar@hibernate.org" target="_blank">gunnar@hibernate.org</a>></span> wrote:<span class="m_-569524318324329322gmail-"></span><br><span class="m_-569524318324329322gmail-"></span><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="m_-569524318324329322gmail-">
> * Should there be a common superinterface for<br>
> Path$[BeanNode|PropertyNode|Co<wbr>ntainerElementNode], all of which define<br>
> the same methods?<br>
<br>
</span>I've been wondering the same, but come to think that it doesn't give you much.<br>
<br>
You (as a user) are going to work with specific node types (as<br>
narrowed down via getKind() + as()), so I would not expect you to deal<br>
with that super-type in your code. It'd put the declaration of those<br>
methods into one place, which is nice, though I kinda like the<br>
simplicity of the current Node hierarchy, with one specific sub-type<br>
per kind.<br>
<br>
What do others think?<br></blockquote><div><br></div></div><div>I had the exact same reasoning when I did it.<br></div><div class="quoted-text"><div><span class="m_-569524318324329322gmail-"></span><span class="m_-569524318324329322gmail-"></span><br><span class="m_-569524318324329322gmail-"></span></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="m_-569524318324329322gmail-">
> * Should Positive/Negative#strict() default true be provided as<br>
> #orZero() default false, for commonality with<br>
> [Past|Future]#orPresent() ?<br>
<br>
</span>Hum, yes, good point. I think I'd prefer that.<br>
<br>
@Emmanuel, I vaguely remember we discussed this. Did you see a good<br>
reason for the current default?<br>
<br>
@All, what do you think?<br></blockquote><div><br></div></div><div>Matt, do you just want to change the name or also to change the default?<br></div></div></div></div></div></blockquote></div></div></div><div dir="auto"><br></div><div dir="auto">I was speaking only of the name; however this illustrates that people may have different expectations about what the default strict behavior would be. #orZero() is pretty explicit.</div><div dir="auto"><br></div><div dir="auto">Matt</div><div dir="auto"><br></div><div dir="auto"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div class="gmail_extra"><div class="gmail_quote"><div><br></div><div>Currently, it's:<br>boolean strict() default false;<br></div><div>and you are supposing the default is true in your question.<br></div><div><br></div><div>Currently, we have:<br></div><div>- Positive/Negative: strict() default false;<br></div><div>- DecimalMin/DecimalMax: inclusive() default true;<br></div><div>- Past/Present: orPresent() default false;<br><br></div><div>I thought about proposing orZero() at the time but I didn't suggest it because "strictly positive" makes sense.<br><br></div><div>Being strict by default would probably make more sense.<br><br></div><div>As for the name, I'm torn.<font color="#888888"><br><br>-- <br></font></div><font color="#888888"><div>Guillaume<br></div></font></div></div></div></div>
<br>______________________________<wbr>_________________<br>
beanvalidation-dev mailing list<br>
<a href="mailto:beanvalidation-dev@lists.jboss.org">beanvalidation-dev@lists.<wbr>jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/beanvalidation-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/<wbr>beanvalidation-dev</a><br></blockquote></div><br></div></div></div>