<div dir="ltr">Supporting arrays as well sounds reasonable to me. Unless there is any good argument against it.</div><div class="gmail_extra"><br><div class="gmail_quote">2017-06-15 13:16 GMT+02:00 Gunnar Morling <span dir="ltr"><<a href="mailto:gunnar@hibernate.org" target="_blank">gunnar@hibernate.org</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi all,<br>
<br>
On our road to the Proposed Final Draft (more on that in a separate<br>
mail a bit), we've almost closed out all the relevant issues.<br>
<br>
One remaining issue is <a href="https://hibernate.atlassian.net/browse/BVAL-552" rel="noreferrer" target="_blank">https://hibernate.atlassian.<wbr>net/browse/BVAL-552</a><br>
which is about inconsistent behaviour of Node#isInIterable() when it<br>
comes to arrays. The spec says this:<br>
<br>
"isInIterable() returns true if the node represents an object<br>
contained in an Iterable or in a Map, false otherwise."<br>
<br>
Whereas the TCK has a test case which expects true to be returned for<br>
arrays, too [1]. Naturally, that's how the RI (and any other<br>
TCK-compliant implementation) implements this.<br>
<br>
Now my question is, should we simply change the spec and say<br>
<br>
"isInIterable() returns true if the node represents an object<br>
contained in an Iterable, Map or an array, false otherwise."<br>
<br>
Given that maps are considered already, the method has to be about<br>
"things that are iterable" and not java.lang.Iterable (which j.u.Map<br>
doesn't extend). So considering arrays there seems consistent.<br>
<br>
Or do you, Emmanuel, remember a reason for the current specification<br>
and it's actually a bug in the TCK?<br>
<br>
Thanks,<br>
<br>
--Gunnar<br>
<br>
[1] <a href="https://github.com/beanvalidation/beanvalidation-tck/blob/master/tests/src/main/java/org/hibernate/beanvalidation/tck/tests/validation/PropertyPathTest.java#L196" rel="noreferrer" target="_blank">https://github.com/<wbr>beanvalidation/beanvalidation-<wbr>tck/blob/master/tests/src/<wbr>main/java/org/hibernate/<wbr>beanvalidation/tck/tests/<wbr>validation/PropertyPathTest.<wbr>java#L196</a><br>
______________________________<wbr>_________________<br>
beanvalidation-dev mailing list<br>
<a href="mailto:beanvalidation-dev@lists.jboss.org">beanvalidation-dev@lists.<wbr>jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/beanvalidation-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/<wbr>beanvalidation-dev</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div>Christian Kaltepoth</div><div>Blog: <a href="http://blog.kaltepoth.de/" target="_blank">http://blog.kaltepoth.de/</a></div><div>Twitter: <a href="http://twitter.com/chkal" target="_blank">http://twitter.com/chkal</a></div><div>GitHub: <a href="https://github.com/chkal" target="_blank">https://github.com/chkal</a></div><div><br></div></div>
</div>