<div dir="auto">I can see the advantage of consistency (though this is establishing a pattern to which we'd be expected to stick going forward). Also, removing the additional annotation element does mean no #init() method for the implementation, for whatever that's worth. I don't feel strongly about it, but I don't really have any negative arguments.<div dir="auto"><br></div><div dir="auto">Matt</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Jun 21, 2017 5:00 AM, "Gunnar Morling" <<a href="mailto:gunnar@hibernate.org">gunnar@hibernate.org</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi all,<br>
<br>
A colleague of mine reviewing the BV 2.0 changes pointed out an<br>
inconsistency in the added/modified constraints.<br>
<br>
As per the community poll we have now @NegativeOrZero and<br>
@PositiveOrZero, whereas we still have the orPresent() option on @Past<br>
and @Future. Should it be @PastOrPresent and @FutureOrPresent instead<br>
for the sake of consistency?<br>
<br>
Now one could argue that having only attributes (orPresent(),<br>
orZero()) is most consistent with other constraints such as<br>
@DigitalMin. But indeed the explicit annotations grew on me over time<br>
as they are a bit shorter to use and, more importantly, better to<br>
read.<br>
<br>
It's late in the game, but I feel inclined to extract @PastOrPresent<br>
and @FutureOrPresent. What do you think?<br>
<br>
Thanks,<br>
<br>
--Gunnar<br>
______________________________<wbr>_________________<br>
beanvalidation-dev mailing list<br>
<a href="mailto:beanvalidation-dev@lists.jboss.org">beanvalidation-dev@lists.<wbr>jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/beanvalidation-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/<wbr>mailman/listinfo/<wbr>beanvalidation-dev</a><br>
</blockquote></div></div>