<div dir="auto">To answer the big question: yes, the original code donation which formed the basis of Apache BVal more or less "bolted" BV support onto a proprietary validation framework. 1.1 changes brought this adaptation layer to the very brink of maintainability, and the changes required for 2.0 would just have pushed it over. I was simply unable to countenance the inelegance of the code necessary to continue on in that vein, and at least one other member of our team had expressed similar dissatisfaction prior to the advent of the 2.0 spec. My approach has therefore been to rewrite substantial portions of BVal's code to make BV its primary focus and drop support for the legacy validation API that had underlain earlier versions of the project. The team accepted my work as the basis for our v2 implementation and we now continue to work towards passing the current TCK.<div dir="auto"><br></div><div dir="auto">Regarding our progress there, I don't have the precise numbers in front of me ATM, but I would put the ballpark figure at around 2/3 complete.</div><div dir="auto"><br></div><div dir="auto">Thanks,</div><div dir="auto">Matt</div></div><br><div class="gmail_quote"><div dir="ltr">On Thu, Mar 22, 2018, 5:41 AM Gunnar Morling <<a href="mailto:gunnar@hibernate.org">gunnar@hibernate.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi,<div><br></div><div>Yes, I agree the test isn't correct and should be adjusted. I only can speculate why it is the way it is; perhaps we refined the semantics around NONE at some point during the 1.1 work and then didn't adjust that test. Working hours were a bit crazy back then ;)</div><div><br></div><div>I'm curious, though. Apache BVal is 1.1 certified, so you must have passed that one before. Are you re-writing parts of the code base in the course of implementing 2.0?</div><div><br></div><div>Could you also give us a heads-up of where you are in terms of passing the TCK? We'd like to release another TCK version with the changes you pointed out. But if there's the chance that more is coming, we'd wait a bit with that of course.</div><div><br></div><div>Cheers,</div><div><br></div><div>--Gunnar</div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">2018-03-22 10:17 GMT+01:00 Guillaume Smet <span dir="ltr"><<a href="mailto:guillaume.smet@gmail.com" target="_blank" rel="noreferrer">guillaume.smet@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Matt,<br><div class="gmail_extra"><br><div class="gmail_quote"><span>On Wed, Mar 21, 2018 at 9:55 PM, Matt Benson <span dir="ltr"><<a href="mailto:mbenson@apache.org" target="_blank" rel="noreferrer">mbenson@apache.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">I would challenge<br>
BootstrapConfigurationWithValidatedExecutableTypesContainingNONETest<br>
as defying the specification. The current version says at<br>
<a href="http://beanvalidation.org/2.0/spec/#integration-general-executable" rel="noreferrer noreferrer" target="_blank">http://beanvalidation.org/2.0/spec/#integration-general-executable</a> and<br>
in the code for ExecutableType that NONE is essentially ignored in the<br>
presence of other types (and effectively, always). I see nothing to<br>
dictate that NONE should be treated differently in the XML descriptor<br>
than elsewhere.<br></blockquote><div><br></div></span><div>Outch, this one is an old one :).<br><br></div><div>The spec is very clear about the behavior of <span class="m_1819158482322777620m_8806068067157279355gmail-tck-testable m_1819158482322777620m_8806068067157279355gmail-tck-needs-update"><code class="m_1819158482322777620m_8806068067157279355gmail-classname">@ValidateOnExecution</code></span>:<br><span class="m_1819158482322777620m_8806068067157279355gmail-tck-testable">"A list containing <code>NONE</code> and other types of executables is equivalent to a list containing the types of executables without <code>NONE</code>.</span>"<br><br></div><div>Same in the @ExecutableType javadoc:<br> /**<br> * None of the executables.<br> * <p><br> * Note that this option is equivalent to an empty list of executable types<br> * and is present to improve readability. If {@code NONE} and other types of executables<br> * are present in a list, {@code NONE} is ignored.<br> */<br></div><div><br></div><div>I can't find anything specific to the XML configuration so I suppose we should follow the same rule.<br></div><div><br></div><div>@Gunnar does old Gunnar have any recollection of what young Gunnar did back at the time?<span class="m_1819158482322777620HOEnZb"><font color="#888888"><br><br>-- <br></font></span></div><span class="m_1819158482322777620HOEnZb"><font color="#888888"><div>Guillaume<br></div></font></span></div></div></div>
<br>_______________________________________________<br>
beanvalidation-dev mailing list<br>
<a href="mailto:beanvalidation-dev@lists.jboss.org" target="_blank" rel="noreferrer">beanvalidation-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/beanvalidation-dev" rel="noreferrer noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/beanvalidation-dev</a><br></blockquote></div><br></div>
_______________________________________________<br>
beanvalidation-dev mailing list<br>
<a href="mailto:beanvalidation-dev@lists.jboss.org" target="_blank" rel="noreferrer">beanvalidation-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/beanvalidation-dev" rel="noreferrer noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/beanvalidation-dev</a></blockquote></div>