[cdi-dev] Last review on PR 290 (SE bootstrap)

[Emily Jiang]

+1 on both. Great job!

[1]: https://github.com/cdi-spec/cdi/pull/290 
[2]: 
https://dl.dropboxusercontent.com/u/2898173/cdi-spec.html#bootstrap-se 

Many thanks,
Emily
===========================
Emily Jiang
WebSphere Application Server, CDI Development Lead
 
MP 211, DE3A20, Winchester, Hampshire, England, SO21 2JN
Phone:  +44 (0)1962 816278  Internal: 246278

Email: emijiang at uk.ibm.com 
Lotus Notes: Emily Jiang/UK/IBM at IBMGB




From:   Emily Jiang/UK/IBM at IBMGB
To:     "John D. Ament" <john.d.ament at gmail.com>, 
Cc:     cdi-dev <cdi-dev at lists.jboss.org>
Date:   29/06/2016 14:42
Subject:        Re: [cdi-dev] Last review on PR 290 (SE bootstrap)
Sent by:        cdi-dev-bounces at lists.jboss.org



Antoine, 
I think you did a global replacement on bootstrap. 

Scanning may also have negative impact on se performance. 
'se performance' does not make sense. I would prefer not to change 
bootstrap to se in this sentence. 

It should still read 
Scanning may also have negative impact on bootstrap performance. 

Many thanks,
Emily
===========================
Emily Jiang
WebSphere Application Server, CDI Development Lead 
 
MP 211, DE3A20, Winchester, Hampshire, England, SO21 2JN
Phone:  +44 (0)1962 816278  Internal: 246278

Email: emijiang at uk.ibm.com 
Lotus Notes: Emily Jiang/UK/IBM at IBMGB




From:        "John D. Ament" <john.d.ament at gmail.com> 
To:        Antoine Sabot-Durand <antoine at sabot-durand.net>, 
Cc:        cdi-dev <cdi-dev at lists.jboss.org> 
Date:        29/06/2016 14:08 
Subject:        Re: [cdi-dev] Last review on PR 290 (SE bootstrap) 
Sent by:        cdi-dev-bounces at lists.jboss.org 



Yes. 
On Jun 29, 2016 7:47 AM, "Antoine Sabot-Durand" <antoine at sabot-durand.net> 
wrote: 
You mean the instance of SeContainerInitializer obtained thru 
getInstance() ? 
Le mer. 29 juin 2016 à 13:26, John D. Ament <john.d.ament at gmail.com> a 
écrit : 
Antoine, 

Looks like we may have missed one of the earlier comments, about reusing 
the instance vs creating a new one each time. 

John 

On Wed, Jun 29, 2016 at 7:23 AM Antoine Sabot-Durand <
antoine at sabot-durand.net> wrote: 
Hi all, 

I just push changed decided in yesterday meeting to PR 290[1]. Please 
review them and give a +1 on it if you're ok for the merge. 
Generated version of the spec is available here [2]. 

Antoine 

[1]: https://github.com/cdi-spec/cdi/pull/290 
[2]: 
https://dl.dropboxusercontent.com/u/2898173/cdi-spec.html#bootstrap-se 

_______________________________________________
cdi-dev mailing list
cdi-dev at lists.jboss.org
https://lists.jboss.org/mailman/listinfo/cdi-dev

Note that for all code provided on this list, the provider licenses the 
code under the Apache License, Version 2 (
http://www.apache.org/licenses/LICENSE-2.0.html). For all other ideas 
provided on this list, the provider waives all patent and other 
intellectual property rights inherent in such information.
_______________________________________________
cdi-dev mailing list
cdi-dev at lists.jboss.org
https://lists.jboss.org/mailman/listinfo/cdi-dev

Note that for all code provided on this list, the provider licenses the 
code under the Apache License, Version 2 (
http://www.apache.org/licenses/LICENSE-2.0.html). For all other ideas 
provided on this list, the provider waives all patent and other 
intellectual property rights inherent in such information. 

Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 
741598. 
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
_______________________________________________
cdi-dev mailing list
cdi-dev at lists.jboss.org
https://lists.jboss.org/mailman/listinfo/cdi-dev

Note that for all code provided on this list, the provider licenses the 
code under the Apache License, Version 2 (
http://www.apache.org/licenses/LICENSE-2.0.html). For all other ideas 
provided on this list, the provider waives all patent and other 
intellectual property rights inherent in such information.

Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 
741598. 
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/cdi-dev/attachments/20160629/0ec4db77/attachment-0001.html