From issues at jboss.org  Wed Feb  6 11:03:03 2019
From: issues at jboss.org (Matej Novotny (Jira))
Date: Wed, 6 Feb 2019 11:03:03 -0500 (EST)
Subject: [cdi-dev] [JBoss JIRA] (CDI-686) Could InterceptionFactory accept
 an interface as type parameter
In-Reply-To: <JIRA.12678171.1487697120000@Atlassian.JIRA>
References: <JIRA.12678171.1487697120000@Atlassian.JIRA>
	<JIRA.12678171.1487697120000@jira.app.mwc.hst.phx2.redhat.com>
Message-ID: <JIRA.12678171.1487697120000.20877.1549468983544@Atlassian.JIRA>


    [ https://issues.jboss.org/browse/CDI-686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13691952#comment-13691952 ] 

Matej Novotny commented on CDI-686:
-----------------------------------

I have taken a stab at this with Weld 3.1.0.Final and managed to come up with a working prototype that can base {{InterceptionFactory}} off an interface while providing even unproxyable instance in the end. So it's definitely possible yet comes with many question marks attached. Here are  some from the top of my head with my thoughts on them:
* What about the interceptor binding(s) on the implementation class? Do you retain them or toss them away?
** IMO toss away, since it can be unproxyable, there is no reason to have them there in the first place
* What about binding on interface itself?
** There is a possibility that the interface has some bindings, but CDI disregards annotations on interfaces in general, I would do the same here
** Accepting those would also introduce a problem of clashes in values if you try to programatically add the same annotation that is already present on the interface
* What about hierarchies of interfaces - what if I add a class-level binding programatically, does it apply to methods from this interface's predecessors that weren't overriden?
** Here I honestly don't know, I went with _no_ in the first draft just because it required extra magic to make that happen and it's a corner case

> Could InterceptionFactory accept an interface as type parameter
> ---------------------------------------------------------------
>
>                 Key: CDI-686
>                 URL: https://issues.jboss.org/browse/CDI-686
>             Project: CDI Specification Issues
>          Issue Type: Clarification
>    Affects Versions: 2.0 .Final
>            Reporter: Antoine Sabot-Durand
>            Assignee: Antoine Sabot-Durand
>            Priority: Major
>             Fix For: 2.0 .Final
>
>
> If you take this code:
> {code:java}
>     @Produces
>     public List<Object> produceList(InterceptionFactory<List<Object>> interceptionFactory) {
>         interceptionFactory.ignoreFinalMethods().configure().filterMethods((m) -> {
>             if (m.getJavaMember().getName().equals("add")
>                     && m.getJavaMember().getParameterCount() == 1) {
>                 return true;
>             }
>             return false;
>         }).findFirst().get().add(Monitor.Literal.INSTANCE);
>         return interceptionFactory.createInterceptedInstance(new ArrayList<>());
>     }
> {code}
> Parameterized type for injected {{InterceptionFactory}} is an interface {{List<Object>}}, so when calling {{configure()}}, user will work with an {{AnnotatedTypeConfigurator<List<Object>>}} to apply interceptor binding.
> In a standard interceptor usage, interceptor binding on interface are ignored (even if they have {{@Inherited}} annotation), so doing it with {{InterceptionFactory}} could be confusing for some user.



--
This message was sent by Atlassian Jira
(v7.12.1#712002)

From issues at jboss.org  Fri Feb 15 08:24:00 2019
From: issues at jboss.org (Doychin Bondzhev (Jira))
Date: Fri, 15 Feb 2019 08:24:00 -0500 (EST)
Subject: [cdi-dev] [JBoss JIRA] (CDI-743) NPE when trying to get BeanManager
 after container was closed
In-Reply-To: <JIRA.12792507.1550236993000@Atlassian.JIRA>
References: <JIRA.12792507.1550236993000@Atlassian.JIRA>
	<JIRA.12792507.1550236993989@jira.app.mwc.hst.phx2.redhat.com>
Message-ID: <JIRA.12792507.1550236993000.24109.1550237040205@Atlassian.JIRA>

Doychin Bondzhev created CDI-743:
------------------------------------

             Summary: NPE when trying to get BeanManager after container was closed
                 Key: CDI-743
                 URL: https://issues.jboss.org/browse/CDI-743
             Project: CDI Specification Issues
          Issue Type: Bug
    Affects Versions: 2.0.SP1, 2.0 .Final
         Environment: simple application that uses weld-se-core and cdi api.
            Reporter: Doychin Bondzhev


CDI.current() should produce IllegalStateException when there is no active container at the moment.

Instead on the second call in the sample application CDI.current() returns null and that results in NPE. 



--
This message was sent by Atlassian Jira
(v7.12.1#712002)

From issues at jboss.org  Fri Feb 15 09:00:00 2019
From: issues at jboss.org (Doychin Bondzhev (Jira))
Date: Fri, 15 Feb 2019 09:00:00 -0500 (EST)
Subject: [cdi-dev] [JBoss JIRA] (CDI-743) NPE when trying to get BeanManager
 after container was closed
In-Reply-To: <JIRA.12792507.1550236994000@Atlassian.JIRA>
References: <JIRA.12792507.1550236994000@Atlassian.JIRA>
	<JIRA.12792507.1550236994000@jira.app.mwc.hst.phx2.redhat.com>
Message-ID: <JIRA.12792507.1550236994000.24332.1550239200644@Atlassian.JIRA>


    [ https://issues.jboss.org/browse/CDI-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13696018#comment-13696018 ] 

Doychin Bondzhev commented on CDI-743:
--------------------------------------

Looks like the source of the problem is incorrect implementation in Weld for getCDI method. 
It should not return null. Instead it should throw IllegalStateException

> NPE when trying to get BeanManager after container was closed
> -------------------------------------------------------------
>
>                 Key: CDI-743
>                 URL: https://issues.jboss.org/browse/CDI-743
>             Project: CDI Specification Issues
>          Issue Type: Bug
>    Affects Versions: 2.0 .Final, 2.0.SP1
>         Environment: simple application that uses weld-se-core and cdi api.
>            Reporter: Doychin Bondzhev
>            Priority: Major
>
> CDI.current() should produce IllegalStateException when there is no active container at the moment.
> Instead on the second call in the sample application CDI.current() returns null and that results in NPE. 



--
This message was sent by Atlassian Jira
(v7.12.1#712002)

From issues at jboss.org  Fri Feb 15 09:02:00 2019
From: issues at jboss.org (Doychin Bondzhev (Jira))
Date: Fri, 15 Feb 2019 09:02:00 -0500 (EST)
Subject: [cdi-dev] [JBoss JIRA] (CDI-743) NPE when trying to get BeanManager
 after container was closed
In-Reply-To: <JIRA.12792507.1550236994000@Atlassian.JIRA>
References: <JIRA.12792507.1550236994000@Atlassian.JIRA>
	<JIRA.12792507.1550236994000@jira.app.mwc.hst.phx2.redhat.com>
Message-ID: <JIRA.12792507.1550236994000.24337.1550239320353@Atlassian.JIRA>


    [ https://issues.jboss.org/browse/CDI-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13696020#comment-13696020 ] 

Doychin Bondzhev commented on CDI-743:
--------------------------------------

Please close this issue. I will open it against weld. 

> NPE when trying to get BeanManager after container was closed
> -------------------------------------------------------------
>
>                 Key: CDI-743
>                 URL: https://issues.jboss.org/browse/CDI-743
>             Project: CDI Specification Issues
>          Issue Type: Bug
>    Affects Versions: 2.0 .Final, 2.0.SP1
>         Environment: simple application that uses weld-se-core and cdi api.
>            Reporter: Doychin Bondzhev
>            Priority: Major
>
> CDI.current() should produce IllegalStateException when there is no active container at the moment.
> Instead on the second call in the sample application CDI.current() returns null and that results in NPE. 



--
This message was sent by Atlassian Jira
(v7.12.1#712002)

From issues at jboss.org  Fri Feb 15 09:38:00 2019
From: issues at jboss.org (Matej Novotny (Jira))
Date: Fri, 15 Feb 2019 09:38:00 -0500 (EST)
Subject: [cdi-dev] [JBoss JIRA] (CDI-743) NPE when trying to get BeanManager
 after container was closed
In-Reply-To: <JIRA.12792507.1550236994000@Atlassian.JIRA>
References: <JIRA.12792507.1550236994000@Atlassian.JIRA>
	<JIRA.12792507.1550236994000@jira.app.mwc.hst.phx2.redhat.com>
Message-ID: <JIRA.12792507.1550236994000.24581.1550241480637@Atlassian.JIRA>


     [ https://issues.jboss.org/browse/CDI-743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matej Novotny updated CDI-743:
------------------------------
    Steps to Reproduce: 
Try to run this application:

{code}
import javax.enterprise.inject.se.SeContainer;
import javax.enterprise.inject.se.SeContainerInitializer;
import javax.enterprise.inject.spi.CDI;

public class NPEOnSecondGetBeanManager {

    public static void main(String[] args) {
        SeContainer container = SeContainerInitializer.newInstance()
                                                      .disableDiscovery()
                                                      .addBeanClasses(BeanClass.class)
                                                      .initialize();
        CDI.current().getBeanManager();
        container.close();

        CDI.current().getBeanManager();
    }

    public static class BeanClass {
    }
}
{code}

  was:
Try to run this application:

import javax.enterprise.inject.se.SeContainer;
import javax.enterprise.inject.se.SeContainerInitializer;
import javax.enterprise.inject.spi.CDI;

public class NPEOnSecondGetBeanManager {

    public static void main(String[] args) {
        SeContainer container = SeContainerInitializer.newInstance()
                                                      .disableDiscovery()
                                                      .addBeanClasses(BeanClass.class)
                                                      .initialize();
        CDI.current().getBeanManager();
        container.close();

        CDI.current().getBeanManager();
    }

    public static class BeanClass {
    }
}




> NPE when trying to get BeanManager after container was closed
> -------------------------------------------------------------
>
>                 Key: CDI-743
>                 URL: https://issues.jboss.org/browse/CDI-743
>             Project: CDI Specification Issues
>          Issue Type: Bug
>    Affects Versions: 2.0 .Final, 2.0.SP1
>         Environment: simple application that uses weld-se-core and cdi api.
>            Reporter: Doychin Bondzhev
>            Priority: Major
>
> CDI.current() should produce IllegalStateException when there is no active container at the moment.
> Instead on the second call in the sample application CDI.current() returns null and that results in NPE. 



--
This message was sent by Atlassian Jira
(v7.12.1#712002)

From issues at jboss.org  Fri Feb 15 09:41:00 2019
From: issues at jboss.org (Matej Novotny (Jira))
Date: Fri, 15 Feb 2019 09:41:00 -0500 (EST)
Subject: [cdi-dev] [JBoss JIRA] (CDI-743) NPE when trying to get BeanManager
 after container was closed
In-Reply-To: <JIRA.12792507.1550236994000@Atlassian.JIRA>
References: <JIRA.12792507.1550236994000@Atlassian.JIRA>
	<JIRA.12792507.1550236994000@jira.app.mwc.hst.phx2.redhat.com>
Message-ID: <JIRA.12792507.1550236994000.24591.1550241660092@Atlassian.JIRA>


    [ https://issues.jboss.org/browse/CDI-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13696039#comment-13696039 ] 

Matej Novotny commented on CDI-743:
-----------------------------------

Actually, I think that {{getCDIProvider()}} method should probably check upon every access that the chosen provider (even the cached one) still returns non-null value from {{getCDI()}}.

That, or it should catch ISE from the invocation of {{getCDI()}} because currently it doesn't take into consideration that providers would do that.
Imagine a situation with multiple CDI providers and you read Weld's one first and since no Weld container runs at the moment, it blows up with ISE. Now what{{CDI}} does is that it stops iterating over all providers and proliferates this exception to you.

> NPE when trying to get BeanManager after container was closed
> -------------------------------------------------------------
>
>                 Key: CDI-743
>                 URL: https://issues.jboss.org/browse/CDI-743
>             Project: CDI Specification Issues
>          Issue Type: Bug
>    Affects Versions: 2.0 .Final, 2.0.SP1
>         Environment: simple application that uses weld-se-core and cdi api.
>            Reporter: Doychin Bondzhev
>            Priority: Major
>
> CDI.current() should produce IllegalStateException when there is no active container at the moment.
> Instead on the second call in the sample application CDI.current() returns null and that results in NPE. 



--
This message was sent by Atlassian Jira
(v7.12.1#712002)

From issues at jboss.org  Fri Feb 15 09:43:00 2019
From: issues at jboss.org (Matej Novotny (Jira))
Date: Fri, 15 Feb 2019 09:43:00 -0500 (EST)
Subject: [cdi-dev] [JBoss JIRA] (CDI-743) NPE when trying to get BeanManager
 after container was closed
In-Reply-To: <JIRA.12792507.1550236994000@Atlassian.JIRA>
References: <JIRA.12792507.1550236994000@Atlassian.JIRA>
	<JIRA.12792507.1550236994000@jira.app.mwc.hst.phx2.redhat.com>
Message-ID: <JIRA.12792507.1550236994000.24598.1550241780379@Atlassian.JIRA>


    [ https://issues.jboss.org/browse/CDI-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13696039#comment-13696039 ] 

Matej Novotny edited comment on CDI-743 at 2/15/19 9:42 AM:
------------------------------------------------------------

Actually, I think that {{getCDIProvider()}} method should probably check upon every access that the chosen provider (even the cached one) still returns non-null value from {{getCDI()}}.

That, or better still, it should catch ISE from the invocation of {{getCDI()}} because currently it doesn't take into consideration that providers would do that despite the fact that {{getCDI()}} contract clearly states ISE as a valid "return" option.

Imagine a situation with multiple CDI providers and you read Weld's one first and since no Weld container runs at the moment, it blows up with ISE. Now what{{CDI}} does is that it stops iterating over all providers and proliferates this exception to you effectively hiding remaining CDI providers that could have worked.


was (Author: manovotn):
Actually, I think that {{getCDIProvider()}} method should probably check upon every access that the chosen provider (even the cached one) still returns non-null value from {{getCDI()}}.

That, or it should catch ISE from the invocation of {{getCDI()}} because currently it doesn't take into consideration that providers would do that.
Imagine a situation with multiple CDI providers and you read Weld's one first and since no Weld container runs at the moment, it blows up with ISE. Now what{{CDI}} does is that it stops iterating over all providers and proliferates this exception to you.

> NPE when trying to get BeanManager after container was closed
> -------------------------------------------------------------
>
>                 Key: CDI-743
>                 URL: https://issues.jboss.org/browse/CDI-743
>             Project: CDI Specification Issues
>          Issue Type: Bug
>    Affects Versions: 2.0 .Final, 2.0.SP1
>         Environment: simple application that uses weld-se-core and cdi api.
>            Reporter: Doychin Bondzhev
>            Priority: Major
>
> CDI.current() should produce IllegalStateException when there is no active container at the moment.
> Instead on the second call in the sample application CDI.current() returns null and that results in NPE. 



--
This message was sent by Atlassian Jira
(v7.12.1#712002)

From issues at jboss.org  Fri Feb 15 09:53:00 2019
From: issues at jboss.org (Doychin Bondzhev (Jira))
Date: Fri, 15 Feb 2019 09:53:00 -0500 (EST)
Subject: [cdi-dev] [JBoss JIRA] (CDI-743) NPE when trying to get BeanManager
 after container was closed
In-Reply-To: <JIRA.12792507.1550236994000@Atlassian.JIRA>
References: <JIRA.12792507.1550236994000@Atlassian.JIRA>
	<JIRA.12792507.1550236994000@jira.app.mwc.hst.phx2.redhat.com>
Message-ID: <JIRA.12792507.1550236994000.24637.1550242380106@Atlassian.JIRA>


    [ https://issues.jboss.org/browse/CDI-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13696047#comment-13696047 ] 

Doychin Bondzhev commented on CDI-743:
--------------------------------------

This was the first thing I implemented.
I will open PR with my change for discussion.

> NPE when trying to get BeanManager after container was closed
> -------------------------------------------------------------
>
>                 Key: CDI-743
>                 URL: https://issues.jboss.org/browse/CDI-743
>             Project: CDI Specification Issues
>          Issue Type: Bug
>    Affects Versions: 2.0 .Final, 2.0.SP1
>         Environment: simple application that uses weld-se-core and cdi api.
>            Reporter: Doychin Bondzhev
>            Priority: Major
>
> CDI.current() should produce IllegalStateException when there is no active container at the moment.
> Instead on the second call in the sample application CDI.current() returns null and that results in NPE. 



--
This message was sent by Atlassian Jira
(v7.12.1#712002)

From issues at jboss.org  Fri Feb 15 10:06:00 2019
From: issues at jboss.org (Doychin Bondzhev (Jira))
Date: Fri, 15 Feb 2019 10:06:00 -0500 (EST)
Subject: [cdi-dev] [JBoss JIRA] (CDI-743) NPE when trying to get BeanManager
 after container was closed
In-Reply-To: <JIRA.12792507.1550236994000@Atlassian.JIRA>
References: <JIRA.12792507.1550236994000@Atlassian.JIRA>
	<JIRA.12792507.1550236994000@jira.app.mwc.hst.phx2.redhat.com>
Message-ID: <JIRA.12792507.1550236994000.24802.1550243160403@Atlassian.JIRA>


     [ https://issues.jboss.org/browse/CDI-743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doychin Bondzhev updated CDI-743:
---------------------------------
    Git Pull Request: https://github.com/cdi-spec/cdi/pull/394


> NPE when trying to get BeanManager after container was closed
> -------------------------------------------------------------
>
>                 Key: CDI-743
>                 URL: https://issues.jboss.org/browse/CDI-743
>             Project: CDI Specification Issues
>          Issue Type: Bug
>    Affects Versions: 2.0 .Final, 2.0.SP1
>         Environment: simple application that uses weld-se-core and cdi api.
>            Reporter: Doychin Bondzhev
>            Priority: Major
>
> CDI.current() should produce IllegalStateException when there is no active container at the moment.
> Instead on the second call in the sample application CDI.current() returns null and that results in NPE. 



--
This message was sent by Atlassian Jira
(v7.12.1#712002)

From issues at jboss.org  Fri Feb 15 10:07:00 2019
From: issues at jboss.org (Doychin Bondzhev (Jira))
Date: Fri, 15 Feb 2019 10:07:00 -0500 (EST)
Subject: [cdi-dev] [JBoss JIRA] (CDI-743) NPE when trying to get BeanManager
 after container was closed
In-Reply-To: <JIRA.12792507.1550236994000@Atlassian.JIRA>
References: <JIRA.12792507.1550236994000@Atlassian.JIRA>
	<JIRA.12792507.1550236994000@jira.app.mwc.hst.phx2.redhat.com>
Message-ID: <JIRA.12792507.1550236994000.24821.1550243220578@Atlassian.JIRA>


    [ https://issues.jboss.org/browse/CDI-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13696047#comment-13696047 ] 

Doychin Bondzhev edited comment on CDI-743 at 2/15/19 10:06 AM:
----------------------------------------------------------------

This was the first thing I implemented.
I will open PR with my change for discussion.
But this PR relies on the fact that null is valid return value for {{getCDI}}


was (Author: doychin):
This was the first thing I implemented.
I will open PR with my change for discussion.

> NPE when trying to get BeanManager after container was closed
> -------------------------------------------------------------
>
>                 Key: CDI-743
>                 URL: https://issues.jboss.org/browse/CDI-743
>             Project: CDI Specification Issues
>          Issue Type: Bug
>    Affects Versions: 2.0 .Final, 2.0.SP1
>         Environment: simple application that uses weld-se-core and cdi api.
>            Reporter: Doychin Bondzhev
>            Priority: Major
>
> CDI.current() should produce IllegalStateException when there is no active container at the moment.
> Instead on the second call in the sample application CDI.current() returns null and that results in NPE. 



--
This message was sent by Atlassian Jira
(v7.12.1#712002)