<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Hi Rick,<div><br></div><div>We're all new to this group, the only person who has spent much time on CDI 1.1 so far is me, as I collated issues from CDI 1.0. Comments inline.</div><div><br><div><div>On 26 Apr 2011, at 00:24, Rick Hightower wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">I am new to the group. Where is the source code for CDI 1.1?</blockquote><div><br></div><div>The "source code" for CDI is the specification, which is in docbook format, and available at <a href="https://github.com/pmuir/cdi">https://github.com/pmuir/cdi</a> - this is the 1.0 spec with a few updates that Gavin had put in a while back. One task I still need to do is diff this spec to the 1.0 spec and see what issues he already addressed. At some point we may include a reference API (based on the one Weld distributed for 1.0) but I'm not sure yet.</div><br><blockquote type="cite"><div>I can branch it, add this and solicit feedback.</div></blockquote><div><br></div><div>Please do :-)</div><div><br></div><div>From previous experience I would suggest putting up a complete proposal on the JIRA issue for this, which walks through any algorithms, APIs and edge cases. This can then be discussed by the EG. I suggest doing this before diving in and editing the spec, as making spec document changes can be a large task if you don't know it well (as your change can impact on many sections!).</div><div><br></div><div>Eventually, I would suggest making changes, and then creating a github pull request where we can use the github code review features to comb through it.</div><br><blockquote type="cite"><div>I think working code is much easier to talk about than bullet points.</div></blockquote><div><br></div><div>I'm afraid most of the work here will be bullet points, very little (ok no) working code ;-)</div><br><blockquote type="cite"><div><br></div><div><br>
<br><div class="gmail_quote">On Mon, Apr 25, 2011 at 4:07 PM, Rick Hightower <span dir="ltr"><<a href="mailto:richardhightower@gmail.com">richardhightower@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
We need a general purpose way of finding a BeanManager.<div>+1 for me.</div><div><br></div><div>This way should include JNDI lookup to a fallback BeanManagerLocator that uses a ServiceLoader</div><div>+1 for me.</div><div>
<br></div><div>I think the behavior should look like this:</div><div><br></div><div><ul><li>Lookup BeanManager in JNDI</li><li>If not found, try to load BeanManagerLocator from system property.</li><li>If not found, try to load BeanManagerLocator from ServiceLoader.</li>
<li>If more than one BeanManagerLocator found, sort by priority or die if there is more than one. (not sure about the sort, I think it should die, but can be convinced otherwise).</li><li>Once the BeanManagerLocator is found, use it to return a BeanManager</li>
</ul></div><div><br></div><div>In addition,</div><div><br></div><div>I think we need a simplified interface for BeanManager. </div><div><br></div><div><a href="https://github.com/CDISource/cdisource/blob/master/beancontainer/api/src/main/java/org/cdisource/beancontainer/BeanContainer.java" target="_blank">https://github.com/CDISource/cdisource/blob/master/beancontainer/api/src/main/java/org/cdisource/beancontainer/BeanContainer.java</a></div>
<div><br></div><div>This could just be a utility class, but it should be included with CDI 1.1. I think the BeanManager interface is too low level.</div><div><br></div><font color="#888888"><div><br></div><div><br>-- <br>
<b>Rick Hightower</b><br><a href="tel:%28415%29%20968-9037" value="+14159689037" target="_blank">(415) 968-9037</a> <br><a href="http://www.google.com/profiles/RichardHightower" target="_blank">Profile</a> <br><br>
</div>
</font></blockquote></div><br><br clear="all"><br>-- <br><b>Rick Hightower</b><br>(415) 968-9037 <br><a href="http://www.google.com/profiles/RichardHightower" target="_blank">Profile</a> <br><br>
</div>
_______________________________________________<br>cdi-dev mailing list<br><a href="mailto:cdi-dev@lists.jboss.org">cdi-dev@lists.jboss.org</a><br>https://lists.jboss.org/mailman/listinfo/cdi-dev<br></blockquote></div><br></div></body></html>