<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Hi John, some thoughts:<br>
<br>
- instead of using BeanManager it makes more sense to me to return a
CDI instance, which is a more user-friendly API (and it also exposes
access to BeanManager)<br>
- is there a usecase for arbitrary keys of the "params" map or is
Map<String, ?> sufficient?<br>
- if we could move the shutdown() method from
<meta http-equiv="content-type" content="text/html;
charset=windows-1252">
CDIContainer to the actual container handle that we obtain from
initialize(), that would look more object-oriented<br>
- what exactly is initialize() supposed to do? Is it supposed to
start scanning the entire classpath for CDI beans? That could be a
problem especially with spring-boot-like fat jars. I think we need
an API to tell the container which classes / packages to consider.
Something like Guice's binding API perhaps?<br>
<br>
- the proposal makes me wonder whether retrofitting this
functionality to the CDI class wouldn't be a better option. It could
look like:<br>
<br>
CDI container = CDI.initialize();<br>
container.select(Foo.class).get();<br>
container.shutdown();<br>
<br>
compare it to:<br>
<br>
<meta http-equiv="content-type" content="text/html;
charset=windows-1252">
CDIContainer container = CDIContainerLoader.
<meta http-equiv="content-type" content="text/html;
charset=windows-1252">
getCDIContainer();<br>
BeanManager manager = container.initialize();<br>
manager.getBeans(...);<br>
container.shutdown(manager);<br>
<br>
<div class="moz-cite-prefix">On 02/10/2015 06:58 PM, John D. Ament
wrote:<br>
</div>
<blockquote
cite="mid:CAOqetn9htbOUAy4g0sHUtLGTk8NLqjiJt6Rs09M7P5Uy0tkXpQ@mail.gmail.com"
type="cite">
<div dir="ltr">All,
<div><br>
</div>
<div>I have the updated API here, and wanted to solicit any
final feedback before updating the google doc and spec pages.</div>
<div><br>
</div>
<div><a moz-do-not-send="true"
href="https://github.com/johnament/cdi/commit/2c362161e18dd521f8e83c27151ddad467a1c01c">https://github.com/johnament/cdi/commit/2c362161e18dd521f8e83c27151ddad467a1c01c</a><br>
</div>
<div><br>
</div>
<div>Let me know your thoughts.</div>
<div><br>
</div>
<div>Thanks,</div>
<div><br>
</div>
<div>John</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
cdi-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:cdi-dev@lists.jboss.org">cdi-dev@lists.jboss.org</a>
<a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/cdi-dev">https://lists.jboss.org/mailman/listinfo/cdi-dev</a>
Note that for all code provided on this list, the provider licenses the code under the Apache License, Version 2 (<a class="moz-txt-link-freetext" href="http://www.apache.org/licenses/LICENSE-2.0.html">http://www.apache.org/licenses/LICENSE-2.0.html</a>). For all other ideas provided on this list, the provider waives all patent and other intellectual property rights inherent in such information.</pre>
</blockquote>
<br>
</body>
</html>