<div dir="ltr">ProxyFactory sounds like a perfect solution indeed.<div><br></div><div>I now got something working, more or less, emphasis on less.</div><div><br></div><div>I first make a "normal" (but effectively dummy) decorator with @Priority available:</div><div><br></div><div><div>@Decorator</div><div>@Priority(PLATFORM_BEFORE + 200)</div><div>public abstract class HttpAuthenticationBaseDecorator implements HttpAuthenticationMechanism, Serializable {</div><div><br></div><div> private static final long serialVersionUID = 1L;</div><div><br></div><div> @Inject</div><div> @Delegate</div><div> HttpAuthenticationMechanism delegateMechanism;</div><div><br></div><div> @Override</div><div> public AuthStatus validateRequest(HttpServletRequest request, HttpServletResponse response, HttpMessageContext httpMessageContext) throws AuthException {</div><div> return delegateMechanism.validateRequest(request, response, httpMessageContext);</div><div> }</div></div><div> // ...</div><div>}</div><div><br></div><div><br></div><div>Then I create a "dynamic/programmatic" decorator:</div><div><br></div><div><br></div><div><div>public class DynamicHttpAuthenticationDecorator implements Decorator<HttpAuthenticationBaseDecorator> {</div><div><br></div><div> private final Set<Type> types = new HashSet<Type>(asList(HttpAuthenticationBaseDecorator.class, Object.class));</div><div> private final Set<Type> decoratedTypes = singleton(HttpAuthenticationMechanism.class);</div><div> </div><div> private final BeanManager beanManager;</div><div> private final InjectionPoint decoratorInjectionPoint;</div><div> private final Set<InjectionPoint> injectionPoints;</div><div><br></div><div> public DynamicHttpAuthenticationDecorator(BeanManager beanManager) {</div><div> </div><div> decoratorInjectionPoint = new DecoratorInjectionPoint(</div><div> HttpAuthenticationMechanism.class, </div><div> beanManager.createAnnotatedType(HttpAuthenticationBaseDecorator.class).getFields().iterator().next(), </div><div> this);</div><div> </div><div> injectionPoints = singleton(decoratorInjectionPoint);</div><div> </div><div> this.beanManager = beanManager;</div><div> }</div><div><br></div><div> public HttpAuthenticationBaseDecorator create(CreationalContext<HttpAuthenticationBaseDecorator> creationalContext) {</div><div> return new AutoApplySessionDecorator(</div><div> (HttpAuthenticationMechanism) beanManager.getInjectableReference(decoratorInjectionPoint, creationalContext));</div><div> }</div><div><br></div><div> public void destroy(HttpAuthenticationBaseDecorator instance, CreationalContext<HttpAuthenticationBaseDecorator> creationalContext) {</div><div> creationalContext.release();</div><div> }</div><div> </div><div> public Set<Type> getTypes() {</div><div> return types;</div><div> }</div><div> </div><div> public Set<Type> getDecoratedTypes() {</div><div> return decoratedTypes;</div><div> }</div><div> </div><div> public Class<?> getBeanClass() {</div><div> return HttpAuthenticationBaseDecorator.class;</div><div> }</div><div><br></div><div> public Type getDelegateType() {</div><div> return HttpAuthenticationMechanism.class;</div><div> }</div><div><br></div><div> public Set<InjectionPoint> getInjectionPoints() {</div><div> return injectionPoints;</div><div> }</div></div><div>}</div><div><br></div><div>This Decorator<T> "pretends" that it's for the dummy decorator, via the getTypes(), but in create() it returns another actual Decorator. Then I create the delegate injection point of that decorator by grabbing the @Delegate annotated field from the real decorator, wrapping that basically in an InjectionPoint and then using that later with beanManager#getInjectableReference.</div><div><br></div><div>Now after adding this via afterBeanDiscovery.addBean(new DynamicHttpAuthenticationDecorator(beanManager)), and it actually gets called at runtime (tested on Weld).</div><div><br></div><div>Disadvantages are a fixed priority and the fact that the dummy decorator is called as well.</div><div><br></div><div>Have to say that implementing the javax.enterprise.inject.spi.Decorator interface, especially the part for grabbing the @Delegate is quite non-obvious.</div><div><br></div><div>What do you think, is this guaranteed to work, or did I abuse the CDI APIs too much here?</div><div><br></div><div>Kind regards,</div><div>Arjan Tijms</div><div><br></div><div><br></div><div><br></div><div><br></div><div><br></div><div><br></div><div><br></div><div><br></div><div><br></div><div><br></div><div><br></div><div><br></div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Mar 2, 2016 at 11:14 PM, Thomas Andraschko <span dir="ltr"><<a href="mailto:andraschko.thomas@gmail.com" target="_blank">andraschko.thomas@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><div>+1<br><br></div>in DeltaSpike we implemented an own mechanism + proxy to invoke interceptors for partial beans.<br></div>We will probably enhance this for such usecases or even producers: <a href="https://issues.apache.org/jira/browse/DELTASPIKE-1069" target="_blank">https://issues.apache.org/jira/browse/DELTASPIKE-1069</a><br></div><br></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">2016-03-02 22:51 GMT+01:00 Romain Manni-Bucau <span dir="ltr"><<a href="mailto:rmannibucau@gmail.com" target="_blank">rmannibucau@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">+1, seems it is the way to fix several issues without introducing a lot of new concepts/API and in term of technical stack it is just standardizing what is there.</div><div class="gmail_extra"><span><font color="#888888"><br clear="all"><div><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><br><span style="font-size:small">Romain Manni-Bucau</span><br><a href="https://twitter.com/rmannibucau" target="_blank">@rmannibucau</a> | <a href="http://rmannibucau.wordpress.com" target="_blank">Blog</a> | <a href="https://github.com/rmannibucau" target="_blank">Github</a> | <a href="https://www.linkedin.com/in/rmannibucau" target="_blank">LinkedIn</a> | <a href="http://www.tomitribe.com" target="_blank">Tomitriber</a></div></div></div></div></div></div></div></div></div></div></font></span><div><div>
<br><div class="gmail_quote">2016-03-02 22:48 GMT+01:00 Mark Struberg <span dir="ltr"><<a href="mailto:struberg@yahoo.de" target="_blank">struberg@yahoo.de</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">ProxyFactory…<br>
<br>
I’m really thinking about introducing something like javax.proxy, maybe as own sub-spec PDF…<br>
<br>
LieGrue,<br>
strub<br>
<div><div><br>
<br>
> Am 02.03.2016 um 16:31 schrieb arjan tijms <<a href="mailto:arjan.tijms@gmail.com" target="_blank">arjan.tijms@gmail.com</a>>:<br>
><br>
> Hi,<br>
><br>
> I'm trying to add decorators and/or interceptors to a Bean<T> that's added via an extension. There doesn't seem to be any way to add interceptors, but decorators seem almost possible.<br>
><br>
> I've added a decorator in the following way:<br>
><br>
><br>
> AnnotatedType<AutoApplySessionDecorator> annotatedType = beanManager.createAnnotatedType(AutoApplySessionDecorator.class);<br>
><br>
> BeanAttributes<AutoApplySessionDecorator> beanAttributes = beanManager.createBeanAttributes(annotatedType);<br>
><br>
> Bean<AutoApplySessionDecorator> bean = beanManager.createBean(beanAttributes, AutoApplySessionDecorator.class, beanManager.getInjectionTargetFactory(annotatedType));<br>
><br>
> afterBeanDiscovery.addBean(bean);<br>
><br>
> Where the "AutoApplySessionDecorator" is an existing (non-scanned) decorator just used as an example.<br>
><br>
><br>
> While this seems to work, the problem is with the enablement. @Priority is not processed in this way, since it's only read from an AnnotatedType that's been added to the deployment (see e.g. in Weld org.jboss.weld.bootstrap.BeanDeployer.processPriority(AnnotatedType<?>)).<br>
><br>
> beans.xml is not really an option here due to the static nature of that and the fact that the decorator needs to be enabled dynamically here, plus that the implementation class of the decorator is a detail I would not like to expose to the application.<br>
><br>
><br>
> Is there any other way to either enable a (synthetic) decorator programmatically, or to add Interceptors to a programmatically added Bean<T>?<br>
><br>
> Kind regards,<br>
> Arjan Tijms<br>
><br>
</div></div>> _______________________________________________<br>
> cdi-dev mailing list<br>
> <a href="mailto:cdi-dev@lists.jboss.org" target="_blank">cdi-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/cdi-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/cdi-dev</a><br>
><br>
> Note that for all code provided on this list, the provider licenses the code under the Apache License, Version 2 (<a href="http://www.apache.org/licenses/LICENSE-2.0.html" rel="noreferrer" target="_blank">http://www.apache.org/licenses/LICENSE-2.0.html</a>). For all other ideas provided on this list, the provider waives all patent and other intellectual property rights inherent in such information.<br>
<br>
<br>
_______________________________________________<br>
cdi-dev mailing list<br>
<a href="mailto:cdi-dev@lists.jboss.org" target="_blank">cdi-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/cdi-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/cdi-dev</a><br>
<br>
Note that for all code provided on this list, the provider licenses the code under the Apache License, Version 2 (<a href="http://www.apache.org/licenses/LICENSE-2.0.html" rel="noreferrer" target="_blank">http://www.apache.org/licenses/LICENSE-2.0.html</a>). For all other ideas provided on this list, the provider waives all patent and other intellectual property rights inherent in such information.</blockquote></div><br></div></div></div>
<br>_______________________________________________<br>
cdi-dev mailing list<br>
<a href="mailto:cdi-dev@lists.jboss.org" target="_blank">cdi-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/cdi-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/cdi-dev</a><br>
<br>
Note that for all code provided on this list, the provider licenses the code under the Apache License, Version 2 (<a href="http://www.apache.org/licenses/LICENSE-2.0.html" rel="noreferrer" target="_blank">http://www.apache.org/licenses/LICENSE-2.0.html</a>). For all other ideas provided on this list, the provider waives all patent and other intellectual property rights inherent in such information.<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
cdi-dev mailing list<br>
<a href="mailto:cdi-dev@lists.jboss.org">cdi-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/cdi-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/cdi-dev</a><br>
<br>
Note that for all code provided on this list, the provider licenses the code under the Apache License, Version 2 (<a href="http://www.apache.org/licenses/LICENSE-2.0.html" rel="noreferrer" target="_blank">http://www.apache.org/licenses/LICENSE-2.0.html</a>). For all other ideas provided on this list, the provider waives all patent and other intellectual property rights inherent in such information.<br></blockquote></div><br></div>