<div dir="ltr">Ok, put it on standby and changing the minutes accordingly<div><br></div></div><br><div class="gmail_quote"><div dir="ltr">Le mer. 6 avr. 2016 à 10:09, Martin Kouba <<a href="mailto:mkouba@redhat.com">mkouba@redhat.com</a>> a écrit :<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I disagree to merge the current version of cdi/pull/272.<br>
<br>
1. The current wording is not clear.<br>
<br>
Esp. the part: "the transaction is in an illegal state".<br>
<br>
I understand that it should mean an IllegalStateException is thrown<br>
during Transaction.registerSynchronization() but I think we should<br>
rather follow the javadoc of this method.<br>
<br>
See also <a href="https://github.com/cdi-spec/cdi/pull/272#discussion_r58493520" rel="noreferrer" target="_blank">https://github.com/cdi-spec/cdi/pull/272#discussion_r58493520</a><br>
<br>
2. Observer ordering<br>
<br>
It might be useful to simulate the observer ordering as if the callback<br>
was sucessfully registered, e.g. BEFORE_COMPLETION notified before<br>
AFTER_COMPLETION and AFTER_FAILURE.<br>
<br>
See also <a href="https://github.com/cdi-spec/cdi/pull/272#issuecomment-206161278" rel="noreferrer" target="_blank">https://github.com/cdi-spec/cdi/pull/272#issuecomment-206161278</a><br>
and ongoing discussion.<br>
<br>
Martin<br>
<br>
Dne 6.4.2016 v 09:32 Antoine Sabot-Durand napsal(a):<br>
> You'll find the minutes here:<br>
><br>
> <a href="https://docs.google.com/document/d/1yxhW--C2b-SKs6nVw8m3nkwfgBBL5aoOz3Hoyg5TWRA/edit?usp=sharing" rel="noreferrer" target="_blank">https://docs.google.com/document/d/1yxhW--C2b-SKs6nVw8m3nkwfgBBL5aoOz3Hoyg5TWRA/edit?usp=sharing</a><br>
><br>
><br>
> _______________________________________________<br>
> cdi-dev mailing list<br>
> <a href="mailto:cdi-dev@lists.jboss.org" target="_blank">cdi-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/cdi-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/cdi-dev</a><br>
><br>
> Note that for all code provided on this list, the provider licenses the code under the Apache License, Version 2 (<a href="http://www.apache.org/licenses/LICENSE-2.0.html" rel="noreferrer" target="_blank">http://www.apache.org/licenses/LICENSE-2.0.html</a>). For all other ideas provided on this list, the provider waives all patent and other intellectual property rights inherent in such information.<br>
><br>
<br>
--<br>
Martin Kouba<br>
Software Engineer<br>
Red Hat, Czech Republic<br>
</blockquote></div>