<div dir="ltr">From the beginning I advocated to have AnnotatedType treated as special case since it can be used from outside a portable extension (that's the reason why ATC and not other configurators, Matej).<div><br></div><div>These are not corner cases since I encountered them on 3rd party framework integration.</div><div><br></div><div>This said, I understand it's rather late to open this topic and with such cold and negative reception I move it to 2.1.</div><div><br></div><div>Antoine</div></div><br><div class="gmail_quote"><div dir="ltr">On Wed, Nov 16, 2016 at 12:59 PM Matej Novotny <<a href="mailto:manovotn@redhat.com">manovotn@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Here are my 0.02$<br class="gmail_msg">
<br class="gmail_msg">
As soon as you extract ATC outside and make it available at any time, a question pops up - Why ATC only? Why not all configurators usable at all times?<br class="gmail_msg">
The above is ofc nonsense and had been discussed before. So, we cannot add all, and therefore doing so for some will make usage inconsistent and confusing.<br class="gmail_msg">
<br class="gmail_msg">
If you really feel like covering the cases you described[1] and making ATC available there, I would go for 1). We don't yet know what will users do with current API; let us not overextend it.<br class="gmail_msg">
<br class="gmail_msg">
> Well, I thought the EG already agreed that the purpose of the<br class="gmail_msg">
> configurator API is not to cover all possible use cases, but the most<br class="gmail_msg">
> common ones.<br class="gmail_msg">
<br class="gmail_msg">
Also, +10 on ^<br class="gmail_msg">
<br class="gmail_msg">
Regards<br class="gmail_msg">
Matej<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
----- Original Message -----<br class="gmail_msg">
> From: "Martin Kouba" <<a href="mailto:mkouba@redhat.com" class="gmail_msg" target="_blank">mkouba@redhat.com</a>><br class="gmail_msg">
> To: "Antoine Sabot-Durand" <<a href="mailto:antoine@sabot-durand.net" class="gmail_msg" target="_blank">antoine@sabot-durand.net</a>>, "cdi-dev" <<a href="mailto:cdi-dev@lists.jboss.org" class="gmail_msg" target="_blank">cdi-dev@lists.jboss.org</a>><br class="gmail_msg">
> Sent: Wednesday, November 16, 2016 12:34:03 PM<br class="gmail_msg">
> Subject: Re: [cdi-dev] AnnotatedTypeConfigurator limitation<br class="gmail_msg">
><br class="gmail_msg">
> Well, I thought the EG already agreed that the purpose of the<br class="gmail_msg">
> configurator API is not to cover all possible use cases, but the most<br class="gmail_msg">
> common ones. And the list of use cases below seems more like a list of<br class="gmail_msg">
> corner cases.<br class="gmail_msg">
><br class="gmail_msg">
> Anyway, if the EG decides to support this, I think we could either go<br class="gmail_msg">
> with 1) or 3) *.<br class="gmail_msg">
><br class="gmail_msg">
> *<br class="gmail_msg">
> BeanManager.getAnnotatedTypeBuilder() that returns a new builder<br class="gmail_msg">
> wrapping a configurator instance.<br class="gmail_msg">
><br class="gmail_msg">
> Martin<br class="gmail_msg">
><br class="gmail_msg">
> Dne 16.11.2016 v 11:30 Antoine Sabot-Durand napsal(a):<br class="gmail_msg">
> > Hi Guys,<br class="gmail_msg">
> ><br class="gmail_msg">
> > Following CDI-642 and 643 I started to explore place where annotatedType<br class="gmail_msg">
> > can be used and where we don't provide access to<br class="gmail_msg">
> > AnnotatedTypeConfigurator [1], I really think we should solve this use<br class="gmail_msg">
> > case to avoid advanced users frustration discovering a new feature they<br class="gmail_msg">
> > can use everywhere (that was my case when realised that I could use it<br class="gmail_msg">
> > in BBD for Qualifier or interceptorBinding addition).<br class="gmail_msg">
> ><br class="gmail_msg">
> > Possible solutions:<br class="gmail_msg">
> > 1) Add a hook to each of these place to obtain an AnnotatedTypeConfigurator<br class="gmail_msg">
> > 2) Add BM.createAnnotatypeConfigurator(Class) and<br class="gmail_msg">
> > BM.createAnnotatedType(ATC)<br class="gmail_msg">
> > 3) Add a Builder class that would provide a configure method<br class="gmail_msg">
> > 4) Transform AnnotatedTypeConfigurator into a Builder and simplify SPI<br class="gmail_msg">
> > using AnnotatedTypeConfigurator.<br class="gmail_msg">
> ><br class="gmail_msg">
> > Antoine<br class="gmail_msg">
> ><br class="gmail_msg">
> > [1] Non exhaustive list :<br class="gmail_msg">
> > - BeforeTypeDiscovery for addQualifier and addInterceptorBinding<br class="gmail_msg">
> > - UnManaged class<br class="gmail_msg">
> > - BeanManager createInjectionTartet and getInjectionTargetFactory or in<br class="gmail_msg">
> > InjectionTarget<br class="gmail_msg">
> > - BeanManager getProducerFactory where a configured AnnotatedField or<br class="gmail_msg">
> > AnnotatedMethod could be useful<br class="gmail_msg">
> ><br class="gmail_msg">
> ><br class="gmail_msg">
> > _______________________________________________<br class="gmail_msg">
> > cdi-dev mailing list<br class="gmail_msg">
> > <a href="mailto:cdi-dev@lists.jboss.org" class="gmail_msg" target="_blank">cdi-dev@lists.jboss.org</a><br class="gmail_msg">
> > <a href="https://lists.jboss.org/mailman/listinfo/cdi-dev" rel="noreferrer" class="gmail_msg" target="_blank">https://lists.jboss.org/mailman/listinfo/cdi-dev</a><br class="gmail_msg">
> ><br class="gmail_msg">
> > Note that for all code provided on this list, the provider licenses the<br class="gmail_msg">
> > code under the Apache License, Version 2<br class="gmail_msg">
> > (<a href="http://www.apache.org/licenses/LICENSE-2.0.html" rel="noreferrer" class="gmail_msg" target="_blank">http://www.apache.org/licenses/LICENSE-2.0.html</a>). For all other ideas<br class="gmail_msg">
> > provided on this list, the provider waives all patent and other<br class="gmail_msg">
> > intellectual property rights inherent in such information.<br class="gmail_msg">
> ><br class="gmail_msg">
><br class="gmail_msg">
> --<br class="gmail_msg">
> Martin Kouba<br class="gmail_msg">
> Software Engineer<br class="gmail_msg">
> Red Hat, Czech Republic<br class="gmail_msg">
> _______________________________________________<br class="gmail_msg">
> cdi-dev mailing list<br class="gmail_msg">
> <a href="mailto:cdi-dev@lists.jboss.org" class="gmail_msg" target="_blank">cdi-dev@lists.jboss.org</a><br class="gmail_msg">
> <a href="https://lists.jboss.org/mailman/listinfo/cdi-dev" rel="noreferrer" class="gmail_msg" target="_blank">https://lists.jboss.org/mailman/listinfo/cdi-dev</a><br class="gmail_msg">
><br class="gmail_msg">
> Note that for all code provided on this list, the provider licenses the code<br class="gmail_msg">
> under the Apache License, Version 2<br class="gmail_msg">
> (<a href="http://www.apache.org/licenses/LICENSE-2.0.html" rel="noreferrer" class="gmail_msg" target="_blank">http://www.apache.org/licenses/LICENSE-2.0.html</a>). For all other ideas<br class="gmail_msg">
> provided on this list, the provider waives all patent and other intellectual<br class="gmail_msg">
> property rights inherent in such information.<br class="gmail_msg">
><br class="gmail_msg">
</blockquote></div>