[embjopr-issues] [JBoss JIRA] Commented: (EMBJOPR-72) Change some HTML bits to improve testability

[Charles Crouch (JIRA)]

    [ https://jira.jboss.org/jira/browse/EMBJOPR-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12452432#action_12452432 ] 

Charles Crouch commented on EMBJOPR-72:
---------------------------------------

(12:13:50 PM) ccrouch: how come <strong> is better than <b.?
(12:13:54 PM) ccrouch: <b>?
(12:13:56 PM) ozizka: I'll comment such changes in this jira issue, to keep track of such changes (but not many expected)
(12:14:17 PM) ccrouch: ok, make sure to add the commit revision numbers
(12:14:19 PM) ozizka: ccrouch: Well, that's a matter of HTML philosophy...
(12:14:37 PM) ozizka: rather than actual meaning. But once doing that, <strong> is better, because,
(12:14:38 PM) ccrouch: ah ok, lets not going changing the philosophy right now :-)
(12:14:44 PM) ozizka: ok
(12:14:57 PM) ozizka: well, once started the sentence:
(12:15:08 PM) ccrouch: so adding span's is ok, but lets try to minimize the changes here
(12:16:06 PM) ozizka: <strong> describes the meaning of contained information, whether <b> describes only how it should look and carries no information about document's structure. That's the diff.
(12:16:29 PM) ccrouch: right, but from your testing perspective you shouldnt care right :-)
(12:16:57 PM) ozizka: I'm changing <b> to <strong> because above, there's <strong> too, so to unify - otherwise, I would have to duplicate whole XPath procedure :)
(12:17:23 PM) ozizka: ccrouch: Right, I shouldn't... I will try not to :)
(12:19:12 PM) ccrouch: ok well if it simplifies stuff for you and it *doesnt* change how stuff renders in IE and FF i'm good
(12:19:32 PM) ccrouch: i didnt want to change stuff just for the sake of changing it
(12:20:10 PM) ozizka: ccrouch: Sure, I share that approach with  you
(12:20:33 PM) ccrouch: ok cool, i think we're on the same page. go for it

> Change some HTML bits to improve testability
> --------------------------------------------
>
>                 Key: EMBJOPR-72
>                 URL: https://jira.jboss.org/jira/browse/EMBJOPR-72
>             Project: Embedded Jopr
>          Issue Type: Task
>            Reporter: Ondrej Žižka
>            Assignee: Ondrej Žižka
>
> For QA, we use XPath.
> Some HTML constructs are XPath - unfriendly, like mixed content on various places where we need to work with the text.
> Mixed content = element that has both text nodes and elements as children.
> These changes should not affect functionality nor appearance of EmbJopr.
> The changes would be like this one:
>  Old:
>       <h:column>
>         <b>#{ summaryMeasurementDefinitionMap[trait.measurementData.name].displayName}:</b>
>         #{ trait.measurementValueAndUnits}
>       </h:column>
> New:
>       <h:column>
>         <strong>#{ summaryMeasurementDefinitionMap[trait.measurementData.name].displayName}:</strong>
>         <span>#{ trait.measurementValueAndUnits}</span>
>       </h:column>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira