[embjopr-issues] [JBoss JIRA] Commented: (EMBJOPR-97) Add ConnectionProperties resource config property to all Datasources

[Charles Crouch (JIRA)]

    [ https://jira.jboss.org/jira/browse/EMBJOPR-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12458047#action_12458047 ] 

Charles Crouch commented on EMBJOPR-97:
---------------------------------------

I got this partially working locally by specifying 

 <c:map-property name="connection-properties" required="false"/>

in the rhq-plugin.xml and then fixing AbstractPropertyMapToCompositeValueAdapter Line 61: 

MetaType mapMemberMetaType = compositeValue.getMetaType().getType(mapMemberPropName);

so that it is never null. Before when you add a new connection property item then mapMemberMetaType was getting set to null before because compositeValue doesnt contain the new item, e.g. it looks like

MapCompositeMetaType{java.util.Map items=[name=char.encoding type=java.lang.String], [name=something type=java.lang.String]}:{char.encoding=SimpleMetaType:java.lang.String:UTF-8, something=SimpleMetaType:java.lang.String:else}


Next problem is that changes don't appear to be persisting across server restarts. This seems to work for top level simple types, so this could be a specific problem with how we're handling maps, or it could be a PS issue.

> Add ConnectionProperties resource config property to all Datasources
> --------------------------------------------------------------------
>
>                 Key: EMBJOPR-97
>                 URL: https://jira.jboss.org/jira/browse/EMBJOPR-97
>             Project: Embedded Jopr
>          Issue Type: Bug
>          Components: Plugin
>            Reporter: Charles Crouch
>            Assignee: Charles Crouch
>             Fix For: 1.2
>
>         Attachments: screenshot-1.jpg
>
>
> See EMBJOPR-58 for how we noticed this was missing. Need to work out what type it should map to. Right now it seems to a simple one:
> ConnectionProperties.type=SimpleMetaType:java.lang.String:, 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira