[embjopr-issues] [JBoss JIRA] (EMBJOPR-344) If script returns -1, operation fails without details. Let's display stderr.

[RH Bugzilla Integration (JIRA)]

    [ https://issues.jboss.org/browse/EMBJOPR-344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12696840#comment-12696840 ] 

RH Bugzilla Integration commented on EMBJOPR-344:
-------------------------------------------------

bkramer <bkramer at redhat.com> made a comment on [bug 824774|https://bugzilla.redhat.com/show_bug.cgi?id=824774]

Description of problem:
If some shell script returns something else than 0, RHQ operation only says "Exit code was '1', see operation results for details", but there are no op results. The RHQ UI should not fail with this generic message.


Version-Release number of selected component (if applicable):
RHQ 4.2

How reproducible:
Always


Steps to Reproduce:
1.run the wsprovide.sh with no arguments.
  
Actual results:
The operation will fail but the output of the failure icon will show the following generic message:

java.lang.Exception: Exit code was '1', see operation results for details
at org.rhq.core.pc.operation.OperationInvocation.run(OperationInvocation.java:278)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
at java.lang.Thread.run(Thread.java:636)



Expected results:
The operation should fail but the output of the failure icon should point to the proper cause of the failure. 


Additional info:
The same issue was raised for:

1. JBoss Admin console (EMBJOPR-344: https://issues.jboss.org/browse/EMBJOPR-344) 
2. JON (https://bugzilla.redhat.com/show_bug.cgi?id=824773)
                
> If  script returns -1, operation fails without details. Let's display stderr.
> -----------------------------------------------------------------------------
>
>                 Key: EMBJOPR-344
>                 URL: https://issues.jboss.org/browse/EMBJOPR-344
>             Project: Embedded Jopr
>          Issue Type: Feature Request
>    Affects Versions: 1.3.4
>            Reporter: Ondrej Zizka
>            Assignee: Charles Crouch
>            Priority: Minor
>
> If some shell script returns something else than 0, embjopr operation only says "Exit code was '1', see operation results for details", but there are no op results - that applies for JON.
> The admin console should show some info about how to use the script, not fail with this generic message.
> This might apply to all scripts which do not behave so by default (like classpath.sh).
> STR:
> 1) run the wsprovide.sh with no arguments .
> java.lang.Exception: Exit code was '1', see operation results for details
>         at org.rhq.core.pc.operation.OperationInvocation.run(OperationInvocation.java:278)
>         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
>         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
>         at java.lang.Thread.run(Thread.java:636)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira