<div dir="ltr"><div><div>I really like that approach. Yes. I think it makes a lot of sense to do aggregation in combination with a template-specific @Bundle annotation. Actually, if we are going this far, we *could* actually re-use the @Templated annotation itself, merely with an annotation and default value. Note that there is one down-side.<br>
<br></div>@Templated("layouts/template.html")<br>@Templated(value="layouts/mytemplate.html", bundle="i18n/mytemplate.txt")<br><br></div>The benefit of @Bundle is that you do not need to specify a value="" attribute in order to be able to access the bundle="" attribute.<br>
<br>@Bundle("i18n/mytemplate.txt")<br>@Templated("layouts/template.html")<br><br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Mar 28, 2013 at 7:34 AM, Eric Wittmann <span dir="ltr"><<a href="mailto:eric.wittmann@redhat.com" target="_blank">eric.wittmann@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">+1 to aggregating the bundles. When generating the i18n key, how about<br>
I use the name of the template as the prefix (without the .html)?<br>
<br>
I'm ambivalent towards a convention for the bundle. Sounds like a<br>
reasonable thing to do. :)<br>
<br>
Since we won't have a notion of a module bundle, is i18n simply always<br>
active? Every template will be processed at runtime? This means the<br>
template DOM will get visited but not processed in any way. I can<br>
optimize the case where there are *no* bundles available (check the<br>
aggregate for # of keys - if zero, do not process). That seems fine.<br>
<br>
I like it. It shall be done.<br>
<span class="HOEnZb"><font color="#888888"><br>
-Eric<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
On 03/27/2013 05:05 PM, Christian Sadilek wrote:<br>
> I am starting to believe a slight deviation of the proposal will avoid this problem.<br>
><br>
> - We could introduce a convention for the module's bundle name (e.g. errai-constants or errai-i18n)<br>
><br>
> - The name can be overwritten using the @Bundle annotation on the EntryPoint but that would be optional then<br>
><br>
> - We'd aggregate these module bundles<br>
><br>
> - In the templates it makes sense to prefix the keys anyways which will avoid duplicates (e.g. <a href="http://orderform.customer.name" target="_blank">orderform.customer.name</a> instead of just name)<br>
><br>
> - In case of duplicates we can fail at compile time (when processing a template and finding an actual name clash)<br>
><br>
> - We'd also allow the @Bundle annotation on templates to specify a template-specific bundle. This makes sense for templates having tons of fields. So, one wouldn't end up with a huge bundle file which is hard to maintain. It will also solve the problem where duplicates can't be avoided (e.g. 2 different order forms).<br>
><br>
> So, we'd still have one bundle per module by default but add the flexibility to specify template-specific bundles if needed. We'd aggregate the module bundles of all inherited modules, so the lookup doesn't have to worry about finding the bundle in the corresponding module (or super module). This also allows for the introduction of a super bundles that define values like OK, Cancel etc. in multiple languages.<br>
><br>
> Does that make sense?<br>
><br>
> Cheers,<br>
> Christian<br>
><br>
> On 2013-03-27, at 4:00 PM, Eric Wittmann <<a href="mailto:eric.wittmann@redhat.com">eric.wittmann@redhat.com</a>> wrote:<br>
><br>
>> Ok great, thanks! Of course, we can decide against the One Bundle Per<br>
>> Module approach. But I think it makes sense.<br>
>><br>
>> -Eric<br>
>><br>
>> On 03/27/2013 03:06 PM, Christian Sadilek wrote:<br>
>>> About the other 2 :). Both seem to boil down to the same type of<br>
>>> problem. How do I, for a given MetaClass instance, find out which module<br>
>>> they were defined in.<br>
>>><br>
>>> I don't know the answer. I am currently digging into the GWT internals.<br>
>>><br>
>>> If there's no way to do it we'd need to implement something ourselves.<br>
>>> We already scan all module xml files for source paths (see<br>
>>> RebindUtils::getOuterTranslatablePackages):<br>
>>> <a href="https://github.com/errai/errai/blob/3.0/errai-common/src/main/java/org/jboss/errai/common/metadata" target="_blank">https://github.com/errai/errai/blob/3.0/errai-common/src/main/java/org/jboss/errai/common/metadata</a><br>
>>> <<a href="https://github.com/errai/errai/blob/3.0/errai-common/src/main/java/org/jboss/errai/common/metadata/RebindUtils.java" target="_blank">https://github.com/errai/errai/blob/3.0/errai-common/src/main/java/org/jboss/errai/common/metadata/RebindUtils.java</a>>/RebindUtils.java<br>
>>> <<a href="https://github.com/errai/errai/blob/3.0/errai-common/src/main/java/org/jboss/errai/common/metadata/RebindUtils.java" target="_blank">https://github.com/errai/errai/blob/3.0/errai-common/src/main/java/org/jboss/errai/common/metadata/RebindUtils.java</a>><br>
>>><br>
>>> Combined with the MetaDataScanner that knows where the @Templated class<br>
>>> is, we should be able to come up with a solution.<br>
>>><br>
>>> I am still digging though….<br>
>>><br>
>>> Christian<br>
>>><br>
>>> On 2013-03-27, at 2:12 PM, Eric Wittmann <<a href="mailto:eric.wittmann@redhat.com">eric.wittmann@redhat.com</a><br>
>>> <mailto:<a href="mailto:eric.wittmann@redhat.com">eric.wittmann@redhat.com</a>>> wrote:<br>
>>><br>
>>>> Ah ha. That makes sense. In any case, all @ApplicationScoped beans by<br>
>>>> definition (I assume) would be loaded and available by the time any<br>
>>>> templates were being rendered (regardless of the presence of @LoadAsync).<br>
>>>><br>
>>>> I think this question is put to bed. :) Thanks.<br>
>>>><br>
>>>> Now what about the other 2? :)<br>
>>>><br>
>>>> -Eric<br>
>>>><br>
>>>> On 03/27/2013 02:09 PM, Christian Sadilek wrote:<br>
>>>>> However, only a bean annotated with @LoadAsync can possibly be loaded<br>
>>>>> asynchronously. So, if you just look up your own bean within<br>
>>>>> TemplateUtil and that bean is not annotated with @LoadAsync, you should<br>
>>>>> be fine. The callback will always be invoked synchronously then.<br>
>>>>><br>
>>>>> Christian<br>
>>>>><br>
>>>>> On 2013-03-27, at 1:44 PM, Christian Sadilek <<a href="mailto:csadilek@redhat.com">csadilek@redhat.com</a><br>
>>>>> <mailto:<a href="mailto:csadilek@redhat.com">csadilek@redhat.com</a>><br>
>>>>> <mailto:<a href="mailto:csadilek@redhat.com">csadilek@redhat.com</a>>> wrote:<br>
>>>>><br>
>>>>>> If async IOC is active, the callback will be invoked asynchronously<br>
>>>>>> (at least when it first downloads the source for the corresponding<br>
>>>>>> bean). You can take a look at the new ListWidget implementation which<br>
>>>>>> needs to wait until all callbacks have been executed as well:<br>
>>>>>> <a href="https://github.com/errai/errai/blob/master/errai-ui/src/main/java/org/jboss/errai/ui/client/widget/ListWidget.java" target="_blank">https://github.com/errai/errai/blob/master/errai-ui/src/main/java/org/jboss/errai/ui/client/widget/ListWidget.java</a><br>
>>>>>><br>
>>>>>> Another option is to make use of the InitVotes system:<br>
>>>>>> <a href="https://github.com/errai/errai/blob/master/errai-common/src/main/java/org/jboss/errai/common/client/api/extension/InitVotes.java" target="_blank">https://github.com/errai/errai/blob/master/errai-common/src/main/java/org/jboss/errai/common/client/api/extension/InitVotes.java</a><br>
>>>>>><br>
>>>>>> This is unfortunate but there seems to be no way around it when<br>
>>>>>> supporting async bean management.<br>
>>>>>><br>
>>>>>> Cheers,<br>
>>>>>> Christian<br>
>>>>>><br>
>>>>>> On 2013-03-27, at 1:29 PM, Eric Wittmann <<a href="mailto:eric.wittmann@redhat.com">eric.wittmann@redhat.com</a><br>
>>>>>> <mailto:<a href="mailto:eric.wittmann@redhat.com">eric.wittmann@redhat.com</a>>> wrote:<br>
>>>>>><br>
>>>>>>> Is the bean lookup going to be done synchronously though (regardless of<br>
>>>>>>> the impl)? That's very important in this case. The TemplateUtil is<br>
>>>>>>> going to be invoked several times in sequence (different methods). If<br>
>>>>>>> one of the TemplateUtil methods does something asynchronously that's a<br>
>>>>>>> problem. If not, is there a wait-notify pattern that should be used?<br>
>>>>>>><br>
>>>>>>> -Eric<br>
>>>>>>><br>
>>>>>>> On 03/27/2013 01:24 PM, Christian Sadilek wrote:<br>
>>>>>>>> Actually we have just abstracted that. When you ask for the async<br>
>>>>>>>> bean manager IOC.getAsyncBeanManager() it will work in either case.<br>
>>>>>>>> If synchronous bean management is enabled it will return an adapter<br>
>>>>>>>> where the callback will just immediately be invoked.<br>
>>>>>>>><br>
>>>>>>>> So, just always use the async bean manager API. That code can of<br>
>>>>>>>> course also be generated, if you wanted/needed to.<br>
>>>>>>>><br>
>>>>>>>> On 2013-03-27, at 1:19 PM, Eric Wittmann <<a href="mailto:eric.wittmann@redhat.com">eric.wittmann@redhat.com</a><br>
>>>>>>>> <mailto:<a href="mailto:eric.wittmann@redhat.com">eric.wittmann@redhat.com</a>>> wrote:<br>
>>>>>>>><br>
>>>>>>>>> I think the advent of the async bean manager may have complicated<br>
>>>>>>>>> this<br>
>>>>>>>>> though, right? I don't *think* I can simply get the bean manager and<br>
>>>>>>>>> ask it for the bean (there are a couple of different getters now<br>
>>>>>>>>> - one<br>
>>>>>>>>> to get the sync bean manager and one to get the async bean manager).<br>
>>>>>>>>><br>
>>>>>>>>> One thing I tried that worked but that I don't like: turn the<br>
>>>>>>>>> @ApplicationScoped bean into a singleton and reference it using a<br>
>>>>>>>>> static<br>
>>>>>>>>> method. Ugly but worked. Ideally I think TemplateUtil should<br>
>>>>>>>>> itself be<br>
>>>>>>>>> an injected bean, rather than a class with some static methods.<br>
>>>>>>>>><br>
>>>>>>>>> But that just moves the problem to "how do I reference an<br>
>>>>>>>>> injected bean<br>
>>>>>>>>> in code generated by a Decorator/Extension?" :)<br>
>>>>>>>>><br>
>>>>>>>>> On 03/27/2013 01:13 PM, Lincoln Baxter, III wrote:<br>
>>>>>>>>>> To answer Question #3, this would either need to be coded into the<br>
>>>>>>>>>> call<br>
>>>>>>>>>> to TemplateUtil from the BootstrapperImpl code (done in<br>
>>>>>>>>>> DecoratorTemplated.java) or I believe there is a convenience<br>
>>>>>>>>>> utility to<br>
>>>>>>>>>> get the BeanManager in Errai:<br>
>>>>>>>>>><br>
>>>>>>>>>> CDI.current() or something like that. Mike?<br>
>>>>>>>>>><br>
>>>>>>>>>><br>
>>>>>>>>>> On Tue, Mar 26, 2013 at 12:20 PM, Eric Wittmann<br>
>>>>>>>>>> <<a href="mailto:eric.wittmann@redhat.com">eric.wittmann@redhat.com</a> <mailto:<a href="mailto:eric.wittmann@redhat.com">eric.wittmann@redhat.com</a>><br>
>>>>>>>>>> <mailto:<a href="mailto:eric.wittmann@redhat.com">eric.wittmann@redhat.com</a>>> wrote:<br>
>>>>>>>>>><br>
>>>>>>>>>> Hey guys. I've sketched out a proposed approach (not 100%<br>
>>>>>>>>>> compete but<br>
>>>>>>>>>> ok to start) for i18n. Would appreciate it if you could take a<br>
>>>>>>>>>> look<br>
>>>>>>>>>> at it.<br>
>>>>>>>>>><br>
>>>>>>>>>> At the bottom you will find 3 questions that I would (in<br>
>>>>>>>>>> particular)<br>
>>>>>>>>>> love your thoughts on.<br>
>>>>>>>>>><br>
>>>>>>>>>> <a href="https://docs.google.com/document/d/1BapD4FHMNur0OYdIg-vwXYHWW_2Mhra_Ki2nYAh9qxY/pub" target="_blank">https://docs.google.com/document/d/1BapD4FHMNur0OYdIg-vwXYHWW_2Mhra_Ki2nYAh9qxY/pub</a><br>
>>>>>>>>>><br>
>>>>>>>>>> -Eric<br>
>>>>>>>>>> _______________________________________________<br>
>>>>>>>>>> errai-dev mailing list<br>
>>>>>>>>>> <a href="mailto:errai-dev@lists.jboss.org">errai-dev@lists.jboss.org</a> <mailto:<a href="mailto:errai-dev@lists.jboss.org">errai-dev@lists.jboss.org</a>><br>
>>>>>>>>>> <mailto:<a href="mailto:errai-dev@lists.jboss.org">errai-dev@lists.jboss.org</a>><br>
>>>>>>>>>> <a href="https://lists.jboss.org/mailman/listinfo/errai-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/errai-dev</a><br>
>>>>>>>>>><br>
>>>>>>>>>><br>
>>>>>>>>>><br>
>>>>>>>>>><br>
>>>>>>>>>> --<br>
>>>>>>>>>> Lincoln Baxter, III<br>
>>>>>>>>>> <a href="http://ocpsoft.org" target="_blank">http://ocpsoft.org</a> <<a href="http://ocpsoft.org/" target="_blank">http://ocpsoft.org/</a>><br>
>>>>>>>>>> "Simpler is better."<br>
>>>>>>>>>><br>
>>>>>>>>>><br>
>>>>>>>>>> _______________________________________________<br>
>>>>>>>>>> errai-dev mailing list<br>
>>>>>>>>>> <a href="mailto:errai-dev@lists.jboss.org">errai-dev@lists.jboss.org</a> <mailto:<a href="mailto:errai-dev@lists.jboss.org">errai-dev@lists.jboss.org</a>><br>
>>>>>>>>>> <a href="https://lists.jboss.org/mailman/listinfo/errai-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/errai-dev</a><br>
>>>>>>>>>><br>
>>>>>>>>> _______________________________________________<br>
>>>>>>>>> errai-dev mailing list<br>
>>>>>>>>> <a href="mailto:errai-dev@lists.jboss.org">errai-dev@lists.jboss.org</a> <mailto:<a href="mailto:errai-dev@lists.jboss.org">errai-dev@lists.jboss.org</a>><br>
>>>>>>>>> <a href="https://lists.jboss.org/mailman/listinfo/errai-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/errai-dev</a><br>
>>>>>>>><br>
>>>>>>>><br>
>>>>>>>> _______________________________________________<br>
>>>>>>>> errai-dev mailing list<br>
>>>>>>>> <a href="mailto:errai-dev@lists.jboss.org">errai-dev@lists.jboss.org</a> <mailto:<a href="mailto:errai-dev@lists.jboss.org">errai-dev@lists.jboss.org</a>><br>
>>>>>>>> <a href="https://lists.jboss.org/mailman/listinfo/errai-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/errai-dev</a><br>
>>>>>>>><br>
>>>>>>> _______________________________________________<br>
>>>>>>> errai-dev mailing list<br>
>>>>>>> <a href="mailto:errai-dev@lists.jboss.org">errai-dev@lists.jboss.org</a> <mailto:<a href="mailto:errai-dev@lists.jboss.org">errai-dev@lists.jboss.org</a>><br>
>>>>>>> <a href="https://lists.jboss.org/mailman/listinfo/errai-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/errai-dev</a><br>
>>>>>><br>
>>>>><br>
>>>>><br>
>>>>><br>
>>>>> _______________________________________________<br>
>>>>> errai-dev mailing list<br>
>>>>> <a href="mailto:errai-dev@lists.jboss.org">errai-dev@lists.jboss.org</a> <mailto:<a href="mailto:errai-dev@lists.jboss.org">errai-dev@lists.jboss.org</a>><br>
>>>>> <a href="https://lists.jboss.org/mailman/listinfo/errai-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/errai-dev</a><br>
>>>>><br>
>>>> _______________________________________________<br>
>>>> errai-dev mailing list<br>
>>>> <a href="mailto:errai-dev@lists.jboss.org">errai-dev@lists.jboss.org</a> <mailto:<a href="mailto:errai-dev@lists.jboss.org">errai-dev@lists.jboss.org</a>><br>
>>>> <a href="https://lists.jboss.org/mailman/listinfo/errai-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/errai-dev</a><br>
>>><br>
>>><br>
>>><br>
>>> _______________________________________________<br>
>>> errai-dev mailing list<br>
>>> <a href="mailto:errai-dev@lists.jboss.org">errai-dev@lists.jboss.org</a><br>
>>> <a href="https://lists.jboss.org/mailman/listinfo/errai-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/errai-dev</a><br>
>>><br>
>> _______________________________________________<br>
>> errai-dev mailing list<br>
>> <a href="mailto:errai-dev@lists.jboss.org">errai-dev@lists.jboss.org</a><br>
>> <a href="https://lists.jboss.org/mailman/listinfo/errai-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/errai-dev</a><br>
><br>
><br>
> _______________________________________________<br>
> errai-dev mailing list<br>
> <a href="mailto:errai-dev@lists.jboss.org">errai-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/errai-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/errai-dev</a><br>
><br>
_______________________________________________<br>
errai-dev mailing list<br>
<a href="mailto:errai-dev@lists.jboss.org">errai-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/errai-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/errai-dev</a><br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br>Lincoln Baxter, III<br><a href="http://ocpsoft.org" target="_blank">http://ocpsoft.org</a><br>"Simpler is better."
</div>