[esb-issues] [JBoss JIRA] Commented: (JBESB-3378) AbstractHttpMethodFactory should extract retry handler parameter in setConfiguration method

[Kevin Conner (JIRA)]

    [ https://jira.jboss.org/browse/JBESB-3378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12542741#action_12542741 ] 

Kevin Conner commented on JBESB-3378:
-------------------------------------

Reading further into this would suggest that the ability to configure the retry handler was never intended in the first place.  The code in AbstractHttpMethodFactory just wraps the class created in DefaultHttpParamsFactory.

> AbstractHttpMethodFactory should extract retry handler parameter in setConfiguration method
> -------------------------------------------------------------------------------------------
>
>                 Key: JBESB-3378
>                 URL: https://jira.jboss.org/browse/JBESB-3378
>             Project: JBoss ESB
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: Configuration, Rosetta, Transports
>    Affects Versions: 4.8
>            Reporter: David Ward
>            Assignee: David Ward
>             Fix For: 4.9 CP1
>
>
> If you set your config like this:
> <action ... class="org.jboss.soa.esb.actions.soap.proxy.SOAPProxy">
>     ...
>     <property name="http-client-properties">
>         <http-client-property name="http.method.retry-handler" value="com.foobar.MyRetryHandler"/>
>     </property> 
> or like this:
> <action ... class="org.jboss.soa.esb.actions.soap.proxy.SOAPProxy">
>     ...
>     <property name="file" value="http-client.properties"/>
> http-client.properties:
> http.method.retry-handler=com.foobar.MyRetryHandler
> , your custom retry handler is not picked up.  This is NOT a bug in SOAPProxy.
> The bug is in both POSTHttpMethodFactory and GETHttpMethodFactory, where in the setConfiguration(ConfigTree):void method, the http-client-properties that are available in the passed-in ConfigTree are not set into the HttpMethod's HttpMethodParams.
> What should happen is that ANY property that starts with "http.method." should be set into the HttpMethodParams.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira