[exo-jcr-commits] exo-jcr SVN: r1206 - in jcr/branches/1.12.0-OPT/exo.jcr.component.core/src/main/java/org/exoplatform/services/jcr/impl/dataflow: session and 1 other directory.

do-not-reply at jboss.org do-not-reply at jboss.org
Mon Dec 28 06:04:12 EST 2009


Author: tolusha
Date: 2009-12-28 06:04:11 -0500 (Mon, 28 Dec 2009)
New Revision: 1206

Modified:
   jcr/branches/1.12.0-OPT/exo.jcr.component.core/src/main/java/org/exoplatform/services/jcr/impl/dataflow/persistent/LocalWorkspaceDataManagerStub.java
   jcr/branches/1.12.0-OPT/exo.jcr.component.core/src/main/java/org/exoplatform/services/jcr/impl/dataflow/session/LocalWorkspaceStorageDataManagerProxy.java
Log:
EXOJCR-273: return unmodifiableList lists from persisted layer

Modified: jcr/branches/1.12.0-OPT/exo.jcr.component.core/src/main/java/org/exoplatform/services/jcr/impl/dataflow/persistent/LocalWorkspaceDataManagerStub.java
===================================================================
--- jcr/branches/1.12.0-OPT/exo.jcr.component.core/src/main/java/org/exoplatform/services/jcr/impl/dataflow/persistent/LocalWorkspaceDataManagerStub.java	2009-12-28 09:25:48 UTC (rev 1205)
+++ jcr/branches/1.12.0-OPT/exo.jcr.component.core/src/main/java/org/exoplatform/services/jcr/impl/dataflow/persistent/LocalWorkspaceDataManagerStub.java	2009-12-28 11:04:11 UTC (rev 1206)
@@ -19,6 +19,7 @@
 package org.exoplatform.services.jcr.impl.dataflow.persistent;
 
 import org.exoplatform.services.jcr.datamodel.NodeData;
+import org.exoplatform.services.jcr.datamodel.PropertyData;
 import org.exoplatform.services.log.ExoLogger;
 import org.exoplatform.services.log.Log;
 
@@ -52,5 +53,32 @@
    {
       return Collections.unmodifiableList(super.getChildNodesData(nodeData));
    }
-   
+
+   /**
+    * {@inheritDoc}
+    */
+   @Override
+   public List<PropertyData> getChildPropertiesData(NodeData parent) throws RepositoryException
+   {
+      return Collections.unmodifiableList(super.getChildPropertiesData(parent));
+   }
+
+   /**
+    * {@inheritDoc}
+    */
+   @Override
+   public List<PropertyData> listChildPropertiesData(final NodeData parent) throws RepositoryException
+   {
+      return Collections.unmodifiableList(super.listChildPropertiesData(parent));
+   }
+
+   /**
+    * {@inheritDoc}
+    */
+   @Override
+   public List<PropertyData> getReferencesData(String identifier, boolean skipVersionStorage)
+      throws RepositoryException
+   {
+      return Collections.unmodifiableList(super.getReferencesData(identifier, skipVersionStorage));
+   }
 }

Modified: jcr/branches/1.12.0-OPT/exo.jcr.component.core/src/main/java/org/exoplatform/services/jcr/impl/dataflow/session/LocalWorkspaceStorageDataManagerProxy.java
===================================================================
--- jcr/branches/1.12.0-OPT/exo.jcr.component.core/src/main/java/org/exoplatform/services/jcr/impl/dataflow/session/LocalWorkspaceStorageDataManagerProxy.java	2009-12-28 09:25:48 UTC (rev 1205)
+++ jcr/branches/1.12.0-OPT/exo.jcr.component.core/src/main/java/org/exoplatform/services/jcr/impl/dataflow/session/LocalWorkspaceStorageDataManagerProxy.java	2009-12-28 11:04:11 UTC (rev 1206)
@@ -222,7 +222,7 @@
    private List<NodeData> copyNodes(final List<NodeData> childNodes) throws RepositoryException
    {
       final List<NodeData> copyOfChildsNodes = new LinkedList<NodeData>();
-      synchronized (childNodes)
+      synchronized (childNodes) // TODO EXOJCR-273
       {
          for (NodeData nodeData : childNodes)
          {
@@ -235,7 +235,7 @@
    private List<PropertyData> copyProperties(final List<PropertyData> traverseProperties) throws RepositoryException
    {
       final List<PropertyData> copyOfChildsProperties = new LinkedList<PropertyData>();
-      synchronized (traverseProperties)
+      synchronized (traverseProperties) // TODO EXOJCR-273
       {
          for (PropertyData nodeProperty : traverseProperties)
          {
@@ -249,7 +249,7 @@
       throws RepositoryException
    {
       final List<PropertyData> copyOfChildsProperties = new LinkedList<PropertyData>();
-      synchronized (traverseProperties)
+      synchronized (traverseProperties) // TODO EXOJCR-273
       {
          for (PropertyData nodeProperty : traverseProperties)
          {



More information about the exo-jcr-commits mailing list