[exo-jcr-commits] exo-jcr SVN: r4039 - in jcr/trunk/exo.jcr.component.core/src/main/java/org/exoplatform/services/jcr: impl/core/query/ispn and 2 other directories.

do-not-reply at jboss.org do-not-reply at jboss.org
Wed Mar 2 03:47:58 EST 2011


Author: nzamosenchuk
Date: 2011-03-02 03:47:58 -0500 (Wed, 02 Mar 2011)
New Revision: 4039

Modified:
   jcr/trunk/exo.jcr.component.core/src/main/java/org/exoplatform/services/jcr/impl/core/lock/infinispan/ISPNCacheableLockManagerImpl.java
   jcr/trunk/exo.jcr.component.core/src/main/java/org/exoplatform/services/jcr/impl/core/query/ispn/ISPNIndexChangesFilter.java
   jcr/trunk/exo.jcr.component.core/src/main/java/org/exoplatform/services/jcr/impl/core/query/ispn/IndexInfosKey.java
   jcr/trunk/exo.jcr.component.core/src/main/java/org/exoplatform/services/jcr/impl/core/query/ispn/IndexUpdateKey.java
   jcr/trunk/exo.jcr.component.core/src/main/java/org/exoplatform/services/jcr/impl/core/query/ispn/IndexerCacheStore.java
   jcr/trunk/exo.jcr.component.core/src/main/java/org/exoplatform/services/jcr/impl/core/query/ispn/LocalIndexChangesFilter.java
   jcr/trunk/exo.jcr.component.core/src/main/java/org/exoplatform/services/jcr/impl/dataflow/persistent/infinispan/ISPNCacheWorkspaceStorageCache.java
   jcr/trunk/exo.jcr.component.core/src/main/java/org/exoplatform/services/jcr/infinispan/ISPNCacheFactory.java
Log:
EXOJCR-832 : fixing CacheStore listener, adding static string to IndexInfosKey and IndexUpdateKey. 
EXOJCR-833 : fixing cache names (avoid dashes).

Modified: jcr/trunk/exo.jcr.component.core/src/main/java/org/exoplatform/services/jcr/impl/core/lock/infinispan/ISPNCacheableLockManagerImpl.java
===================================================================
--- jcr/trunk/exo.jcr.component.core/src/main/java/org/exoplatform/services/jcr/impl/core/lock/infinispan/ISPNCacheableLockManagerImpl.java	2011-03-02 08:08:02 UTC (rev 4038)
+++ jcr/trunk/exo.jcr.component.core/src/main/java/org/exoplatform/services/jcr/impl/core/lock/infinispan/ISPNCacheableLockManagerImpl.java	2011-03-02 08:47:58 UTC (rev 4039)
@@ -87,22 +87,22 @@
    private Cache<Serializable, Object> cache;
 
    public ISPNCacheableLockManagerImpl(WorkspacePersistentDataManager dataManager, WorkspaceEntry config,
-      InitialContextInitializer context, TransactionService transactionService, ConfigurationManager cfm, LockRemoverHolder lockRemoverHolder)
-      throws RepositoryConfigurationException, RepositoryException
+      InitialContextInitializer context, TransactionService transactionService, ConfigurationManager cfm,
+      LockRemoverHolder lockRemoverHolder) throws RepositoryConfigurationException, RepositoryException
    {
       this(dataManager, config, context, transactionService.getTransactionManager(), cfm, lockRemoverHolder);
    }
 
    public ISPNCacheableLockManagerImpl(WorkspacePersistentDataManager dataManager, WorkspaceEntry config,
-      InitialContextInitializer context, ConfigurationManager cfm, LockRemoverHolder lockRemoverHolder) throws RepositoryConfigurationException,
-      RepositoryException
+      InitialContextInitializer context, ConfigurationManager cfm, LockRemoverHolder lockRemoverHolder)
+      throws RepositoryConfigurationException, RepositoryException
    {
       this(dataManager, config, context, (TransactionManager)null, cfm, lockRemoverHolder);
    }
 
    public ISPNCacheableLockManagerImpl(WorkspacePersistentDataManager dataManager, WorkspaceEntry config,
-      InitialContextInitializer context, TransactionManager transactionManager, ConfigurationManager cfm, LockRemoverHolder lockRemoverHolder)
-      throws RepositoryConfigurationException, RepositoryException
+      InitialContextInitializer context, TransactionManager transactionManager, ConfigurationManager cfm,
+      LockRemoverHolder lockRemoverHolder) throws RepositoryConfigurationException, RepositoryException
    {
       super(dataManager, config, transactionManager, lockRemoverHolder);
 
@@ -115,7 +115,7 @@
          // configure cache loader parameters with correct DB data-types
          configureJDBCCacheLoader(config.getLockManager());
 
-         cache = factory.createCache("Lock-" + config.getUniqueName(), config.getLockManager());
+         cache = factory.createCache("Lock_" + config.getUniqueName(), config.getLockManager());
 
          // Context recall is a workaround of JDBCCacheLoader starting. 
          context.recall();

Modified: jcr/trunk/exo.jcr.component.core/src/main/java/org/exoplatform/services/jcr/impl/core/query/ispn/ISPNIndexChangesFilter.java
===================================================================
--- jcr/trunk/exo.jcr.component.core/src/main/java/org/exoplatform/services/jcr/impl/core/query/ispn/ISPNIndexChangesFilter.java	2011-03-02 08:08:02 UTC (rev 4038)
+++ jcr/trunk/exo.jcr.component.core/src/main/java/org/exoplatform/services/jcr/impl/core/query/ispn/ISPNIndexChangesFilter.java	2011-03-02 08:47:58 UTC (rev 4039)
@@ -85,7 +85,7 @@
 
       ISPNCacheFactory<Serializable, Object> factory = new ISPNCacheFactory<Serializable, Object>(cfm);
       config.putParameterValue(PARAM_INFINISPAN_CACHESTORE_CLASS, IndexerCacheStore.class.getName());
-      this.cache = factory.createCache("Indexer-" + searchManager.getWsId(), config);
+      this.cache = factory.createCache("Indexer_" + searchManager.getWsId(), config);
 
       CacheLoaderManager cacheLoaderManager =
          cache.getAdvancedCache().getComponentRegistry().getComponent(CacheLoaderManager.class);

Modified: jcr/trunk/exo.jcr.component.core/src/main/java/org/exoplatform/services/jcr/impl/core/query/ispn/IndexInfosKey.java
===================================================================
--- jcr/trunk/exo.jcr.component.core/src/main/java/org/exoplatform/services/jcr/impl/core/query/ispn/IndexInfosKey.java	2011-03-02 08:08:02 UTC (rev 4038)
+++ jcr/trunk/exo.jcr.component.core/src/main/java/org/exoplatform/services/jcr/impl/core/query/ispn/IndexInfosKey.java	2011-03-02 08:47:58 UTC (rev 4039)
@@ -33,7 +33,7 @@
 
    IndexInfosKey(String id)
    {
-      super(id);
+      super("IndexInfos" + id);
    }
 
    /**

Modified: jcr/trunk/exo.jcr.component.core/src/main/java/org/exoplatform/services/jcr/impl/core/query/ispn/IndexUpdateKey.java
===================================================================
--- jcr/trunk/exo.jcr.component.core/src/main/java/org/exoplatform/services/jcr/impl/core/query/ispn/IndexUpdateKey.java	2011-03-02 08:08:02 UTC (rev 4038)
+++ jcr/trunk/exo.jcr.component.core/src/main/java/org/exoplatform/services/jcr/impl/core/query/ispn/IndexUpdateKey.java	2011-03-02 08:47:58 UTC (rev 4039)
@@ -33,7 +33,7 @@
 
    IndexUpdateKey(String id)
    {
-      super(id);
+      super("UpdateMonitor" + id);
    }
 
    /**

Modified: jcr/trunk/exo.jcr.component.core/src/main/java/org/exoplatform/services/jcr/impl/core/query/ispn/IndexerCacheStore.java
===================================================================
--- jcr/trunk/exo.jcr.component.core/src/main/java/org/exoplatform/services/jcr/impl/core/query/ispn/IndexerCacheStore.java	2011-03-02 08:08:02 UTC (rev 4038)
+++ jcr/trunk/exo.jcr.component.core/src/main/java/org/exoplatform/services/jcr/impl/core/query/ispn/IndexerCacheStore.java	2011-03-02 08:47:58 UTC (rev 4039)
@@ -79,7 +79,7 @@
       super.init(config, cache, m);
       this.cacheManager = cache == null ? null : (EmbeddedCacheManager)cache.getCacheManager();
       listener = new CacheListener();
-      cache.addListener(listener);
+      cacheManager.addListener(listener);
    }
 
    /**

Modified: jcr/trunk/exo.jcr.component.core/src/main/java/org/exoplatform/services/jcr/impl/core/query/ispn/LocalIndexChangesFilter.java
===================================================================
--- jcr/trunk/exo.jcr.component.core/src/main/java/org/exoplatform/services/jcr/impl/core/query/ispn/LocalIndexChangesFilter.java	2011-03-02 08:08:02 UTC (rev 4038)
+++ jcr/trunk/exo.jcr.component.core/src/main/java/org/exoplatform/services/jcr/impl/core/query/ispn/LocalIndexChangesFilter.java	2011-03-02 08:47:58 UTC (rev 4039)
@@ -81,7 +81,7 @@
       this.wsId = searchManager.getWsId().hashCode();
       ISPNCacheFactory<Serializable, Object> factory = new ISPNCacheFactory<Serializable, Object>(cfm);
       config.putParameterValue(PARAM_INFINISPAN_CACHESTORE_CLASS, LocalIndexCacheStore.class.getName());
-      this.cache = factory.createCache("Indexer-" + searchManager.getWsId(), config);
+      this.cache = factory.createCache("Indexer_" + searchManager.getWsId(), config);
 
       CacheLoaderManager cacheLoaderManager =
          cache.getAdvancedCache().getComponentRegistry().getComponent(CacheLoaderManager.class);

Modified: jcr/trunk/exo.jcr.component.core/src/main/java/org/exoplatform/services/jcr/impl/dataflow/persistent/infinispan/ISPNCacheWorkspaceStorageCache.java
===================================================================
--- jcr/trunk/exo.jcr.component.core/src/main/java/org/exoplatform/services/jcr/impl/dataflow/persistent/infinispan/ISPNCacheWorkspaceStorageCache.java	2011-03-02 08:08:02 UTC (rev 4038)
+++ jcr/trunk/exo.jcr.component.core/src/main/java/org/exoplatform/services/jcr/impl/dataflow/persistent/infinispan/ISPNCacheWorkspaceStorageCache.java	2011-03-02 08:47:58 UTC (rev 4039)
@@ -223,7 +223,7 @@
 
       // create parent Infinispan instance
       CacheEntry cacheEntry = wsConfig.getCache();
-      Cache<Serializable, Object> parentCache = factory.createCache("Data-" + wsConfig.getUniqueName(), cacheEntry);
+      Cache<Serializable, Object> parentCache = factory.createCache("Data_" + wsConfig.getUniqueName(), cacheEntry);
 
       Boolean allowLocalChanges = null;
       try

Modified: jcr/trunk/exo.jcr.component.core/src/main/java/org/exoplatform/services/jcr/infinispan/ISPNCacheFactory.java
===================================================================
--- jcr/trunk/exo.jcr.component.core/src/main/java/org/exoplatform/services/jcr/infinispan/ISPNCacheFactory.java	2011-03-02 08:08:02 UTC (rev 4038)
+++ jcr/trunk/exo.jcr.component.core/src/main/java/org/exoplatform/services/jcr/infinispan/ISPNCacheFactory.java	2011-03-02 08:47:58 UTC (rev 4039)
@@ -95,7 +95,8 @@
       // get Infinispan configuration file path
       final String configurationPath = parameterEntry.getParameterValue(INFINISPAN_CONFIG);
       log.info("Infinispan Cache configuration used: " + configurationPath);
-
+      // avoid dashes in cache name. Some SQL servers doesn't allow dashes in table names
+      final String regionIdEscaped = regionId.replace("-", "_");
       // prepare configuration
       final InputStream configStream;
       try
@@ -118,7 +119,7 @@
          {
             public EmbeddedCacheManager run() throws IOException
             {
-               return getUniqueInstance(regionId, new DefaultCacheManager(configStream));
+               return getUniqueInstance(regionIdEscaped, new DefaultCacheManager(configStream));
             }
          });
 
@@ -132,7 +133,7 @@
       {
          public Cache<K, V> run()
          {
-            return manager.getCache(regionId);
+            return manager.getCache(regionIdEscaped);
          }
       };
       Cache<K, V> cache = AccessController.doPrivileged(action);
@@ -155,7 +156,7 @@
       GlobalConfiguration gc = manager.getGlobalConfiguration();
       ExoContainer container = ExoContainerContext.getCurrentContainer();
       // Ensure that the cluster name won't be used between 2 ExoContainers
-      gc.setClusterName(gc.getClusterName() + "-" + container.getContext().getName());
+      gc.setClusterName(gc.getClusterName() + "_" + container.getContext().getName());
       Configuration conf = manager.getDefaultConfiguration();
       if (CACHE_MANAGERS.containsKey(gc))
       {



More information about the exo-jcr-commits mailing list