[exo-jcr-commits] exo-jcr SVN: r5163 - in jcr/branches/1.12.x: patch/1.12.11-GA/JCR-1667 and 1 other directory.

[do-not-reply at jboss.org]

Author: trang_vu
Date: 2011-11-04 07:22:25 -0400 (Fri, 04 Nov 2011)
New Revision: 5163

Added:
   jcr/branches/1.12.x/patch/1.12.11-GA/JCR-1667/readme.txt
Modified:
   jcr/branches/1.12.x/exo.jcr.component.ext/src/main/java/org/exoplatform/services/jcr/ext/hierarchy/impl/NodeHierarchyCreatorImpl.java
Log:
JCR-1667: Invalid session.logout() calls in NodeHierarchyCreatorImpl

Fix description

* Remove session.logout method calls in NodeHierarchyCreatorImpl to have proper logic.


Modified: jcr/branches/1.12.x/exo.jcr.component.ext/src/main/java/org/exoplatform/services/jcr/ext/hierarchy/impl/NodeHierarchyCreatorImpl.java
===================================================================
--- jcr/branches/1.12.x/exo.jcr.component.ext/src/main/java/org/exoplatform/services/jcr/ext/hierarchy/impl/NodeHierarchyCreatorImpl.java	2011-11-04 10:58:28 UTC (rev 5162)
+++ jcr/branches/1.12.x/exo.jcr.component.ext/src/main/java/org/exoplatform/services/jcr/ext/hierarchy/impl/NodeHierarchyCreatorImpl.java	2011-11-04 11:22:25 UTC (rev 5163)
@@ -241,7 +241,6 @@
          getSession(sessionProvider, currentRepo, currentRepo.getConfiguration().getDefaultWorkspaceName());
       Node rootNode = session.getRootNode();
       String publicApplication = getJcrPath(PUBLIC_APPLICATION);
-      session.logout();
       return rootNode.getNode(publicApplication.substring(1, publicApplication.length()));
    }
 
@@ -262,10 +261,6 @@
          userNode = usersNode.addNode(userName);
          usersNode.save();
       }
-      finally
-      {
-         session.logout();
-      }
       return userNode;
    }
 

Added: jcr/branches/1.12.x/patch/1.12.11-GA/JCR-1667/readme.txt
===================================================================
--- jcr/branches/1.12.x/patch/1.12.11-GA/JCR-1667/readme.txt	                        (rev 0)
+++ jcr/branches/1.12.x/patch/1.12.11-GA/JCR-1667/readme.txt	2011-11-04 11:22:25 UTC (rev 5163)
@@ -0,0 +1,69 @@
+Summary
+
+    * Status: Invalid session.logout() calls in NodeHierarchyCreatorImpl
+    * CCP Issue: CCP-1118, Product Jira Issue: JCR-1667.
+    * Complexity: low
+
+The Proposal
+Problem description
+
+What is the problem to fix?
+In NodeHierarchyCreatorImpl some methods call session.logout before returning the JCR node which is totally invalid.
+Fix description
+
+How is the problem fixed?
+
+    * session.logout method calls in NodeHierarchyCreatorImpl removed to have proper logic.
+
+Patch file: JCR-1667.patch
+
+Tests to perform
+
+Reproduction test
+
+    * Functional tests
+
+Tests performed at DevLevel
+
+    * Functional tests
+
+Tests performed at QA/Support Level
+
+    *  
+
+Documentation changes
+
+Documentation changes:
+
+    * None
+
+Configuration changes
+
+Configuration changes:
+
+    * None
+
+Will previous configuration continue to work?
+
+    * Yes
+
+Risks and impacts
+
+Can this bug fix have any side effects on current client projects?
+
+    * No
+
+Is there a performance risk/cost?
+
+    * No
+
+Validation (PM/Support/QA)
+
+PM Comment
+* Patch validated
+
+Support Comment
+* Patch validated
+
+QA Feedbacks
+*