[exo-jcr-commits] exo-jcr SVN: r5522 - in kernel/branches/2.4.x: exo.kernel.component.cache/src/main/java/org/exoplatform/services/cache/concurrent and 9 other directories.
do-not-reply at jboss.org
do-not-reply at jboss.org
Thu Jan 26 08:19:41 EST 2012
Author: andrew.plotnikov
Date: 2012-01-26 08:19:39 -0500 (Thu, 26 Jan 2012)
New Revision: 5522
Modified:
kernel/branches/2.4.x/exo.kernel.commons/src/main/java/org/exoplatform/services/log/impl/AbstractExoLogFactory.java
kernel/branches/2.4.x/exo.kernel.commons/src/main/java/org/exoplatform/services/log/impl/LocationAwareSLF4JExoLog.java
kernel/branches/2.4.x/exo.kernel.commons/src/main/java/org/exoplatform/services/log/impl/SLF4JExoLog.java
kernel/branches/2.4.x/exo.kernel.component.cache/src/main/java/org/exoplatform/services/cache/concurrent/ConcurrentFIFOExoCache.java
kernel/branches/2.4.x/exo.kernel.component.cache/src/main/java/org/exoplatform/services/cache/invalidation/InvalidationExoCache.java
kernel/branches/2.4.x/exo.kernel.component.cache/src/test/java/org/exoplatform/services/cache/test/TestConcurrentCache.java
kernel/branches/2.4.x/exo.kernel.component.ext.cache.impl.infinispan.v5/src/main/java/org/exoplatform/services/cache/impl/infinispan/AbstractExoCache.java
kernel/branches/2.4.x/exo.kernel.component.ext.cache.impl.infinispan.v5/src/main/java/org/exoplatform/services/cache/impl/infinispan/distributed/DistributedExoCache.java
kernel/branches/2.4.x/exo.kernel.component.ext.cache.impl.jboss.v3/src/main/java/org/exoplatform/services/cache/impl/jboss/AbstractExoCache.java
kernel/branches/2.4.x/exo.kernel.container/src/main/java/org/exoplatform/container/component/RequestLifeCycle.java
kernel/branches/2.4.x/exo.kernel.container/src/main/java/org/exoplatform/container/management/ManagementContextImpl.java
kernel/branches/2.4.x/exo.kernel.container/src/main/java/org/exoplatform/container/management/MetaDataBuilder.java
kernel/branches/2.4.x/exo.kernel.container/src/main/java/org/exoplatform/container/monitor/jvm/J2EEServerInfo.java
kernel/branches/2.4.x/exo.kernel.container/src/main/java/org/exoplatform/management/spi/ManagedMethodMetaData.java
kernel/branches/2.4.x/exo.kernel.container/src/main/java/org/exoplatform/management/spi/ManagedTypeMetaData.java
Log:
EXOJCR-1725: Fixed the Blocker/Critical violations and the easiest Major ones raised by eXo Quality Level 1.2
Modified: kernel/branches/2.4.x/exo.kernel.commons/src/main/java/org/exoplatform/services/log/impl/AbstractExoLogFactory.java
===================================================================
--- kernel/branches/2.4.x/exo.kernel.commons/src/main/java/org/exoplatform/services/log/impl/AbstractExoLogFactory.java 2012-01-26 10:23:07 UTC (rev 5521)
+++ kernel/branches/2.4.x/exo.kernel.commons/src/main/java/org/exoplatform/services/log/impl/AbstractExoLogFactory.java 2012-01-26 13:19:39 UTC (rev 5522)
@@ -52,7 +52,7 @@
{
if (name == null)
{
- throw new IllegalArgumentException();
+ throw new IllegalArgumentException("The logger name cannot be null");
}
Log exoLogger = loggers.get(name);
if (exoLogger == null)
@@ -74,7 +74,7 @@
{
if (clazz == null)
{
- throw new IllegalArgumentException();
+ throw new IllegalArgumentException("The logger class cannot be null");
}
return getExoLogger(clazz.getName());
}
Modified: kernel/branches/2.4.x/exo.kernel.commons/src/main/java/org/exoplatform/services/log/impl/LocationAwareSLF4JExoLog.java
===================================================================
--- kernel/branches/2.4.x/exo.kernel.commons/src/main/java/org/exoplatform/services/log/impl/LocationAwareSLF4JExoLog.java 2012-01-26 10:23:07 UTC (rev 5521)
+++ kernel/branches/2.4.x/exo.kernel.commons/src/main/java/org/exoplatform/services/log/impl/LocationAwareSLF4JExoLog.java 2012-01-26 13:19:39 UTC (rev 5522)
@@ -46,7 +46,7 @@
{
if (logger == null)
{
- throw new IllegalArgumentException();
+ throw new IllegalArgumentException("The logger cannot be null");
}
this.logger = new DynamicLocationAwareLogger(logger);
}
Modified: kernel/branches/2.4.x/exo.kernel.commons/src/main/java/org/exoplatform/services/log/impl/SLF4JExoLog.java
===================================================================
--- kernel/branches/2.4.x/exo.kernel.commons/src/main/java/org/exoplatform/services/log/impl/SLF4JExoLog.java 2012-01-26 10:23:07 UTC (rev 5521)
+++ kernel/branches/2.4.x/exo.kernel.commons/src/main/java/org/exoplatform/services/log/impl/SLF4JExoLog.java 2012-01-26 13:19:39 UTC (rev 5522)
@@ -43,7 +43,7 @@
{
if (logger == null)
{
- throw new IllegalArgumentException();
+ throw new IllegalArgumentException("The logger cannot be null");
}
this.logger = logger;
Modified: kernel/branches/2.4.x/exo.kernel.component.cache/src/main/java/org/exoplatform/services/cache/concurrent/ConcurrentFIFOExoCache.java
===================================================================
--- kernel/branches/2.4.x/exo.kernel.component.cache/src/main/java/org/exoplatform/services/cache/concurrent/ConcurrentFIFOExoCache.java 2012-01-26 10:23:07 UTC (rev 5521)
+++ kernel/branches/2.4.x/exo.kernel.component.cache/src/main/java/org/exoplatform/services/cache/concurrent/ConcurrentFIFOExoCache.java 2012-01-26 13:19:39 UTC (rev 5522)
@@ -281,7 +281,7 @@
{
if (listener == null)
{
- throw new IllegalArgumentException();
+ throw new IllegalArgumentException("The listener cannot be null");
}
listeners.add(new ListenerContext<K, V>(listener, this));
}
Modified: kernel/branches/2.4.x/exo.kernel.component.cache/src/main/java/org/exoplatform/services/cache/invalidation/InvalidationExoCache.java
===================================================================
--- kernel/branches/2.4.x/exo.kernel.component.cache/src/main/java/org/exoplatform/services/cache/invalidation/InvalidationExoCache.java 2012-01-26 10:23:07 UTC (rev 5521)
+++ kernel/branches/2.4.x/exo.kernel.component.cache/src/main/java/org/exoplatform/services/cache/invalidation/InvalidationExoCache.java 2012-01-26 13:19:39 UTC (rev 5522)
@@ -312,7 +312,7 @@
{
if (listener == null)
{
- throw new IllegalArgumentException();
+ throw new IllegalArgumentException("The listener cannot be null");
}
listeners.add(listener);
}
Modified: kernel/branches/2.4.x/exo.kernel.component.cache/src/test/java/org/exoplatform/services/cache/test/TestConcurrentCache.java
===================================================================
--- kernel/branches/2.4.x/exo.kernel.component.cache/src/test/java/org/exoplatform/services/cache/test/TestConcurrentCache.java 2012-01-26 10:23:07 UTC (rev 5521)
+++ kernel/branches/2.4.x/exo.kernel.component.cache/src/test/java/org/exoplatform/services/cache/test/TestConcurrentCache.java 2012-01-26 13:19:39 UTC (rev 5522)
@@ -55,7 +55,7 @@
try
{
cache.put(null, new Object());
- fail();
+ fail("Was expecting an IllegalArgumentException");
}
catch (IllegalArgumentException ignore)
{
@@ -65,7 +65,7 @@
try
{
cache.remove(null);
- fail();
+ fail("Was expecting an IllegalArgumentException");
}
catch (IllegalArgumentException ignore)
{
@@ -75,7 +75,7 @@
try
{
cache.putMap(null);
- fail();
+ fail("Was expecting an IllegalArgumentException");
}
catch (IllegalArgumentException ignore)
{
@@ -88,7 +88,7 @@
tmp.put("a", "a");
tmp.put(null, "a");
cache.putMap(tmp);
- fail();
+ fail("Was expecting an IllegalArgumentException");
}
catch (IllegalArgumentException ignore)
{
Modified: kernel/branches/2.4.x/exo.kernel.component.ext.cache.impl.infinispan.v5/src/main/java/org/exoplatform/services/cache/impl/infinispan/AbstractExoCache.java
===================================================================
--- kernel/branches/2.4.x/exo.kernel.component.ext.cache.impl.infinispan.v5/src/main/java/org/exoplatform/services/cache/impl/infinispan/AbstractExoCache.java 2012-01-26 10:23:07 UTC (rev 5521)
+++ kernel/branches/2.4.x/exo.kernel.component.ext.cache.impl.infinispan.v5/src/main/java/org/exoplatform/services/cache/impl/infinispan/AbstractExoCache.java 2012-01-26 13:19:39 UTC (rev 5522)
@@ -101,7 +101,7 @@
{
if (listener == null)
{
- throw new IllegalArgumentException();
+ throw new IllegalArgumentException("The listener cannot be null");
}
listeners.add(new ListenerContext<K, V>(listener, this));
}
Modified: kernel/branches/2.4.x/exo.kernel.component.ext.cache.impl.infinispan.v5/src/main/java/org/exoplatform/services/cache/impl/infinispan/distributed/DistributedExoCache.java
===================================================================
--- kernel/branches/2.4.x/exo.kernel.component.ext.cache.impl.infinispan.v5/src/main/java/org/exoplatform/services/cache/impl/infinispan/distributed/DistributedExoCache.java 2012-01-26 10:23:07 UTC (rev 5521)
+++ kernel/branches/2.4.x/exo.kernel.component.ext.cache.impl.infinispan.v5/src/main/java/org/exoplatform/services/cache/impl/infinispan/distributed/DistributedExoCache.java 2012-01-26 13:19:39 UTC (rev 5522)
@@ -132,7 +132,7 @@
{
if (listener == null)
{
- throw new IllegalArgumentException();
+ throw new IllegalArgumentException("The listener cannot be null");
}
List<ListenerContext> lListeners = getListeners(fullName);
if (lListeners == null)
Modified: kernel/branches/2.4.x/exo.kernel.component.ext.cache.impl.jboss.v3/src/main/java/org/exoplatform/services/cache/impl/jboss/AbstractExoCache.java
===================================================================
--- kernel/branches/2.4.x/exo.kernel.component.ext.cache.impl.jboss.v3/src/main/java/org/exoplatform/services/cache/impl/jboss/AbstractExoCache.java 2012-01-26 10:23:07 UTC (rev 5521)
+++ kernel/branches/2.4.x/exo.kernel.component.ext.cache.impl.jboss.v3/src/main/java/org/exoplatform/services/cache/impl/jboss/AbstractExoCache.java 2012-01-26 13:19:39 UTC (rev 5522)
@@ -107,7 +107,7 @@
{
if (listener == null)
{
- throw new IllegalArgumentException();
+ throw new IllegalArgumentException("The listener cannot be null");
}
listeners.add(new ListenerContext<K, V>(listener, this));
}
Modified: kernel/branches/2.4.x/exo.kernel.container/src/main/java/org/exoplatform/container/component/RequestLifeCycle.java
===================================================================
--- kernel/branches/2.4.x/exo.kernel.container/src/main/java/org/exoplatform/container/component/RequestLifeCycle.java 2012-01-26 10:23:07 UTC (rev 5521)
+++ kernel/branches/2.4.x/exo.kernel.container/src/main/java/org/exoplatform/container/component/RequestLifeCycle.java 2012-01-26 13:19:39 UTC (rev 5522)
@@ -96,7 +96,7 @@
{
if (container == null)
{
- throw new IllegalArgumentException();
+ throw new IllegalArgumentException("The container cannot be null");
}
RequestLifeCycleStack lf = current.get();
if (lf == null)
@@ -118,7 +118,7 @@
{
if (lifeCycle == null)
{
- throw new IllegalArgumentException();
+ throw new IllegalArgumentException("The lifeCycle cannot be null");
}
RequestLifeCycleStack lf = current.get();
if (lf == null)
Modified: kernel/branches/2.4.x/exo.kernel.container/src/main/java/org/exoplatform/container/management/ManagementContextImpl.java
===================================================================
--- kernel/branches/2.4.x/exo.kernel.container/src/main/java/org/exoplatform/container/management/ManagementContextImpl.java 2012-01-26 10:23:07 UTC (rev 5521)
+++ kernel/branches/2.4.x/exo.kernel.container/src/main/java/org/exoplatform/container/management/ManagementContextImpl.java 2012-01-26 13:19:39 UTC (rev 5522)
@@ -75,7 +75,7 @@
{
if (container == null)
{
- throw new IllegalArgumentException();
+ throw new IllegalArgumentException("The container cannot be null");
}
//
@@ -102,11 +102,11 @@
{
if (parent == null)
{
- throw new IllegalArgumentException();
+ throw new IllegalArgumentException("The parent cannot be null");
}
if (container == null)
{
- throw new IllegalArgumentException();
+ throw new IllegalArgumentException("The container cannot be null");
}
//
@@ -133,7 +133,7 @@
{
if (parent == null)
{
- throw new IllegalArgumentException();
+ throw new IllegalArgumentException("The parent cannot be null");
}
if ((resource != null && typeMD == null) && (resource == null && typeMD != null))
{
Modified: kernel/branches/2.4.x/exo.kernel.container/src/main/java/org/exoplatform/container/management/MetaDataBuilder.java
===================================================================
--- kernel/branches/2.4.x/exo.kernel.container/src/main/java/org/exoplatform/container/management/MetaDataBuilder.java 2012-01-26 10:23:07 UTC (rev 5521)
+++ kernel/branches/2.4.x/exo.kernel.container/src/main/java/org/exoplatform/container/management/MetaDataBuilder.java 2012-01-26 13:19:39 UTC (rev 5522)
@@ -91,7 +91,7 @@
{
if (clazz == null)
{
- throw new IllegalArgumentException();
+ throw new IllegalArgumentException("The clazz cannot be null");
}
//
Modified: kernel/branches/2.4.x/exo.kernel.container/src/main/java/org/exoplatform/container/monitor/jvm/J2EEServerInfo.java
===================================================================
--- kernel/branches/2.4.x/exo.kernel.container/src/main/java/org/exoplatform/container/monitor/jvm/J2EEServerInfo.java 2012-01-26 10:23:07 UTC (rev 5521)
+++ kernel/branches/2.4.x/exo.kernel.container/src/main/java/org/exoplatform/container/monitor/jvm/J2EEServerInfo.java 2012-01-26 13:19:39 UTC (rev 5522)
@@ -118,6 +118,13 @@
LOG.trace("An exception occurred: " + e.getMessage());
}
}
+ catch (IllegalArgumentException e)
+ {
+ if (LOG.isTraceEnabled())
+ {
+ LOG.trace("An exception occurred: " + e.getMessage());
+ }
+ }
}
else
{
Modified: kernel/branches/2.4.x/exo.kernel.container/src/main/java/org/exoplatform/management/spi/ManagedMethodMetaData.java
===================================================================
--- kernel/branches/2.4.x/exo.kernel.container/src/main/java/org/exoplatform/management/spi/ManagedMethodMetaData.java 2012-01-26 10:23:07 UTC (rev 5521)
+++ kernel/branches/2.4.x/exo.kernel.container/src/main/java/org/exoplatform/management/spi/ManagedMethodMetaData.java 2012-01-26 13:19:39 UTC (rev 5522)
@@ -55,11 +55,11 @@
{
if (method == null)
{
- throw new IllegalArgumentException();
+ throw new IllegalArgumentException("The method cannot be null");
}
if (impactType == null)
{
- throw new IllegalArgumentException();
+ throw new IllegalArgumentException("The impactType cannot be null");
}
//
@@ -87,7 +87,7 @@
{
if (parameter == null)
{
- throw new NullPointerException("No null parameter accepted");
+ throw new IllegalArgumentException("No null parameter accepted");
}
parameters.put(parameter.getIndex(), parameter);
}
Modified: kernel/branches/2.4.x/exo.kernel.container/src/main/java/org/exoplatform/management/spi/ManagedTypeMetaData.java
===================================================================
--- kernel/branches/2.4.x/exo.kernel.container/src/main/java/org/exoplatform/management/spi/ManagedTypeMetaData.java 2012-01-26 10:23:07 UTC (rev 5521)
+++ kernel/branches/2.4.x/exo.kernel.container/src/main/java/org/exoplatform/management/spi/ManagedTypeMetaData.java 2012-01-26 13:19:39 UTC (rev 5522)
@@ -47,7 +47,7 @@
{
if (type == null)
{
- throw new IllegalArgumentException();
+ throw new IllegalArgumentException("The type cannot be null");
}
//
More information about the exo-jcr-commits
mailing list