[forge-commits] [forge/core] 402bf2: Initial layout of a Faces scaffold provider

Vineet Reynolds Vineet.Reynolds at gmail.com
Wed Dec 4 07:26:10 EST 2013


  Branch: refs/heads/FORGE-808
  Home:   https://github.com/forge/core
  Commit: 402bf2b7f5bc0c81d650d2f8885b0399eafa0757
      https://github.com/forge/core/commit/402bf2b7f5bc0c81d650d2f8885b0399eafa0757
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-03 (Tue, 03 Dec 2013)

  Changed paths:
    M scaffold/addon/pom.xml
    A scaffold/faces/pom.xml
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesScaffoldProvider.java
    A scaffold/faces/src/main/resources/META-INF/beans.xml
    M scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ScaffoldSetupWizardImpl.java
    M scaffold/pom.xml
    M scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ScaffoldContext.java
    M scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ScaffoldProvider.java
    M scaffold/tests/pom.xml
    R scaffold/tests/src/test/java/org/jboss/forge/addon/AbstractTestCase.java
    A scaffold/tests/src/test/java/org/jboss/forge/addon/ScaffoldAddonTest.java

  Log Message:
  -----------
  Initial layout of a Faces scaffold provider


  Commit: 3073743d6e90d4228950813fec648c4655c3acb3
      https://github.com/forge/core/commit/3073743d6e90d4228950813fec648c4655c3acb3
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-03 (Tue, 03 Dec 2013)

  Changed paths:
    M scaffold/tests/src/test/java/org/jboss/forge/addon/ScaffoldAddonTest.java

  Log Message:
  -----------
  Corrected failing test for Addon detection.


  Commit: 9814331f6f286d21a7be4b419ffacbf6080cddba
      https://github.com/forge/core/commit/9814331f6f286d21a7be4b419ffacbf6080cddba
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-03 (Tue, 03 Dec 2013)

  Changed paths:
    M scaffold/faces/pom.xml
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesAccessStrategy.java
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesScaffoldProvider.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesTemplateStrategy.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/TemplateStrategy.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/freemarker/FreemarkerTemplateProcessor.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/config/ForgeConfigReader.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/inspectionresultprocessor/GeneratedValueInspectionResultProcessor.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/inspectionresultprocessor/NotRequiredInspectionResultProcessor.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/inspectionresultprocessor/RichfacesCalendarInspectionResultProcessor.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/inspector/ForgeInspectionResultConstants.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/inspector/ForgeInspector.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/inspector/propertystyle/ForgePropertyStyle.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/inspector/propertystyle/ForgePropertyStyleConfig.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/widgetbuilder/EntityWidgetBuilder.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/widgetbuilder/EntityWidgetBuilderConfig.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/widgetbuilder/HtmlSearchWidgetBuilder.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/widgetbuilder/QueryByExampleWidgetBuilder.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/widgetbuilder/RemoveEntityWidgetBuilder.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/widgetbuilder/SetPropertyActionListener.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/widgetprocessor/UnsearchableWidgetProcessor.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/util/ScaffoldUtil.java
    A scaffold/faces/src/main/resources/scaffold/faces/BackingBean.jv
    A scaffold/faces/src/main/resources/scaffold/faces/ViewUtils.jv
    A scaffold/faces/src/main/resources/scaffold/faces/add.png
    A scaffold/faces/src/main/resources/scaffold/faces/bootstrap.css
    A scaffold/faces/src/main/resources/scaffold/faces/create.xhtml
    A scaffold/faces/src/main/resources/scaffold/faces/error.xhtml
    A scaffold/faces/src/main/resources/scaffold/faces/false.png
    A scaffold/faces/src/main/resources/scaffold/faces/favicon.ico
    A scaffold/faces/src/main/resources/scaffold/faces/forge-logo.png
    A scaffold/faces/src/main/resources/scaffold/faces/forge-style.css
    A scaffold/faces/src/main/resources/scaffold/faces/forge.taglib.xml
    A scaffold/faces/src/main/resources/scaffold/faces/index.html
    A scaffold/faces/src/main/resources/scaffold/faces/index.xhtml
    A scaffold/faces/src/main/resources/scaffold/faces/jboss-community.png
    A scaffold/faces/src/main/resources/scaffold/faces/metawidget-bean.xml
    A scaffold/faces/src/main/resources/scaffold/faces/metawidget-entity.xml
    A scaffold/faces/src/main/resources/scaffold/faces/metawidget-qbe.xml
    A scaffold/faces/src/main/resources/scaffold/faces/metawidget-remove-entity.xml
    A scaffold/faces/src/main/resources/scaffold/faces/metawidget-search.xml
    A scaffold/faces/src/main/resources/scaffold/faces/pageTemplate.xhtml
    A scaffold/faces/src/main/resources/scaffold/faces/paginator.xhtml
    A scaffold/faces/src/main/resources/scaffold/faces/remove.png
    A scaffold/faces/src/main/resources/scaffold/faces/search.png
    A scaffold/faces/src/main/resources/scaffold/faces/search.xhtml
    A scaffold/faces/src/main/resources/scaffold/faces/true.png
    A scaffold/faces/src/main/resources/scaffold/faces/view.xhtml
    M scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ScaffoldSetupWizardImpl.java
    A scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/AccessStrategy.java
    M scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ScaffoldContext.java
    M scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ScaffoldProvider.java

  Log Message:
  -----------
  Implemented the Faces scaffold provider

Removed Seam Render since it was resulting in WELD-1453/SOLDER-339.
Switched the Seam Render templates to Freemarker.

Unported APIs/classes are currently not used/commented out with
TODOs.


  Commit: f60624c69b4146794ef020ba3d6407c6589d7b9c
      https://github.com/forge/core/commit/f60624c69b4146794ef020ba3d6407c6589d7b9c
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-03 (Tue, 03 Dec 2013)

  Changed paths:
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesScaffoldProvider.java
    M scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ScaffoldSetupWizardImpl.java
    M scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ScaffoldProvider.java

  Log Message:
  -----------
  Removed unnecessary method from ScaffoldProvider API.

The scaffold provider should not be indicating whether it supports
 overwrite or not.


  Commit: a62134b22b53711de97daf175a38328b67eebd47
      https://github.com/forge/core/commit/a62134b22b53711de97daf175a38328b67eebd47
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-03 (Tue, 03 Dec 2013)

  Changed paths:
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesScaffoldProvider.java
    M scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ScaffoldSetupWizardImpl.java
    M scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ScaffoldProvider.java

  Log Message:
  -----------
  Modified the ScaffoldProvider setup flow API.

ScaffoldProviders now return a List of UICommands that
are to be executed.


  Commit: fb0814415ade928c02e06e3c6fc431346103bd05
      https://github.com/forge/core/commit/fb0814415ade928c02e06e3c6fc431346103bd05
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-03 (Tue, 03 Dec 2013)

  Changed paths:
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesScaffoldProvider.java
    M scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ScaffoldSetupWizardImpl.java

  Log Message:
  -----------
  Added facet installation checks.

The Faces scaffold provider now verifies that the required facets
have been installed before setting up the Faces scaffold.


  Commit: 8c179d9fffb0dadd3f329cf13c98152f83530890
      https://github.com/forge/core/commit/8c179d9fffb0dadd3f329cf13c98152f83530890
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-03 (Tue, 03 Dec 2013)

  Changed paths:
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesScaffoldProvider.java

  Log Message:
  -----------
  Fixed the setup process to create correct web.xml files.

Entries in web.xml files are now created correctly.


  Commit: b7d844be392c4ffda3435bf92bb0c459bd0c405a
      https://github.com/forge/core/commit/b7d844be392c4ffda3435bf92bb0c459bd0c405a
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-03 (Tue, 03 Dec 2013)

  Changed paths:
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesScaffoldProvider.java
    M scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ScaffoldSetupWizardImpl.java

  Log Message:
  -----------
  Refined the messages.


  Commit: 85afd7573921c623a1ed544d3c73994441c3e9b4
      https://github.com/forge/core/commit/85afd7573921c623a1ed544d3c73994441c3e9b4
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-03 (Tue, 03 Dec 2013)

  Changed paths:
    M scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ScaffoldSetupWizardImpl.java
    M scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ScaffoldContext.java

  Log Message:
  -----------
  Target directory should not be required. It is optional.

Use an empty string if the target directory is not specified.


  Commit: 446e48a342ad4d382f6cea7205837d5378d2f7e2
      https://github.com/forge/core/commit/446e48a342ad4d382f6cea7205837d5378d2f7e2
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-03 (Tue, 03 Dec 2013)

  Changed paths:
    M scaffold/api/src/main/java/org/jboss/forge/addon/scaffold/ui/ScaffoldGenerateCommand.java
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesScaffoldProvider.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/ScaffoldableEntitySelectionWizard.java
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/inspector/propertystyle/ForgePropertyStyle.java
    M scaffold/faces/src/main/resources/scaffold/faces/metawidget-bean.xml
    M scaffold/faces/src/main/resources/scaffold/faces/metawidget-entity.xml
    M scaffold/faces/src/main/resources/scaffold/faces/metawidget-qbe.xml
    M scaffold/faces/src/main/resources/scaffold/faces/metawidget-remove-entity.xml
    M scaffold/faces/src/main/resources/scaffold/faces/metawidget-search.xml
    M scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ScaffoldGenerateCommandImpl.java
    M scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ScaffoldSetupWizardImpl.java
    A scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ResourceCollection.java
    R scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ScaffoldContext.java
    A scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ScaffoldGenerationContext.java
    M scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ScaffoldProvider.java
    A scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ScaffoldSetupContext.java

  Log Message:
  -----------
  Committing first functional version of the Faces scaffold

Some bugs are not yet fixed though. CDI and EJB facets are not
installed.


  Commit: 91d4a5b287af263186b6dfb82cd553ec91666a30
      https://github.com/forge/core/commit/91d4a5b287af263186b6dfb82cd553ec91666a30
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-03 (Tue, 03 Dec 2013)

  Changed paths:
    M scaffold/faces/pom.xml

  Log Message:
  -----------
  Removed unwanted property for Seam Render version


  Commit: 4db75f8ce06743b986142475a483e7d017072ced
      https://github.com/forge/core/commit/4db75f8ce06743b986142475a483e7d017072ced
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-03 (Tue, 03 Dec 2013)

  Changed paths:
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesScaffoldProvider.java

  Log Message:
  -----------
  Expanded Facet subtype checks.

This is to bypass FORGE-1304 for now.


  Commit: c46dfa7ca172a5c0e258b2126b4e15a655b121fb
      https://github.com/forge/core/commit/c46dfa7ca172a5c0e258b2126b4e15a655b121fb
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-03 (Tue, 03 Dec 2013)

  Changed paths:
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesScaffoldProvider.java
    M scaffold/faces/src/main/resources/scaffold/faces/create.xhtml
    M scaffold/faces/src/main/resources/scaffold/faces/pageTemplate.xhtml
    M scaffold/faces/src/main/resources/scaffold/faces/search.xhtml
    M scaffold/faces/src/main/resources/scaffold/faces/view.xhtml

  Log Message:
  -----------
  Fixed Freemarker template issues

Locked the template to pageTemplate.xhtml. Corrected the escaping
of #{ and ${ expressions in the facelets.


  Commit: b59f7589e437d127388e2b7d79053582ce568fa9
      https://github.com/forge/core/commit/b59f7589e437d127388e2b7d79053582ce568fa9
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-03 (Tue, 03 Dec 2013)

  Changed paths:
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesScaffoldProvider.java

  Log Message:
  -----------
  Fixed CDI Facet detection logic


  Commit: 22113f90f355dda79e7e9b8b9379d568f0a762d8
      https://github.com/forge/core/commit/22113f90f355dda79e7e9b8b9379d568f0a762d8
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-03 (Tue, 03 Dec 2013)

  Changed paths:
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesAccessStrategy.java
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesScaffoldProvider.java

  Log Message:
  -----------
  Removed explicit subtype Facet detection logic

The explicit detection of Facets is no longer necessary, since the
bug in subflow display logic is actually in UI-Eclipse.


  Commit: 7d80d477170f778485722c6f4bbe49cce4fb532c
      https://github.com/forge/core/commit/7d80d477170f778485722c6f4bbe49cce4fb532c
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-03 (Tue, 03 Dec 2013)

  Changed paths:
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/ScaffoldableEntitySelectionWizard.java
    A scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ExecuteGenerationCommand.java
    A scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ExecuteSetupCommand.java
    M scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ScaffoldGenerateCommandImpl.java
    M scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ScaffoldSetupWizardImpl.java
    M scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ScaffoldGenerationContext.java

  Log Message:
  -----------
  Refactored the scaffold generation into a new step

This now ensures that the scaffold generation is performed in the
final step instead of the first step.


Compare: https://github.com/forge/core/compare/a7ae18d53f36...7d80d477170f


More information about the forge-commits mailing list