[forge-commits] [forge/core] 78e5c2: Initial layout of a Faces scaffold provider

Vineet Reynolds Vineet.Reynolds at gmail.com
Fri Dec 6 14:48:40 EST 2013


  Branch: refs/heads/FORGE-808
  Home:   https://github.com/forge/core
  Commit: 78e5c2e662cae5147f08e2d40289e98de0eaf182
      https://github.com/forge/core/commit/78e5c2e662cae5147f08e2d40289e98de0eaf182
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-06 (Fri, 06 Dec 2013)

  Changed paths:
    M scaffold/addon/pom.xml
    A scaffold/faces/pom.xml
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesScaffoldProvider.java
    A scaffold/faces/src/main/resources/META-INF/beans.xml
    M scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ScaffoldSetupWizardImpl.java
    M scaffold/pom.xml
    M scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ScaffoldContext.java
    M scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ScaffoldProvider.java
    M scaffold/tests/pom.xml
    R scaffold/tests/src/test/java/org/jboss/forge/addon/AbstractTestCase.java
    A scaffold/tests/src/test/java/org/jboss/forge/addon/ScaffoldAddonTest.java

  Log Message:
  -----------
  Initial layout of a Faces scaffold provider


  Commit: 3bb5a8eb76a735c8ce0cb818ed025012d6845526
      https://github.com/forge/core/commit/3bb5a8eb76a735c8ce0cb818ed025012d6845526
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-06 (Fri, 06 Dec 2013)

  Changed paths:
    M scaffold/tests/src/test/java/org/jboss/forge/addon/ScaffoldAddonTest.java

  Log Message:
  -----------
  Corrected failing test for Addon detection.


  Commit: a18cdaf0b82ba8a2b8dcacb5865fab90779b825c
      https://github.com/forge/core/commit/a18cdaf0b82ba8a2b8dcacb5865fab90779b825c
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-06 (Fri, 06 Dec 2013)

  Changed paths:
    M scaffold/faces/pom.xml
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesAccessStrategy.java
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesScaffoldProvider.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesTemplateStrategy.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/TemplateStrategy.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/freemarker/FreemarkerTemplateProcessor.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/config/ForgeConfigReader.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/inspectionresultprocessor/GeneratedValueInspectionResultProcessor.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/inspectionresultprocessor/NotRequiredInspectionResultProcessor.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/inspectionresultprocessor/RichfacesCalendarInspectionResultProcessor.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/inspector/ForgeInspectionResultConstants.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/inspector/ForgeInspector.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/inspector/propertystyle/ForgePropertyStyle.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/inspector/propertystyle/ForgePropertyStyleConfig.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/widgetbuilder/EntityWidgetBuilder.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/widgetbuilder/EntityWidgetBuilderConfig.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/widgetbuilder/HtmlSearchWidgetBuilder.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/widgetbuilder/QueryByExampleWidgetBuilder.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/widgetbuilder/RemoveEntityWidgetBuilder.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/widgetbuilder/SetPropertyActionListener.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/widgetprocessor/UnsearchableWidgetProcessor.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/util/ScaffoldUtil.java
    A scaffold/faces/src/main/resources/scaffold/faces/BackingBean.jv
    A scaffold/faces/src/main/resources/scaffold/faces/ViewUtils.jv
    A scaffold/faces/src/main/resources/scaffold/faces/add.png
    A scaffold/faces/src/main/resources/scaffold/faces/bootstrap.css
    A scaffold/faces/src/main/resources/scaffold/faces/create.xhtml
    A scaffold/faces/src/main/resources/scaffold/faces/error.xhtml
    A scaffold/faces/src/main/resources/scaffold/faces/false.png
    A scaffold/faces/src/main/resources/scaffold/faces/favicon.ico
    A scaffold/faces/src/main/resources/scaffold/faces/forge-logo.png
    A scaffold/faces/src/main/resources/scaffold/faces/forge-style.css
    A scaffold/faces/src/main/resources/scaffold/faces/forge.taglib.xml
    A scaffold/faces/src/main/resources/scaffold/faces/index.html
    A scaffold/faces/src/main/resources/scaffold/faces/index.xhtml
    A scaffold/faces/src/main/resources/scaffold/faces/jboss-community.png
    A scaffold/faces/src/main/resources/scaffold/faces/metawidget-bean.xml
    A scaffold/faces/src/main/resources/scaffold/faces/metawidget-entity.xml
    A scaffold/faces/src/main/resources/scaffold/faces/metawidget-qbe.xml
    A scaffold/faces/src/main/resources/scaffold/faces/metawidget-remove-entity.xml
    A scaffold/faces/src/main/resources/scaffold/faces/metawidget-search.xml
    A scaffold/faces/src/main/resources/scaffold/faces/pageTemplate.xhtml
    A scaffold/faces/src/main/resources/scaffold/faces/paginator.xhtml
    A scaffold/faces/src/main/resources/scaffold/faces/remove.png
    A scaffold/faces/src/main/resources/scaffold/faces/search.png
    A scaffold/faces/src/main/resources/scaffold/faces/search.xhtml
    A scaffold/faces/src/main/resources/scaffold/faces/true.png
    A scaffold/faces/src/main/resources/scaffold/faces/view.xhtml
    M scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ScaffoldSetupWizardImpl.java
    A scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/AccessStrategy.java
    M scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ScaffoldContext.java
    M scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ScaffoldProvider.java

  Log Message:
  -----------
  Implemented the Faces scaffold provider

Removed Seam Render since it was resulting in WELD-1453/SOLDER-339.
Switched the Seam Render templates to Freemarker.

Unported APIs/classes are currently not used/commented out with
TODOs.


  Commit: 2aef42dac17df15aaae5fdd9b56a77e54968fcea
      https://github.com/forge/core/commit/2aef42dac17df15aaae5fdd9b56a77e54968fcea
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-06 (Fri, 06 Dec 2013)

  Changed paths:
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesScaffoldProvider.java
    M scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ScaffoldSetupWizardImpl.java
    M scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ScaffoldProvider.java

  Log Message:
  -----------
  Removed unnecessary method from ScaffoldProvider API.

The scaffold provider should not be indicating whether it supports
 overwrite or not.


  Commit: ade79dde006ad61e13f99b7d84e527a97ff669e1
      https://github.com/forge/core/commit/ade79dde006ad61e13f99b7d84e527a97ff669e1
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-06 (Fri, 06 Dec 2013)

  Changed paths:
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesScaffoldProvider.java
    M scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ScaffoldSetupWizardImpl.java
    M scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ScaffoldProvider.java

  Log Message:
  -----------
  Modified the ScaffoldProvider setup flow API.

ScaffoldProviders now return a List of UICommands that
are to be executed.


  Commit: 97e468689cab5833e1c4fcac696e809a64bf7dcb
      https://github.com/forge/core/commit/97e468689cab5833e1c4fcac696e809a64bf7dcb
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-06 (Fri, 06 Dec 2013)

  Changed paths:
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesScaffoldProvider.java
    M scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ScaffoldSetupWizardImpl.java

  Log Message:
  -----------
  Added facet installation checks.

The Faces scaffold provider now verifies that the required facets
have been installed before setting up the Faces scaffold.


  Commit: 6b7bf96524fff219d400ebe050883b603f4b1c8b
      https://github.com/forge/core/commit/6b7bf96524fff219d400ebe050883b603f4b1c8b
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-06 (Fri, 06 Dec 2013)

  Changed paths:
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesScaffoldProvider.java

  Log Message:
  -----------
  Fixed the setup process to create correct web.xml files.

Entries in web.xml files are now created correctly.


  Commit: 4ab4d2561083111f60209db7d8b213d18fd0ade9
      https://github.com/forge/core/commit/4ab4d2561083111f60209db7d8b213d18fd0ade9
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-06 (Fri, 06 Dec 2013)

  Changed paths:
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesScaffoldProvider.java
    M scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ScaffoldSetupWizardImpl.java

  Log Message:
  -----------
  Refined the messages.


  Commit: 46e338ce60be70dcfe4d389ebca8a689676e0eea
      https://github.com/forge/core/commit/46e338ce60be70dcfe4d389ebca8a689676e0eea
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-06 (Fri, 06 Dec 2013)

  Changed paths:
    M scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ScaffoldSetupWizardImpl.java
    M scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ScaffoldContext.java

  Log Message:
  -----------
  Target directory should not be required. It is optional.

Use an empty string if the target directory is not specified.


  Commit: bd702f569ffd143eeb877534662cdcf57bb5c5af
      https://github.com/forge/core/commit/bd702f569ffd143eeb877534662cdcf57bb5c5af
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-06 (Fri, 06 Dec 2013)

  Changed paths:
    M scaffold/api/src/main/java/org/jboss/forge/addon/scaffold/ui/ScaffoldGenerateCommand.java
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesScaffoldProvider.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/ScaffoldableEntitySelectionWizard.java
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/inspector/propertystyle/ForgePropertyStyle.java
    M scaffold/faces/src/main/resources/scaffold/faces/metawidget-bean.xml
    M scaffold/faces/src/main/resources/scaffold/faces/metawidget-entity.xml
    M scaffold/faces/src/main/resources/scaffold/faces/metawidget-qbe.xml
    M scaffold/faces/src/main/resources/scaffold/faces/metawidget-remove-entity.xml
    M scaffold/faces/src/main/resources/scaffold/faces/metawidget-search.xml
    M scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ScaffoldGenerateCommandImpl.java
    M scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ScaffoldSetupWizardImpl.java
    A scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ResourceCollection.java
    R scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ScaffoldContext.java
    A scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ScaffoldGenerationContext.java
    M scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ScaffoldProvider.java
    A scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ScaffoldSetupContext.java

  Log Message:
  -----------
  Committing first functional version of the Faces scaffold

Some bugs are not yet fixed though. CDI and EJB facets are not
installed.


  Commit: 7a0ff1d7d481782727f65c70948aff6539368ea9
      https://github.com/forge/core/commit/7a0ff1d7d481782727f65c70948aff6539368ea9
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-06 (Fri, 06 Dec 2013)

  Changed paths:
    M scaffold/faces/pom.xml

  Log Message:
  -----------
  Removed unwanted property for Seam Render version


  Commit: 4e8a726d34df19685edfea1078129c0e68ff1af7
      https://github.com/forge/core/commit/4e8a726d34df19685edfea1078129c0e68ff1af7
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-06 (Fri, 06 Dec 2013)

  Changed paths:
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesScaffoldProvider.java

  Log Message:
  -----------
  Expanded Facet subtype checks.

This is to bypass FORGE-1304 for now.


  Commit: cd657dbd9e219bf1d9ecb0841e8679b19b7d6ab8
      https://github.com/forge/core/commit/cd657dbd9e219bf1d9ecb0841e8679b19b7d6ab8
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-06 (Fri, 06 Dec 2013)

  Changed paths:
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesScaffoldProvider.java
    M scaffold/faces/src/main/resources/scaffold/faces/create.xhtml
    M scaffold/faces/src/main/resources/scaffold/faces/pageTemplate.xhtml
    M scaffold/faces/src/main/resources/scaffold/faces/search.xhtml
    M scaffold/faces/src/main/resources/scaffold/faces/view.xhtml

  Log Message:
  -----------
  Fixed Freemarker template issues

Locked the template to pageTemplate.xhtml. Corrected the escaping
of #{ and ${ expressions in the facelets.


  Commit: eb9a87903c079eb72fa873dc954ac08f320ec5f9
      https://github.com/forge/core/commit/eb9a87903c079eb72fa873dc954ac08f320ec5f9
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-06 (Fri, 06 Dec 2013)

  Changed paths:
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesScaffoldProvider.java

  Log Message:
  -----------
  Fixed CDI Facet detection logic


  Commit: d2bb442d7d18175354ac543f4f55b46c2d34b5d3
      https://github.com/forge/core/commit/d2bb442d7d18175354ac543f4f55b46c2d34b5d3
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-06 (Fri, 06 Dec 2013)

  Changed paths:
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesAccessStrategy.java
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesScaffoldProvider.java

  Log Message:
  -----------
  Removed explicit subtype Facet detection logic

The explicit detection of Facets is no longer necessary, since the
bug in subflow display logic is actually in UI-Eclipse.


  Commit: 2e8e6262e6cadcfe2e6ebccf32f0966483ae2bb7
      https://github.com/forge/core/commit/2e8e6262e6cadcfe2e6ebccf32f0966483ae2bb7
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-06 (Fri, 06 Dec 2013)

  Changed paths:
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/ScaffoldableEntitySelectionWizard.java
    A scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ExecuteGenerationCommand.java
    A scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ExecuteSetupCommand.java
    M scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ScaffoldGenerateCommandImpl.java
    M scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ScaffoldSetupWizardImpl.java
    M scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ScaffoldGenerationContext.java

  Log Message:
  -----------
  Refactored the scaffold generation into a new step

This now ensures that the scaffold generation is performed in the
final step instead of the first step.


  Commit: 59446a70d9fd5f0061293ee404fac56fafd3bfb1
      https://github.com/forge/core/commit/59446a70d9fd5f0061293ee404fac56fafd3bfb1
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-06 (Fri, 06 Dec 2013)

  Changed paths:
    M scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ScaffoldSetupWizardImpl.java
    M scaffold/tests/src/test/java/org/jboss/forge/addon/ScaffoldAddonTest.java

  Log Message:
  -----------
  Remove unused imports.


  Commit: 90efd58c0583d9c15a2d947efe9d7b83e5bdb669
      https://github.com/forge/core/commit/90efd58c0583d9c15a2d947efe9d7b83e5bdb669
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-12-06 (Fri, 06 Dec 2013)

  Changed paths:
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesScaffoldProvider.java
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesTemplateStrategy.java
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/ScaffoldableEntitySelectionWizard.java
    M scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ScaffoldGenerationContext.java

  Log Message:
  -----------
  Allow custom Faces templates for the Faces scaffold


Compare: https://github.com/forge/core/compare/23bc4d80c9a8...90efd58c0583


More information about the forge-commits mailing list