[forge-commits] [forge/core] 136d76: Initial layout of a Faces scaffold provider

Vineet Reynolds Vineet.Reynolds at gmail.com
Mon Nov 18 17:59:37 EST 2013


  Branch: refs/heads/FORGE-808
  Home:   https://github.com/forge/core
  Commit: 136d7653f91ebb4e7ac88f218ede1d089d636738
      https://github.com/forge/core/commit/136d7653f91ebb4e7ac88f218ede1d089d636738
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-11-18 (Mon, 18 Nov 2013)

  Changed paths:
    M scaffold/addon/pom.xml
    A scaffold/faces/pom.xml
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesScaffoldProvider.java
    A scaffold/faces/src/main/resources/META-INF/beans.xml
    M scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ScaffoldSetupWizardImpl.java
    M scaffold/pom.xml
    M scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ScaffoldContext.java
    M scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ScaffoldProvider.java
    M scaffold/tests/pom.xml
    R scaffold/tests/src/test/java/org/jboss/forge/addon/AbstractTestCase.java
    A scaffold/tests/src/test/java/org/jboss/forge/addon/ScaffoldAddonTest.java

  Log Message:
  -----------
  Initial layout of a Faces scaffold provider


  Commit: 99017e913b2d4a9a24340b3bf60296b96878e209
      https://github.com/forge/core/commit/99017e913b2d4a9a24340b3bf60296b96878e209
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-11-18 (Mon, 18 Nov 2013)

  Changed paths:
    M scaffold/tests/src/test/java/org/jboss/forge/addon/ScaffoldAddonTest.java

  Log Message:
  -----------
  Corrected failing test for Addon detection.


  Commit: 3cb867006e90269b294d96d52b98588087a951da
      https://github.com/forge/core/commit/3cb867006e90269b294d96d52b98588087a951da
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-11-18 (Mon, 18 Nov 2013)

  Changed paths:
    M scaffold/faces/pom.xml
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesAccessStrategy.java
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesScaffoldProvider.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesTemplateStrategy.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/TemplateStrategy.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/freemarker/FreemarkerTemplateProcessor.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/config/ForgeConfigReader.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/inspectionresultprocessor/GeneratedValueInspectionResultProcessor.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/inspectionresultprocessor/NotRequiredInspectionResultProcessor.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/inspectionresultprocessor/RichfacesCalendarInspectionResultProcessor.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/inspector/ForgeInspectionResultConstants.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/inspector/ForgeInspector.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/inspector/propertystyle/ForgePropertyStyle.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/inspector/propertystyle/ForgePropertyStyleConfig.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/widgetbuilder/EntityWidgetBuilder.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/widgetbuilder/EntityWidgetBuilderConfig.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/widgetbuilder/HtmlSearchWidgetBuilder.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/widgetbuilder/QueryByExampleWidgetBuilder.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/widgetbuilder/RemoveEntityWidgetBuilder.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/widgetbuilder/SetPropertyActionListener.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/widgetprocessor/UnsearchableWidgetProcessor.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/util/ScaffoldUtil.java
    A scaffold/faces/src/main/resources/scaffold/faces/BackingBean.jv
    A scaffold/faces/src/main/resources/scaffold/faces/ViewUtils.jv
    A scaffold/faces/src/main/resources/scaffold/faces/add.png
    A scaffold/faces/src/main/resources/scaffold/faces/bootstrap.css
    A scaffold/faces/src/main/resources/scaffold/faces/create.xhtml
    A scaffold/faces/src/main/resources/scaffold/faces/error.xhtml
    A scaffold/faces/src/main/resources/scaffold/faces/false.png
    A scaffold/faces/src/main/resources/scaffold/faces/favicon.ico
    A scaffold/faces/src/main/resources/scaffold/faces/forge-logo.png
    A scaffold/faces/src/main/resources/scaffold/faces/forge-style.css
    A scaffold/faces/src/main/resources/scaffold/faces/forge.taglib.xml
    A scaffold/faces/src/main/resources/scaffold/faces/index.html
    A scaffold/faces/src/main/resources/scaffold/faces/index.xhtml
    A scaffold/faces/src/main/resources/scaffold/faces/jboss-community.png
    A scaffold/faces/src/main/resources/scaffold/faces/metawidget-bean.xml
    A scaffold/faces/src/main/resources/scaffold/faces/metawidget-entity.xml
    A scaffold/faces/src/main/resources/scaffold/faces/metawidget-qbe.xml
    A scaffold/faces/src/main/resources/scaffold/faces/metawidget-remove-entity.xml
    A scaffold/faces/src/main/resources/scaffold/faces/metawidget-search.xml
    A scaffold/faces/src/main/resources/scaffold/faces/pageTemplate.xhtml
    A scaffold/faces/src/main/resources/scaffold/faces/paginator.xhtml
    A scaffold/faces/src/main/resources/scaffold/faces/remove.png
    A scaffold/faces/src/main/resources/scaffold/faces/search.png
    A scaffold/faces/src/main/resources/scaffold/faces/search.xhtml
    A scaffold/faces/src/main/resources/scaffold/faces/true.png
    A scaffold/faces/src/main/resources/scaffold/faces/view.xhtml
    M scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ScaffoldSetupWizardImpl.java
    A scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/AccessStrategy.java
    M scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ScaffoldContext.java
    M scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ScaffoldProvider.java

  Log Message:
  -----------
  Implemented the Faces scaffold provider

Removed Seam Render since it was resulting in WELD-1453/SOLDER-339.
Switched the Seam Render templates to Freemarker.

Unported APIs/classes are currently not used/commented out with
TODOs.


  Commit: 417deb9ca9b350719ac72d31cb28ddbe6f4ea75b
      https://github.com/forge/core/commit/417deb9ca9b350719ac72d31cb28ddbe6f4ea75b
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-11-18 (Mon, 18 Nov 2013)

  Changed paths:
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesScaffoldProvider.java
    M scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ScaffoldSetupWizardImpl.java
    M scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ScaffoldProvider.java

  Log Message:
  -----------
  Removed unnecessary method from ScaffoldProvider API.

The scaffold provider should not be indicating whether it supports
 overwrite or not.


  Commit: ec25a4992fa10c187f276fc16a43d96b1ed5e3f5
      https://github.com/forge/core/commit/ec25a4992fa10c187f276fc16a43d96b1ed5e3f5
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-11-18 (Mon, 18 Nov 2013)

  Changed paths:
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesScaffoldProvider.java
    M scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ScaffoldSetupWizardImpl.java
    M scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ScaffoldProvider.java

  Log Message:
  -----------
  Modified the ScaffoldProvider setup flow API.

ScaffoldProviders now return a List of UICommands that
are to be executed.


  Commit: 120775ea1efa2c1ad5f4a8cece4e0666deb9a6a3
      https://github.com/forge/core/commit/120775ea1efa2c1ad5f4a8cece4e0666deb9a6a3
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-11-18 (Mon, 18 Nov 2013)

  Changed paths:
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesScaffoldProvider.java
    M scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ScaffoldSetupWizardImpl.java

  Log Message:
  -----------
  Added facet installation checks.

The Faces scaffold provider now verifies that the required facets
have been installed before setting up the Faces scaffold.


  Commit: 8c02b890e364b4baf3daf3aab5ce23f0f94e0f01
      https://github.com/forge/core/commit/8c02b890e364b4baf3daf3aab5ce23f0f94e0f01
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-11-18 (Mon, 18 Nov 2013)

  Changed paths:
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesScaffoldProvider.java

  Log Message:
  -----------
  Fixed the setup process to create correct web.xml files.

Entries in web.xml files are now created correctly.


  Commit: c4a15d21ae3c52f1a15510a506ee5a3bb2ecae68
      https://github.com/forge/core/commit/c4a15d21ae3c52f1a15510a506ee5a3bb2ecae68
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-11-18 (Mon, 18 Nov 2013)

  Changed paths:
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesScaffoldProvider.java
    M scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ScaffoldSetupWizardImpl.java

  Log Message:
  -----------
  Refined the messages.


  Commit: 88aaeec30b932a1fb9b7b8adefef580704533a91
      https://github.com/forge/core/commit/88aaeec30b932a1fb9b7b8adefef580704533a91
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-11-18 (Mon, 18 Nov 2013)

  Changed paths:
    M scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ScaffoldSetupWizardImpl.java
    M scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ScaffoldContext.java

  Log Message:
  -----------
  Target directory should not be required. It is optional.

Use an empty string if the target directory is not specified.


  Commit: 5ae74a246e12a179fc7686159a8b276a97ef60b9
      https://github.com/forge/core/commit/5ae74a246e12a179fc7686159a8b276a97ef60b9
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-11-18 (Mon, 18 Nov 2013)

  Changed paths:
    M scaffold/api/src/main/java/org/jboss/forge/addon/scaffold/ui/ScaffoldGenerateCommand.java
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesScaffoldProvider.java
    A scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/ScaffoldableEntitySelectionWizard.java
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/metawidget/inspector/propertystyle/ForgePropertyStyle.java
    M scaffold/faces/src/main/resources/scaffold/faces/metawidget-bean.xml
    M scaffold/faces/src/main/resources/scaffold/faces/metawidget-entity.xml
    M scaffold/faces/src/main/resources/scaffold/faces/metawidget-qbe.xml
    M scaffold/faces/src/main/resources/scaffold/faces/metawidget-remove-entity.xml
    M scaffold/faces/src/main/resources/scaffold/faces/metawidget-search.xml
    M scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ScaffoldGenerateCommandImpl.java
    M scaffold/impl/src/main/java/org/jboss/forge/addon/scaffold/impl/ui/ScaffoldSetupWizardImpl.java
    A scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ResourceCollection.java
    R scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ScaffoldContext.java
    A scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ScaffoldGenerationContext.java
    M scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ScaffoldProvider.java
    A scaffold/spi/src/main/java/org/jboss/forge/addon/scaffold/spi/ScaffoldSetupContext.java

  Log Message:
  -----------
  Committing first functional version of the Faces scaffold

Some bugs are not yet fixed though. CDI and EJB facets are not
installed.


  Commit: 7cc0f37b796f8bb71e714c35c5b3aeb955f336b6
      https://github.com/forge/core/commit/7cc0f37b796f8bb71e714c35c5b3aeb955f336b6
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-11-18 (Mon, 18 Nov 2013)

  Changed paths:
    M scaffold/faces/pom.xml

  Log Message:
  -----------
  Removed unwanted property for Seam Render version


  Commit: eec64ce4f4e9d19b9e4279d78d96f6830c3cf9a2
      https://github.com/forge/core/commit/eec64ce4f4e9d19b9e4279d78d96f6830c3cf9a2
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-11-18 (Mon, 18 Nov 2013)

  Changed paths:
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesScaffoldProvider.java

  Log Message:
  -----------
  Expanded Facet subtype checks.

This is to bypass FORGE-1304 for now.


  Commit: 0bfb6be15e622c99eb7c1283080bdf37271fae44
      https://github.com/forge/core/commit/0bfb6be15e622c99eb7c1283080bdf37271fae44
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-11-18 (Mon, 18 Nov 2013)

  Changed paths:
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesScaffoldProvider.java
    M scaffold/faces/src/main/resources/scaffold/faces/create.xhtml
    M scaffold/faces/src/main/resources/scaffold/faces/pageTemplate.xhtml
    M scaffold/faces/src/main/resources/scaffold/faces/search.xhtml
    M scaffold/faces/src/main/resources/scaffold/faces/view.xhtml

  Log Message:
  -----------
  Fixed Freemarker template issues

Locked the template to pageTemplate.xhtml. Corrected the escaping
of #{ and ${ expressions in the facelets.


  Commit: 938bd6f4dd8aec7c2896d98a80331ae387940c0b
      https://github.com/forge/core/commit/938bd6f4dd8aec7c2896d98a80331ae387940c0b
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-11-18 (Mon, 18 Nov 2013)

  Changed paths:
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesScaffoldProvider.java

  Log Message:
  -----------
  Fixed CDI Facet detection logic


  Commit: a7ae18d53f36601a1eadc4324a13eccea6cbc232
      https://github.com/forge/core/commit/a7ae18d53f36601a1eadc4324a13eccea6cbc232
  Author: Vineet Reynolds <Vineet.Reynolds at gmail.com>
  Date:   2013-11-18 (Mon, 18 Nov 2013)

  Changed paths:
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesAccessStrategy.java
    M scaffold/faces/src/main/java/org/jboss/forge/addon/scaffold/faces/FacesScaffoldProvider.java

  Log Message:
  -----------
  Removed explicit subtype Facet detection logic

The explicit detection of Facets is no longer necessary, since the
bug in subflow display logic is actually in UI-Eclipse.


Compare: https://github.com/forge/core/compare/4b47da9dc077...a7ae18d53f36


More information about the forge-commits mailing list