[forge-commits] [forge/core] e6baad: Moved getContents() to Resource interface

Lincoln Baxter, III lincolnbaxter at gmail.com
Fri Oct 18 03:13:58 EDT 2013


Hey,

Why did this happen? What drove this change?

Not sure this is a good idea to assume that all resources contain string
content.... In fact, I think it would be a mistake.

If this needs to be separated out, then  perhaps a new StringResource
interface should be extracted instead, but I don't think that Resource
should extend it.

In fact, I'm not even sure it Resource should have a getInputStream()
method, ideally.

---
Lincoln Baxter's Droid
http://ocpsoft.org
"Keep it Simple"
On Oct 16, 2013 8:25 PM, "George Gastaldi" <gegastaldi at gmail.com> wrote:

>   Branch: refs/heads/2.0
>   Home:   https://github.com/forge/core
>   Commit: e6baad18648d9c7e2634820bc219f31cd3cb5f6a
>
> https://github.com/forge/core/commit/e6baad18648d9c7e2634820bc219f31cd3cb5f6a
>   Author: George Gastaldi <gegastaldi at gmail.com>
>   Date:   2013-10-16 (Wed, 16 Oct 2013)
>
>   Changed paths:
>     M
> resources/api/src/main/java/org/jboss/forge/addon/resource/AbstractFileResource.java
>     M
> resources/api/src/main/java/org/jboss/forge/addon/resource/AbstractResource.java
>     M
> resources/api/src/main/java/org/jboss/forge/addon/resource/FileResource.java
>     M
> resources/api/src/main/java/org/jboss/forge/addon/resource/Resource.java
>
>   Log Message:
>   -----------
>   Moved getContents() to Resource interface
>
>
>
>
> _______________________________________________
> forge-commits mailing list
> forge-commits at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/forge-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/forge-commits/attachments/20131018/77818f89/attachment.html 


More information about the forge-commits mailing list