<p dir="ltr">Hey Adam, nice work on all this! Its looking great. One question. Is this going to work on all operating systems?</p>
<p dir="ltr"><a href="https://github.com/forge/addon-gradle/compare/1e501ac1f3f7...d8a4cdd3b859#L7L30">https://github.com/forge/addon-gradle/compare/1e501ac1f3f7...d8a4cdd3b859#L7L30</a></p>
<p dir="ltr">You might want to ask george and Vineet about this because I think we have a common way to handle OS path canonicalization.</p>
<p dir="ltr">Keep up the great work!</p>
<p dir="ltr">---<br>
Lincoln Baxter's Droid<br>
<a href="http://ocpsoft.org">http://ocpsoft.org</a><br>
"Keep it Simple"</p>
<div class="gmail_quote">On Aug 8, 2013 7:17 PM, "Adam Wyłuda" <<a href="mailto:adamwyl92@gmail.com">adamwyl92@gmail.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Branch: refs/heads/master<br>
Home: <a href="https://github.com/forge/addon-gradle" target="_blank">https://github.com/forge/addon-gradle</a><br>
Commit: ddd10ce6bc84b9c219a593afc97a7cb728e046f8<br>
<a href="https://github.com/forge/addon-gradle/commit/ddd10ce6bc84b9c219a593afc97a7cb728e046f8" target="_blank">https://github.com/forge/addon-gradle/commit/ddd10ce6bc84b9c219a593afc97a7cb728e046f8</a><br>
Author: Adam Wyłuda <<a href="mailto:adamwyl92@gmail.com">adamwyl92@gmail.com</a>><br>
Date: 2013-08-08 (Thu, 08 Aug 2013)<br>
<br>
Changed paths:<br>
M impl/src/main/java/org/jboss/forge/addon/gradle/parser/GradleSourceUtil.java<br>
M impl/src/test/java/org/jboss/forge/addon/gradle/parser/GradleSourceUtilTest.java<br>
M tests/src/test/java/org/jboss/forge/addon/gradle/projects/GradleFacetTest.java<br>
<br>
Log Message:<br>
-----------<br>
Fix GradleSourceUtil.insertTask()<br>
<br>
<br>
Commit: 71587e673afa3e89650a39530f82875934d8e132<br>
<a href="https://github.com/forge/addon-gradle/commit/71587e673afa3e89650a39530f82875934d8e132" target="_blank">https://github.com/forge/addon-gradle/commit/71587e673afa3e89650a39530f82875934d8e132</a><br>
Author: Adam Wyłuda <<a href="mailto:adamwyl92@gmail.com">adamwyl92@gmail.com</a>><br>
Date: 2013-08-08 (Thu, 08 Aug 2013)<br>
<br>
Changed paths:<br>
M impl-projects/src/main/java/org/jboss/forge/addon/gradle/projects/GradleFacetImpl.java<br>
M impl/src/main/java/org/jboss/forge/addon/gradle/parser/GradleSourceUtil.java<br>
M tests/src/test/java/org/jboss/forge/addon/gradle/projects/GradleTestProjectProvider.java<br>
M tests/src/test/resources/build.gradle<br>
<br>
Log Message:<br>
-----------<br>
Improve GradleFacet implementation and fix test (now passes all)<br>
<br>
<br>
Commit: 24cd34bf40e4aaaa4a4bad42a5acf7edee8ba62f<br>
<a href="https://github.com/forge/addon-gradle/commit/24cd34bf40e4aaaa4a4bad42a5acf7edee8ba62f" target="_blank">https://github.com/forge/addon-gradle/commit/24cd34bf40e4aaaa4a4bad42a5acf7edee8ba62f</a><br>
Author: Adam Wyłuda <<a href="mailto:adamwyl92@gmail.com">adamwyl92@gmail.com</a>><br>
Date: 2013-08-08 (Thu, 08 Aug 2013)<br>
<br>
Changed paths:<br>
M tests/src/test/java/org/jboss/forge/addon/gradle/projects/GradleTestProjectProvider.java<br>
M tests/src/test/java/org/jboss/forge/addon/gradle/projects/ProjectAssert.java<br>
<br>
Log Message:<br>
-----------<br>
Fix ProjectAssert<br>
<br>
<br>
Commit: d8a4cdd3b859ef2e59c080da1a8739a2cc2c0a03<br>
<a href="https://github.com/forge/addon-gradle/commit/d8a4cdd3b859ef2e59c080da1a8739a2cc2c0a03" target="_blank">https://github.com/forge/addon-gradle/commit/d8a4cdd3b859ef2e59c080da1a8739a2cc2c0a03</a><br>
Author: Adam Wyłuda <<a href="mailto:adamwyl92@gmail.com">adamwyl92@gmail.com</a>><br>
Date: 2013-08-08 (Thu, 08 Aug 2013)<br>
<br>
Changed paths:<br>
M impl-projects/src/main/java/org/jboss/forge/addon/gradle/projects/GradleProjectLocator.java<br>
M impl-projects/src/main/java/org/jboss/forge/addon/gradle/projects/facets/GradleResourceFacet.java<br>
M tests/src/test/java/org/jboss/forge/addon/gradle/projects/facets/GradleResourceFacetTest.java<br>
<br>
Log Message:<br>
-----------<br>
Implement GradleResourceFacet<br>
<br>
<br>
Compare: <a href="https://github.com/forge/addon-gradle/compare/1e501ac1f3f7...d8a4cdd3b859" target="_blank">https://github.com/forge/addon-gradle/compare/1e501ac1f3f7...d8a4cdd3b859</a><br>
<br>_______________________________________________<br>
forge-commits mailing list<br>
<a href="mailto:forge-commits@lists.jboss.org">forge-commits@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/forge-commits" target="_blank">https://lists.jboss.org/mailman/listinfo/forge-commits</a><br></blockquote></div>