[forge-dev] Forge build back to Stable (Hack away!)
Richard Kennard
richard at kennardconsulting.com
Mon Dec 5 16:42:59 EST 2011
Lincoln,
> You're saying that "line.separator" is not producing the proper result on Windows?
No. What Ivan is saying is that *Eclipse* is not using the proper line separator on Windows. 'output' contains '\n', not '\r\n'. I can confirm this. Maybe
Eclipse is less concerned with the underlying OS, more the encoding type of the document?
Richard.
On 6/12/2011 8:30 AM, Lincoln Baxter, III wrote:
> Hey Ivan!
>
> This is strange. You're saying that "line.separator" is not producing the proper result on Windows? This is exactly why Koen added it.
>
> ~Lincoln
>
> On Mon, Dec 5, 2011 at 4:24 PM, Ivan St. Ivanov <ivan.st.ivanov at gmail.com <mailto:ivan.st.ivanov at gmail.com>> wrote:
>
> Hi folks,
>
> Richard, thanks a lot for the hint! After downloading the latest version my source compiles.
>
> However, now I get an error in the test: JavaClassTest::testFormattingIsNotChanged. The problem is in the asserts that check whether the output
> contains Telephone + line.separator + {. The next assert, which also has the line.separator inside, fails too. I am running on Windows. And there
> line.separator is \r\n. However, in the output we get just \n. Which is fine on Mac or UNIX.
>
> If I change the asserts like this (replace line.separator with \n):
>
> assertTrue(output.contains(
> "Telephone\n{"));
> assertTrue(output.contains(
> ")\n {"));
>
> ...it works on Windows.
>
> Of course it's better to fix this in the code, but I saw that the toString method uses the stuff from Eclipse (org.eclipse.jface.text.Document,
> org.eclipse.text.edits.TextEdit, org.eclipse.jdt.core.dom.CompilationUnit). So I'm not sure whether we can do anything there. Unless some of you has
> commit permissions in Eclipse or my observations are wrong :-)
>
> What do you think?
>
> Cheers!
> Ivan
>
> P.S. If I change the test like above (with \n instead of line.separator), the maven build is successful
>
> On Sun, Dec 4, 2011 at 11:37 PM, Richard Kennard <richard at kennardconsulting.com <mailto:richard at kennardconsulting.com>> wrote:
>
> Ivan,
>
> Apologies. Forge is currently building against a Metawidget snapshot, and that snapshot is still changing. You will need to pull the latest Forge
> build in
> order to get the changes (HtmlTableLayout has become HtmlPanelGridLayout).
>
> Regards,
>
> Richard.
>
> On 5/12/2011 1:58 AM, Ivan St. Ivanov wrote:
> > Hi guys!
> >
> > I did not pull or merge anything since my last successful build (or at least I think so). And now I have a compilation problem:
> >
> > [ERROR] \projects\seamforge\core\scaffold-faces\src\main\java\org\jboss\forge\scaffold\faces\FacesScaffold.java:[87,60]
> > cannot find symbol
> > symbol : class HtmlTableLayout
> > location: package org.metawidget.statically.faces.component.html.layout
> >
> > [ERROR] \projects\seamforge\core\scaffold-faces\src\main\java\org\jboss\forge\scaffold\faces\FacesScaffold.java:[354,48]
> > cannot find symbol
> > symbol : class HtmlTableLayout
> > location: class org.jboss.forge.scaffold.faces.FacesScaffold
> >
> >
> > The HtmlTableLayout class is in the org.metawidget.statically.faces.component.html.layout package coming from the
> org.metawidget.modules/metawidget-all
> > dependency (version 1.35-SNAPSHOT). There is really no such class in the metawidget library. I went on to check the jboss maven repository. The
> class
> > HTMLTableLayout Indeed existed in older versions of the jar. However, it's not there in latest ones (those after 1st December).
> >
> > Does anybody else have the same problem?
> >
> > Thanks,
> > Ivan
> >
> > On Thu, Dec 1, 2011 at 1:06 PM, Koen Aers <koen.aers at gmail.com <mailto:koen.aers at gmail.com> <mailto:koen.aers at gmail.com
> <mailto:koen.aers at gmail.com>>> wrote:
> >
> > After fixing the failing test on XP, another problem shows up…
> >
> > The test 'ValidationFacetTest' in 'forge-javaee-impl' hangs while initializing the fixture.
> >
> > More in detail, the call 'beanManager.fireEvent(new Startup())' in the 'beforeTest()' method of the class 'SingletonAbstractShellTest.java' never
> > returns.
> >
> > I have no clue as to what might be the cause of this. Any suggestions welcome.
> >
> > Cheers,
> > Koen
> >
> > Op 1-dec.-2011, om 09:15 heeft Ivan St. Ivanov het volgende geschreven:
> >
> >> Hi,
> >>
> >> I does hang for ~5 seconds. Not sure if that is problematic. But Beta 3 has the same behavior.
> >>
> >> Once it is started I don't see any delays (created new project, setup persistence, added an entity and a field).
> >>
> >> Cheers!
> >> Ivan
> >>
> >> On Thu, Dec 1, 2011 at 1:10 AM, Richard Kennard <richard at kennardconsulting.com <mailto:richard at kennardconsulting.com>
> <mailto:richard at kennardconsulting.com <mailto:richard at kennardconsulting.com>>> wrote:
> >>
> >> But does it run okay? For me, it kept hanging at the command prompt after I typed 'bin/forge'.
> >>
> >> Richard.
> >>
> >> On 1/12/2011 10:08 AM, Ivan St. Ivanov wrote:
> >> > Maven build is successful on Windows 7 :-)
> >> >
> >> > On Wed, Nov 30, 2011 at 5:13 PM, Keith Babo <kbabo at redhat.com <mailto:kbabo at redhat.com> <mailto:kbabo at redhat.com <mailto:kbabo at redhat.com>>
> <mailto:kbabo at redhat.com <mailto:kbabo at redhat.com> <mailto:kbabo at redhat.com <mailto:kbabo at redhat.com>>>>
> >> wrote:
> >> >
> >> >
> >> > You could always spin up a job on the JBoss Jenkins server to build this on Windows for you ….
> >> >
> >> > On Nov 30, 2011, at 9:49 AM, Lincoln Baxter, III wrote:
> >> >
> >> >> Hey Koen,
> >> >>
> >> >> Could I ask you to look in to this? I am not at a place where I have access to windows, and I don't see that error on OSX.
> >> >>
> >> >> Thanks!
> >> >> ~Lincoln
> >> >>
> >> >> On Wed, Nov 30, 2011 at 7:12 AM, Koen Aers <koen.aers at gmail.com <mailto:koen.aers at gmail.com> <mailto:koen.aers at gmail.com
> <mailto:koen.aers at gmail.com>> <mailto:koen.aers at gmail.com <mailto:koen.aers at gmail.com>
> >> <mailto:koen.aers at gmail.com <mailto:koen.aers at gmail.com>>>> wrote:
> >> >>
> >> >> I was able to build, test and run without issues on OSX. On Windows (XP) the build stopped after the following failing test. I didn't
> >> >> investigate any further.
> >> >>
> >> >> Cheers,
> >> >> Koen
> >> >>
> >> >> -------------------------------------------------------------------------------
> >> >> Test set: org.jboss.forge.test.parser.java.JavaClassTest
> >> >> -------------------------------------------------------------------------------
> >> >> Tests run: 25, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.078 sec <<< FAILURE!
> >> >> testFormattingIsNotChanged(org.jboss.forge.test.parser.java.JavaClassTest) Time elapsed: 0.015 sec <<< FAILURE!
> >> >> java.lang.AssertionError:
> >> >> at org.junit.Assert.fail(Assert.java:91)
> >> >> at org.junit.Assert.assertTrue(Assert.java:43)
> >> >> at org.junit.Assert.assertTrue(Assert.java:54)
> >> >> at org.jboss.forge.test.parser.java.JavaClassTest.testFormattingIsNotChanged(JavaClassTest.java:77)
> >> >> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> >> >> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> >> >> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> >> >> at java.lang.reflect.Method.invoke(Method.java:597)
> >> >> at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
> >> >> at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
> >> >> at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
> >> >> at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
> >> >> at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
> >> >> at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:76)
> >> >> at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
> >> >> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
> >> >> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
> >> >> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
> >> >> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
> >> >> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
> >> >> at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
> >> >> at org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:59)
> >> >> at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:115)
> >> >> at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:102)
> >> >> at org.apache.maven.surefire.Surefire.run(Surefire.java:180)
> >> >> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> >> >> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> >> >> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> >> >> at java.lang.reflect.Method.invoke(Method.java:597)
> >> >> at org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:350)
> >> >> at org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1021)
> >> >>
> >> >>
> >> >>
> >> >>
> >> >>
> >> >> On Wed, Nov 30, 2011 at 11:10 AM, Richard Kennard <richard at kennardconsulting.com <mailto:richard at kennardconsulting.com>
> <mailto:richard at kennardconsulting.com <mailto:richard at kennardconsulting.com>>
> >> <mailto:richard at kennardconsulting.com <mailto:richard at kennardconsulting.com> <mailto:richard at kennardconsulting.com
> <mailto:richard at kennardconsulting.com>>>> wrote:
> >> >>
> >> >> Lincoln,
> >> >>
> >> >> The build seems to run, and there are no lingering test failures, but on Windows the distribution fails to start up? It just hangs at the
> >> >> command prompt,
> >> >> without printing 'Forge' in ASCII text or anything. It appears to be waiting for keyboard input, as if I press ENTER the cursor moves down
> >> >> once, but then
> >> >> it too stops.
> >> >>
> >> >> I have grown so used to Forge telling me I'm an idiot for running Windows, but now it won't even do that :)
> >> >>
> >> >> Regards,
> >> >>
> >> >> Richard.
> >> >>
> >> >> On 30/11/2011 9:07 PM, Max Rydahl Andersen wrote:
> >> >> > What was the problem in the end ?
> >> >> >
> >> >> > My guess was a memory leak in forge or the testsuite - did I win ?
> >> >> >
> >> >> > /max
> >> >> >
> >> >> > On Nov 29, 2011, at 22:16, Lincoln Baxter, III wrote:
> >> >> >
> >> >> >> Please feel free to run the full build on any operating system, without the aggravation of lingering test failures!
> >> >> >>
> >> >> >> --
> >> >> >> Lincoln Baxter, III
> >> >> >> http://ocpsoft.com <http://ocpsoft.com/> <http://ocpsoft.com/>
> >> >> >> http://scrumshark.com <http://scrumshark.com/> <http://scrumshark.com/>
> >> >> >> "Keep it Simple"
> >> >> >> _______________________________________________
> >> >> >> forge-dev mailing list
> >> >> >> forge-dev at lists.jboss.org <mailto:forge-dev at lists.jboss.org> <mailto:forge-dev at lists.jboss.org <mailto:forge-dev at lists.jboss.org>>
> <mailto:forge-dev at lists.jboss.org <mailto:forge-dev at lists.jboss.org> <mailto:forge-dev at lists.jboss.org <mailto:forge-dev at lists.jboss.org>>>
> >> >> >> https://lists.jboss.org/mailman/listinfo/forge-dev
> >> >> > /max
> >> >> > http://about.me/maxandersen
> >> >> >
> >> >> >
> >> >> >
> >> >> >
> >> >> > _______________________________________________
> >> >> > forge-dev mailing list
> >> >> > forge-dev at lists.jboss.org <mailto:forge-dev at lists.jboss.org> <mailto:forge-dev at lists.jboss.org <mailto:forge-dev at lists.jboss.org>>
> <mailto:forge-dev at lists.jboss.org <mailto:forge-dev at lists.jboss.org> <mailto:forge-dev at lists.jboss.org <mailto:forge-dev at lists.jboss.org>>>
> >> >> > https://lists.jboss.org/mailman/listinfo/forge-dev
> >> >> >
> >> >> >
> >> >>
> >> >> _______________________________________________
> >> >> forge-dev mailing list
> >> >> forge-dev at lists.jboss.org <mailto:forge-dev at lists.jboss.org> <mailto:forge-dev at lists.jboss.org <mailto:forge-dev at lists.jboss.org>>
> <mailto:forge-dev at lists.jboss.org <mailto:forge-dev at lists.jboss.org> <mailto:forge-dev at lists.jboss.org <mailto:forge-dev at lists.jboss.org>>>
> >> >> https://lists.jboss.org/mailman/listinfo/forge-dev
> >> >>
> >> >>
> >> >>
> >> >> _______________________________________________
> >> >> forge-dev mailing list
> >> >> forge-dev at lists.jboss.org <mailto:forge-dev at lists.jboss.org> <mailto:forge-dev at lists.jboss.org <mailto:forge-dev at lists.jboss.org>>
> <mailto:forge-dev at lists.jboss.org <mailto:forge-dev at lists.jboss.org> <mailto:forge-dev at lists.jboss.org <mailto:forge-dev at lists.jboss.org>>>
> >> >> https://lists.jboss.org/mailman/listinfo/forge-dev
> >> >>
> >> >>
> >> >>
> >> >>
> >> >> --
> >> >> Lincoln Baxter, III
> >> >> http://ocpsoft.com <http://ocpsoft.com/> <http://ocpsoft.com/>
> >> >> http://scrumshark.com <http://scrumshark.com/> <http://scrumshark.com/>
> >> >> "Keep it Simple"
> >> >> _______________________________________________
> >> >> forge-dev mailing list
> >> >> forge-dev at lists.jboss.org <mailto:forge-dev at lists.jboss.org> <mailto:forge-dev at lists.jboss.org <mailto:forge-dev at lists.jboss.org>>
> <mailto:forge-dev at lists.jboss.org <mailto:forge-dev at lists.jboss.org> <mailto:forge-dev at lists.jboss.org <mailto:forge-dev at lists.jboss.org>>>
> >> >> https://lists.jboss.org/mailman/listinfo/forge-dev
> >> >
> >> >
> >> > _______________________________________________
> >> > forge-dev mailing list
> >> > forge-dev at lists.jboss.org <mailto:forge-dev at lists.jboss.org> <mailto:forge-dev at lists.jboss.org <mailto:forge-dev at lists.jboss.org>>
> <mailto:forge-dev at lists.jboss.org <mailto:forge-dev at lists.jboss.org> <mailto:forge-dev at lists.jboss.org <mailto:forge-dev at lists.jboss.org>>>
> >> > https://lists.jboss.org/mailman/listinfo/forge-dev
> >> >
> >> >
> >> >
> >> >
> >> > _______________________________________________
> >> > forge-dev mailing list
> >> > forge-dev at lists.jboss.org <mailto:forge-dev at lists.jboss.org> <mailto:forge-dev at lists.jboss.org <mailto:forge-dev at lists.jboss.org>>
> >> > https://lists.jboss.org/mailman/listinfo/forge-dev
> >>
> >> _______________________________________________
> >> forge-dev mailing list
> >> forge-dev at lists.jboss.org <mailto:forge-dev at lists.jboss.org> <mailto:forge-dev at lists.jboss.org <mailto:forge-dev at lists.jboss.org>>
> >> https://lists.jboss.org/mailman/listinfo/forge-dev
> >>
> >>
> >> _______________________________________________
> >> forge-dev mailing list
> >> forge-dev at lists.jboss.org <mailto:forge-dev at lists.jboss.org> <mailto:forge-dev at lists.jboss.org <mailto:forge-dev at lists.jboss.org>>
> >> https://lists.jboss.org/mailman/listinfo/forge-dev
> >
> >
> > _______________________________________________
> > forge-dev mailing list
> > forge-dev at lists.jboss.org <mailto:forge-dev at lists.jboss.org> <mailto:forge-dev at lists.jboss.org <mailto:forge-dev at lists.jboss.org>>
> > https://lists.jboss.org/mailman/listinfo/forge-dev
> >
> >
> >
> >
> > _______________________________________________
> > forge-dev mailing list
> > forge-dev at lists.jboss.org <mailto:forge-dev at lists.jboss.org>
> > https://lists.jboss.org/mailman/listinfo/forge-dev
>
> _______________________________________________
> forge-dev mailing list
> forge-dev at lists.jboss.org <mailto:forge-dev at lists.jboss.org>
> https://lists.jboss.org/mailman/listinfo/forge-dev
>
>
>
> _______________________________________________
> forge-dev mailing list
> forge-dev at lists.jboss.org <mailto:forge-dev at lists.jboss.org>
> https://lists.jboss.org/mailman/listinfo/forge-dev
>
>
>
>
> --
> Lincoln Baxter, III
> http://ocpsoft.com
> http://scrumshark.com
> "Keep it Simple"
>
>
> _______________________________________________
> forge-dev mailing list
> forge-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/forge-dev
More information about the forge-dev
mailing list