[forge-dev] Forge test failures due to JavaParser Formatting

[Ivan St. Ivanov]

Hi folks,

I haven't got the chance to look at the issue, but it looks to me that the
test should be changed to support the fact that we already format our java
classes?

Cheers,
Ivan

On Wed, May 23, 2012 at 2:36 AM, Lincoln Baxter, III <
lincolnbaxter at gmail.com> wrote:

> Well, in this case I think that's acceptable because this test is not
> really intended to test brace positioning. This is to test generation
> functionality.
>
>
> On Tue, May 22, 2012 at 7:26 PM, Thomas Frühbeck <fruehbeck at aon.at> wrote:
>
>> as Lincoln already mentioned the problem is mainly a formating issue.
>> There are to sides to the problem:
>>   - pure indentation changes: \t to "  "
>>   - change in positioning of braces: Java style to C# style
>> The Code Conventions for Java Programming Language is very clear about
>> that, so this is kinda question of taste.
>>
>> One possibility would be to normalize all whitespace like
>>         content.replaceAll("(\r|\n|\\s)+"," ")
>> but then the idea of the test would become somewhat absurd, because this
>> is, what the test should test.
>> And then it would _not_ solve the braces positioning issue :-/
>>
>> Thomas
>> _______________________________________________
>> forge-dev mailing list
>> forge-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/forge-dev
>>
>
>
>
> --
> Lincoln Baxter, III
> http://ocpsoft.org
> "Simpler is better."
>
> _______________________________________________
> forge-dev mailing list
> forge-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/forge-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/forge-dev/attachments/20120523/c86a1c09/attachment.html