[forge-dev] Missing commands on shell (jpa-setup wizard)

Lincoln Baxter, III lincolnbaxter at gmail.com
Tue Dec 31 17:15:24 EST 2013


So I don't forget by the time we get back from new-years- The bug is in
ShellWizard.java:

https://issues.jboss.org/browse/FORGE-1407

   private CommandLineParser populate(ShellContext shellContext, String
line,

            final Map<String, InputComponent<?, ?>> inputs)

            throws Exception

   {

      inputs.putAll(getController().getInputs());

      CommandLineParser parser =
commandLineUtil.generateParser(getController(),
shellContext, inputs);

      CommandLine cmdLine = parser.parse(line, true);

      Map<String, InputComponent<?, ?>> populatedInputs =
commandLineUtil.populateUIInputs(cmdLine,
inputs);

      if (getController().isValid())

      {

         if (getController().canMoveToNextStep())

         {

            // The bug is here. we are immediately moving to the next step
and removing all inputs that are not populated.

            // this really needs to know if we have defaulted to next step
or actually moved there willingly

            // it should not remove old choices until a new choice has been
made

            getController().next().initialize();

            inputs.keySet().retainAll(populatedInputs.keySet());

            parser = populate(shellContext, line, inputs);

         }

      }

      return parser;

   }

-- 
Lincoln Baxter, III
http://ocpsoft.org
"Simpler is better."
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/forge-dev/attachments/20131231/a5083ffb/attachment.html 


More information about the forge-dev mailing list