Hi Jason,<br><br>Sorry to bug you here again. If you know where I can find the JLine issue tracker, could you let me know? Thanks.<br><br>Until then ;) I believe I've found a bug in JLine's handling of unsupported terminals. Currently, when reading the input stream, when EOF is encountered, JLine will return empty string "". I believe it should return null in order to maintain consistency with supported terminal handling:<br>
<br><b>The current implementation:</b><br><br> /**<br> * Read a line for unsupported terminals.<br> */<br> private String readLine(final InputStream in) throws IOException {<br> StringBuilder buff = new StringBuilder();<br>
<br> while (true) {<br> int i = in.read();<br><br> if (i == -1 || i == '\n' || i == '\r') {<br> return buff.toString();<br> }<br><br> buff.append((char) i);<br>
}<br><br> // return new BufferedReader (new InputStreamReader (in)).readLine ();<br> }<br><br><b>Should probably be updated to:</b><br><br><br><br> /**<br> * Read a line for unsupported terminals.<br>
*/<br> private String readLine(final InputStream in) throws IOException<br> {<br> StringBuilder buff = new StringBuilder();<br><br> while (true)<br> {<br> int i = in.read();<br><br> if (i == -1)<br>
{<br> return null;<br> }<br> else if (i == '\n' || i == '\r')<br> {<br> return buff.toString();<br> }<br><br> buff.append((char) i);<br>
}<br><br> // return new BufferedReader (new InputStreamReader (in)).readLine ();<br> }<br><br>Also, if performance is a reason for using the StringBuilder here, why not use a <b>static final EMPTY_STRING = "";</b> and return that?<br>
<br><b>The downstream issue, for reference:</b><br><br><a href="https://issues.jboss.org/browse/SEAMFORGE-77">https://issues.jboss.org/browse/SEAMFORGE-77</a><br clear="all"><br>
Thanks for your time.<br>
<br>-- <br>Lincoln Baxter, III<br><a href="http://ocpsoft.com">http://ocpsoft.com</a><br><a href="http://scrumshark.com">http://scrumshark.com</a><br>"Keep it Simple"<br>