I was thinking we might already be able to do that using the existing pom.xml metadata that's stored in the artifact itself, or is that too tricky?<br><br><div class="gmail_quote">On Mon, Apr 11, 2011 at 6:51 PM, Max Andersen <span dir="ltr"><<a href="mailto:manderse@redhat.com">manderse@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><div bgcolor="#FFFFFF"><div>I was thinking Plugin jar having references to dependent jars via manifest.mf<br>
<br>/max (sent from my phone)<div><br></div></div><div><div></div><div class="h5"><div><br>On 12/04/2011, at 00.39, "Lincoln Baxter, III" <<a href="mailto:lincolnbaxter@gmail.com" target="_blank">lincolnbaxter@gmail.com</a>> wrote:<br>
<br></div><div></div><blockquote type="cite"><div>Can you give an example of how you would bundle the JARs? (Just put them in /META-INF/dependencies/ ... ?) And would that not cause just as many class conflicts? If you shade/relocate then the deps *should be* completely isolated.<br>
<br><div class="gmail_quote">On Mon, Apr 11, 2011 at 4:11 PM, Max Rydahl Andersen <span dir="ltr"><<a href="mailto:max.andersen@redhat.com" target="_blank"></a><a href="mailto:max.andersen@redhat.com" target="_blank">max.andersen@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
well, recommending just bundling jars would be a better approach than shading IMO.<br>
<font color="#888888"><br>
/max<br>
</font><div><div></div><div><br>
On Apr 11, 2011, at 16:00, Lincoln Baxter, III wrote:<br>
<br>
> Yeah, shading is currently the recommended approach. Conflicts should be avoided by using relocations. I know this is... not a great method, but for now it's all we've got. Open to suggestions.<br>
><br>
> ~Lincoln<br>
><br>
> On Mon, Apr 11, 2011 at 3:41 AM, Max Rydahl Andersen <<a href="mailto:max.andersen@redhat.com" target="_blank"></a><a href="mailto:max.andersen@redhat.com" target="_blank">max.andersen@redhat.com</a>> wrote:<br>
> Heya,<br>
><br>
> Lincoln, I just saw your commits to hibernattools plugin at (<a href="https://github.com/forge/plugin-hibernate-tools/commit/8b208b4a8e79dbb8a01d10d266ee81afd2cf7106" target="_blank"></a><a href="https://github.com/forge/plugin-hibernate-tools/commit/8b208b4a8e79dbb8a01d10d266ee81afd2cf7106" target="_blank">https://github.com/forge/plugin-hibernate-tools/commit/8b208b4a8e79dbb8a01d10d266ee81afd2cf7106</a>)<br>
><br>
> Is shading of jars really the recommended approach for plugins in Forge ?<br>
><br>
> How are you going to share/avoid collisions of libraries across plugins if they need to bundle via shading ?<br>
><br>
> /max<br>
> <a href="http://about.me/maxandersen" target="_blank"></a><a href="http://about.me/maxandersen" target="_blank">http://about.me/maxandersen</a><br>
><br>
><br>
><br>
><br>
> _______________________________________________<br>
> forge-dev mailing list<br>
> <a href="mailto:forge-dev@lists.jboss.org" target="_blank"></a><a href="mailto:forge-dev@lists.jboss.org" target="_blank">forge-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/forge-dev" target="_blank"></a><a href="https://lists.jboss.org/mailman/listinfo/forge-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/forge-dev</a><br>
><br>
><br>
><br>
> --<br>
> Lincoln Baxter, III<br>
> <a href="http://ocpsoft.com" target="_blank"></a><a href="http://ocpsoft.com" target="_blank">http://ocpsoft.com</a><br>
> <a href="http://scrumshark.com" target="_blank"></a><a href="http://scrumshark.com" target="_blank">http://scrumshark.com</a><br>
> "Keep it Simple"<br>
<br>
/max<br>
<a href="http://about.me/maxandersen" target="_blank"></a><a href="http://about.me/maxandersen" target="_blank">http://about.me/maxandersen</a><br>
<br>
<br>
<br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br>Lincoln Baxter, III<br><a href="http://ocpsoft.com" target="_blank"></a><a href="http://ocpsoft.com" target="_blank">http://ocpsoft.com</a><br><a href="http://scrumshark.com" target="_blank"></a><a href="http://scrumshark.com" target="_blank">http://scrumshark.com</a><br>
"Keep it Simple"<br>
</div></blockquote></div></div></div></blockquote></div><br><br clear="all"><br>-- <br>Lincoln Baxter, III<br><a href="http://ocpsoft.com">http://ocpsoft.com</a><br><a href="http://scrumshark.com">http://scrumshark.com</a><br>
"Keep it Simple"<br>