Why don't we go ahead and prototype #3, and we'll see how it goes! If you can include some tests to demonstrate (and obviously test) the use-cases, that would be awesome!<br><br>Let me know if I can help,<br><br>~Lincoln<br>
<br><div class="gmail_quote">On Thu, Jul 7, 2011 at 10:14 AM, Ken Finnigan <span dir="ltr"><<a href="mailto:ken@kenfinnigan.me">ken@kenfinnigan.me</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
In a Maven sense I'm pretty sure they run in compile phase, though there is also a Maven plugin I've found to run annotation processors directly, so we could take either approach.<div><div></div><div class="h5"><br>
<br><br><div class="gmail_quote">
On Thu, Jul 7, 2011 at 10:08 AM, Lincoln Baxter, III <span dir="ltr"><<a href="mailto:lincolnbaxter@gmail.com" target="_blank">lincolnbaxter@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Forgive me for asking something I could easily google, but where do annotation processors fit into the development lifecycle? I admit I've never used one (that I know of.) It would probably help if I did before giving too much feedback ;)<br>
<font color="#888888">
<br>~Lincoln</font><div><div></div><div><br><br><div class="gmail_quote">On Thu, Jul 7, 2011 at 9:12 AM, Ken Finnigan <span dir="ltr"><<a href="mailto:ken@kenfinnigan.me" target="_blank">ken@kenfinnigan.me</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Ok, part way through writing this email I realized it probably makes some sense to break it down a bit more.<br><br>Now I'm thinking we need an AnnotationProcessor interface with methods like:<br><br>String getClassName()<br>
String getOptions()<br>String getSourceDirectory()<br>String getOutputDirectory()<br>List<Dependency> getDependencies()<br><br><br>Then the AnnotationProcessorFacet methods would be:<br><br>addAnnotationProcessor(AnnotationProcessor processor)<br>
removeAnnotationProcessor(AnnotationProcessor processor)<br>List<AnnotationProcessor> getAnnotationProcessors()<br>processAnnotations()<br>processAnnotation(AnnotationProcessor processor)<br><br>That's some real thinking on the fly so any other thoughts/enhancements are most welcome!<br>
<font color="#888888">
<br>Ken</font><div><div></div><div><br><br><br><div class="gmail_quote">On Wed, Jul 6, 2011 at 5:04 PM, Lincoln Baxter, III <span dir="ltr"><<a href="mailto:lincolnbaxter@gmail.com" target="_blank">lincolnbaxter@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hmm,<br><br>Good questions. I think #2 would probably be the easiest, but we could offer #1 as an alternative for those who don't want to use the maven build plugin.<br><br>I think #3 would probably be the most robust for future use. What kinds of methods are you thinking of including for the facet?<br>
<br>~Lincoln<div><div></div><div><br><br><div class="gmail_quote">On Sun, Jul 3, 2011 at 3:41 PM, Ken Finnigan <span dir="ltr"><<a href="mailto:ken@kenfinnigan.me" target="_blank">ken@kenfinnigan.me</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hey Lincoln,<br><br>Have been working on adding JPA model generation to the persistence plugin over the last few days and have been mulling over the best way to implement it and wanted to get your thoughts.<br><br>I see that there are a few possibilities:<br>
<br>1) Call the NativeMethodExec utility to call javac for running annotation processing only.<br>2) Add an annotation processing profile to the pom as part of the install of the plugin (if they select they want model gen), and then performing the model gen would execute the maven to process and generate annotations<br>
3) An extension of 2 would be to make an AnnotationProcessorFacet, and then do 2 as a Maven implementation of that facet.<br><br>After thinking about it today I think 3 seems the most flexible, but wanted to get your thoughts.<br>
<br>Thanks<br><font color="#888888">Ken<br>
</font></blockquote></div><br><br clear="all"><br></div></div><font color="#888888">-- <br>Lincoln Baxter, III<br><a href="http://ocpsoft.com" target="_blank">http://ocpsoft.com</a><br><a href="http://scrumshark.com" target="_blank">http://scrumshark.com</a><br>
"Keep it Simple"<br>
</font></blockquote></div><br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br>Lincoln Baxter, III<br><a href="http://ocpsoft.com" target="_blank">http://ocpsoft.com</a><br><a href="http://scrumshark.com" target="_blank">http://scrumshark.com</a><br>
"Keep it Simple"<br>
</div></div></blockquote></div><br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br>Lincoln Baxter, III<br><a href="http://ocpsoft.com">http://ocpsoft.com</a><br><a href="http://scrumshark.com">http://scrumshark.com</a><br>"Keep it Simple"<br>