To clarify what I meant about using both modules as optional dependencies, Koen's module should do something like this:<br><br><dependencies><br> <module name="org.jboss.forge.shell.api" optional="true" /><br>
<module name="org.jboss.forge.shell-api" optional="true" /><br></dependencies><br><br><div class="gmail_quote">On Thu, Oct 20, 2011 at 11:06 AM, Lincoln Baxter, III <span dir="ltr"><<a href="mailto:lincolnbaxter@gmail.com">lincolnbaxter@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">The only reason I can see this affecting Koen is if he (in his tools module) referenced the "org.jboss.forge.shell-api" module directly, which has been moved to "org.jboss.forge.shell.api" Or if there are classes that he referenced that were available because of modularity errors, but now are not. What I would do in this case, however, is simply make both modules optional="true", which should prevent any breakage, then whichever is available will be used. If neither are available, it wasn't going to work anyway ;)<br>
<br>I would try to make these changes for M4 even if you don't use the new SNAPSHOT version of Forge - sorry guys. I did not know :( Mailing list I should join?<br><br>Nothing has changed with regard to how plugins are installed, but what *has* changed is what happens to plugins *when* they are installed - again, just to enable the proper modularity. But this should not be visible to the end user (or Tools.)<br>
<font color="#888888">
<br>~Lincoln</font><div><div></div><div class="h5"><br><br><div class="gmail_quote">On Thu, Oct 20, 2011 at 9:40 AM, Max Rydahl Andersen <span dir="ltr"><<a href="mailto:max.andersen@redhat.com" target="_blank">max.andersen@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
just on the day of jboss tools M4 code freeze…..doh ;)<br>
<br>
will this affect us Koen or are we for M4 "saved" by us bundling Forge ?<br>
<br>
…and will this affect plugin installation ?<br>
<br>
/max<br>
<div><div></div><div><br>
On Oct 20, 2011, at 09:13, Lincoln Baxter, III wrote:<br>
<br>
> I've had to make some changes to the Forge modules structure. I'm not sure how this will affect what's been done in Tools so far, but... this structure will help us keep modularity in the future. The previous module structure was not scalable and was causing plugin classloader leaks.<br>
><br>
> We can work out any issues, but hopefully there shouldn't be any :)<br>
><br>
> Thanks,<br>
><br>
> --<br>
> Lincoln Baxter, III<br>
> <a href="http://ocpsoft.com" target="_blank">http://ocpsoft.com</a><br>
> <a href="http://scrumshark.com" target="_blank">http://scrumshark.com</a><br>
> "Keep it Simple"<br>
</div></div>> _______________________________________________<br>
> forge-dev mailing list<br>
> <a href="mailto:forge-dev@lists.jboss.org" target="_blank">forge-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/forge-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/forge-dev</a><br>
<br>
/max<br>
<a href="http://about.me/maxandersen" target="_blank">http://about.me/maxandersen</a><br>
<br>
<br>
<br>
<br>
_______________________________________________<br>
forge-dev mailing list<br>
<a href="mailto:forge-dev@lists.jboss.org" target="_blank">forge-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/forge-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/forge-dev</a><br>
</blockquote></div><br><br clear="all"><br>-- <br>Lincoln Baxter, III<br><a href="http://ocpsoft.com" target="_blank">http://ocpsoft.com</a><br><a href="http://scrumshark.com" target="_blank">http://scrumshark.com</a><br>
"Keep it Simple"<br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br>Lincoln Baxter, III<br><a href="http://ocpsoft.com">http://ocpsoft.com</a><br><a href="http://scrumshark.com">http://scrumshark.com</a><br>"Keep it Simple"<br>