Hi Lincoln,<div><br></div><div>Well, I'm not sure how I achieved it, but you are right! :-)</div><div><br></div><div>I'm doing great these days! Getting more and more familiar with Forge ;-)</div><div><br></div><div>
Cheers!</div><div>Ivan</div><div><br><div class="gmail_quote">On Mon, Dec 5, 2011 at 11:19 PM, Lincoln Baxter, III <span dir="ltr"><<a href="mailto:lincolnbaxter@gmail.com">lincolnbaxter@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">Hey Ivan!<div class="im"><br><br><blockquote style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote">
That is, it returned me something like org.jboss.forge.shell and not com.test (or whatever I passed on the command line).<br>
</blockquote><br></div>This sounds wrong. Could you create a test-case that demonstrates this? I don't seem to have this issue on my machine.<br><br>How's everything going?<span class="HOEnZb"><font color="#888888"><br>
~Lincoln</font></span><div class="HOEnZb"><div class="h5"><br><br><div class="gmail_quote">On Sun, Dec 4, 2011 at 2:49 AM, Ivan St. Ivanov <span dir="ltr"><<a href="mailto:ivan.st.ivanov@gmail.com" target="_blank">ivan.st.ivanov@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi there! :-)<div><br></div><div>Thanks to all of you for the feedback! I'll first look at what Lincoln proposed (the new properties API).</div>
<div><br></div><div><b>@Dan</b>: I tried using the getBasePackage method, but it appears that it returns the base package of the plugin from which it is called. That is, it returned me something like org.jboss.forge.shell and not com.test (or whatever I passed on the command line).</div>
<div><br></div><div><b>@Paul</b>: After I got more into the API, I agree with you. Most of the methods in the Facet interfaces are rather "passive" - they contain contextual information used later by the plugins. At least this is how I got it. So you are right, the facet seems not to be the correct place for this implementation.</div>
<div><br></div><div>Cheers!<span><font color="#888888"><br>Ivan</font></span><div><div><br><div><br><div class="gmail_quote">On Sun, Dec 4, 2011 at 1:22 AM, Paul Bakker <span dir="ltr"><<a href="mailto:paul.bakker.nl@gmail.com" target="_blank">paul.bakker.nl@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">I agree that it's not necessarily bad to create empty directories in this case, because than it's also available in the IDE. And because it's the base package it makes sense to put code there too, I don't think it is a broken window in this specific case.<div>
<br></div><div>I don't think it's necessary to add a new method to the JavaSourceFacet. It's something that only the NewProjectPlugin will use, while the JavaSourceFacet is very general (many plugins use this facet). Just create the directory in the NewProjectPlugin itself. Prompting the user for this first would be a good idea too :-)</div>
<span><font color="#888888"><div><br></div><div>Paul</div></font></span><div><br><div><br><div><br><div><div><div><div>On Dec 4, 2011, at 12:11 AM, Dan Allen wrote:</div><br></div></div><blockquote type="cite">
<div><div>On Sat, Dec 3, 2011 at 05:01, Max Rydahl Andersen <span dir="ltr"><<a href="mailto:max.andersen@redhat.com" target="_blank">max.andersen@redhat.com</a>></span> wrote:<br><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
So you are saying if I type in x.y.z as package name you will create the empty sequence of directories:<br>
<br>
<src>/x/y/z ?<br>
<br>
If that is the case then I don't see the need for it before there actually is a file to put in there…?<br>
<br>
Empty directories is a broken window.<br>
<br>
What would be more fun is that forge would actually remember the last package name used for a command so<br>
it would offer it as default (Lincoln - did you get that properties/config stuff in place ? :)<br></blockquote><div><br></div><div>There is a mechanism for this. I'm using it in the Arquillian Extensions plugin.</div>
<div><br></div><div>JavaSourceFacet#getBasePackage()</div><div><br></div><div>That's the one that was entered at the prompt...at least it appears that way.</div><div><br></div><div>I don't think that creating the directories is necessarily wrong. If they open the project in the IDE immediately after creating it, then the first time they create a class it's necessary to retype the package name. It's far easier to right click on an existing package structure and create a new class.</div>
<div><br></div><div>Perhaps the user can be prompted for this option (or it can be an optional option).</div><div><br></div><div>new-project --named myproject --topLevelPackage org.example.myproject --createPackages</div>
<div><br></div><div>-Dan</div></div><div><br></div>-- <br><div>Dan Allen</div>Principal Software Engineer, Red Hat | Author of Seam in Action<br>Registered Linux User #231597<br><br><div><a href="http://www.google.com/profiles/dan.j.allen#about" target="_blank">http://www.google.com/profiles/dan.j.allen#about</a><br>
<a href="http://mojavelinux.com/" target="_blank">http://mojavelinux.com</a><br><a href="http://mojavelinux.com/seaminaction" target="_blank">http://mojavelinux.com/seaminaction</a><br></div><br></div></div><div>
_______________________________________________<br>forge-dev mailing list<br><a href="mailto:forge-dev@lists.jboss.org" target="_blank">forge-dev@lists.jboss.org</a><br><a href="https://lists.jboss.org/mailman/listinfo/forge-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/forge-dev</a><br>
</div></blockquote></div><br></div></div></div></div><br>_______________________________________________<br>
forge-dev mailing list<br>
<a href="mailto:forge-dev@lists.jboss.org" target="_blank">forge-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/forge-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/forge-dev</a><br>
<br></blockquote></div><br></div></div></div></div>
<br>_______________________________________________<br>
forge-dev mailing list<br>
<a href="mailto:forge-dev@lists.jboss.org" target="_blank">forge-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/forge-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/forge-dev</a><br>
<br></blockquote></div><br><br clear="all"><br></div></div><div class="HOEnZb"><div class="h5">-- <br>Lincoln Baxter, III<br><a href="http://ocpsoft.com" target="_blank">http://ocpsoft.com</a><br><a href="http://scrumshark.com" target="_blank">http://scrumshark.com</a><br>
"Keep it Simple"<br>
</div></div><br>_______________________________________________<br>
forge-dev mailing list<br>
<a href="mailto:forge-dev@lists.jboss.org">forge-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/forge-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/forge-dev</a><br>
<br></blockquote></div><br></div>