Yep! Glad to be back, though :)<br><br>I think it might be a good idea to watch the performance of this operation, though. It could get expensive for large projects, so it might be a good idea to only do this check when necessary, and store the result in forge project scoped config. We are becoming an IDE :)<br>
<br>Will be complicated I think, or slow...<br><br>~Lincoln<br><br><div class="gmail_quote">On Mon, Feb 27, 2012 at 11:14 AM, Paul Bakker <span dir="ltr"><<a href="mailto:paul.bakker@luminis.eu">paul.bakker@luminis.eu</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word">
<div>Hi! Had a good time? </div>
<div>The new API looks really good to use here, didn't know we could do that… I wasn't too happy with using configuration for this, because it will break on refactoring, so it's much better is we can do it this way. I will look into it to use it.</div>
<div><br>
</div>
<div>Paul</div>
<div><br>
</div>
<div><br>
</div>
<br>
<div><div><div class="h5">
<div>On Feb 27, 2012, at 17:09 , Lincoln Baxter, III wrote:</div>
<br>
</div></div><blockquote type="cite"><div><div class="h5">Hey Paul! <br>
<br>
Back from Vaca.<br>
<br>
My first thought here is that this is excellent use of the Configuration API, but I think currently the way this is written, it depends on the Configuration in order to recognize the fact that there is an application class serving as a REST activator?<br>
<br>
We could use the JavaParser TreeVisiting API that was just introduced, in order to search project sources and make this determination.<br>
<br>
<a href="https://github.com/forge/core/blob/master/shell-api/src/main/java/org/jboss/forge/project/facets/JavaSourceFacet.java#L165" target="_blank">https://github.com/forge/core/blob/master/shell-api/src/main/java/org/jboss/forge/project/facets/JavaSourceFacet.java#L165</a><br>
<br>
Thoughts?<br>
~Lincoln<br>
<br>
<div class="gmail_quote">On Wed, Feb 15, 2012 at 5:48 PM, Paul Bakker <span dir="ltr">
<<a href="mailto:paul.bakker@luminis.eu" target="_blank">paul.bakker@luminis.eu</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi Lincoln,<br>
<br>
I made some progress on refactoring the rest stuff, plus I added the option to use an Application class instead of web.xml. Because it changed quite a lot and this is the first time we use the idea of having "nested" facets it would probably be good if you
review before I merge to master.<br>
<br>
<a href="https://github.com/forge/core/commit/ec0275a821c6bb3ccf690b55d66816073ba0c328" target="_blank">https://github.com/forge/core/commit/ec0275a821c6bb3ccf690b55d66816073ba0c328</a><br>
<br>
Let me know what you think :-)<br>
<span><font color="#888888"><br>
Paul<br>
</font></span></blockquote>
</div>
<br>
<br clear="all">
<br>
-- <br>
Lincoln Baxter, III<br>
<a href="http://ocpsoft.com/" target="_blank">http://ocpsoft.com</a><br>
<a href="http://scrumshark.com/" target="_blank">http://scrumshark.com</a><br>
"Keep it Simple"<br></div></div>
_______________________________________________<br>
forge-dev mailing list<br>
<a href="mailto:forge-dev@lists.jboss.org" target="_blank">forge-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/forge-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/forge-dev</a><br>
</blockquote>
</div>
<br>
</div>
<br>_______________________________________________<br>
forge-dev mailing list<br>
<a href="mailto:forge-dev@lists.jboss.org">forge-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/forge-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/forge-dev</a><br>
<br></blockquote></div><br><br clear="all"><br>-- <br>Lincoln Baxter, III<br><a href="http://ocpsoft.com">http://ocpsoft.com</a><br><a href="http://scrumshark.com">http://scrumshark.com</a><br>"Keep it Simple"<br>