Hi Jevgeni,<br><br>Thanks for letting me know about your vacation. Have fun! I've copied the dev list, because this should be discussed openly among all the community :)<br><br>Answers in line:<br><br><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
What methods should the GitFacet implement (or at least provide stubs for)<br>
for the FORGE-183 to get accepted? </blockquote><div><br>I'll answer this with another question: "what is the minimal set of Git operations that will make it useful?" We can always expand later. So I'd suggest starting with the bare minimum.<br>
<br></div><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Should GitUtils be a part of FORGE-183 as well?<br></blockquote><div><br>Not sure what you mean? If you need to make changes to GitUtils to implement FORGE-183, then sure, that's fine. <br>
<br></div><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">What methods should I add in there (everything from
Git)? </blockquote><div><br>Start with the basics. I recommend starting with what you think is necessary to implement the UNDO features :)<br> </div><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
In the mailing list I identified 5 methods. Can I use GitUtils class which is already present in the project? (<br>
<a href="https://github.com/forge/core/blob/master/git-tools/src/main/java/org/jboss/forge/git/GitUtils.java" target="_blank">https://github.com/forge/core/blob/master/git-tools/src/main/java/org/jboss/forge/git/GitUtils.java</a><br>
) </blockquote><div> <br>Yes, that would be my suggestion.<br><br></div><blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">If I add all the methods needed for the undo plugin (about 15),<br>
wouldn't it be a pretty big commit for a single JIRA issue?<br></blockquote><div><br>Size of commit is not really important as long as the JIRA issue is clear. If you think the Issue is too vague, then feel free to split it into several issues. Do you have permissions to edit and create JIRA issues? If not, let me know and I will grant it to you. <br>
<br>Thanks~! Good questions! Always ask :)<br>Lincoln<br></div></div>