Hey Jevgeni,<br><br>I'm copying the dev list because this is a public question. (Please try to do this on all communications unless it is something private :) That way we can all help and discuss.<br><br>So, really FORGE-183 is open-ended, but in general it's meant to allow projects to know when they contain a Git repository. You will need this feature for the Git undo plugin.<br>
<br>My recommendation is to implement GitFacet in such a way that it will be "installed" or "registered" if the project contains, or exists in, a git repository. Then once you have done that, I'd start working on the UndoPlugin and UndoFacet. You will quickly discover which other methods the GitFacet needs to contain, and we can discuss on the dev list in order to make sure the design is as good as we can get it.<br>
<br>Sound good?<br>~Lincoln<br><br><div class="gmail_quote">On Thu, May 17, 2012 at 11:24 AM, Jevgeni Zelenkov <span dir="ltr"><<a href="mailto:jevgeni.zelenkov@googlemail.com" target="_blank">jevgeni.zelenkov@googlemail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Lincoln,<br>
<br>
I was unable to finish with the FORGE-183 issue. I don't have a clear<br>
idea of what exacly needs to be done. GitPlugin, GitFacet and GitUtils<br>
classes are already present. Should I make sure, that GitPlugin only<br>
calls GitFacet or GitUtils methods and that GitUtils never returns<br>
jGit-related classes?<br>
It feels like I should not submit any concrete undo-plugin related<br>
method implementations as a part of FORGE-183. That should be a<br>
different issue.<br>
Is it even the right thing to do, to concentrate on FORGE-183 so much?<br>
Should I just start coding features and deal with FORGE-183 later?<br>
(FORGE-183 looks like refactoring to me now)<br>
<br>
<br>
Best regards,<br>
Jevgeni<br>
<div class="HOEnZb"><div class="h5"><br>
On 5/16/12, Lincoln Baxter, III <<a href="mailto:lincolnbaxter@gmail.com">lincolnbaxter@gmail.com</a>> wrote:<br>
> Hi Jevgeni,<br>
><br>
> Just checking in to see how your vacation was :) Are you ready to get<br>
> started on your super Git undo plugin? :)<br>
><br>
> --<br>
> Lincoln Baxter, III<br>
> <a href="http://ocpsoft.org" target="_blank">http://ocpsoft.org</a><br>
> "Simpler is better."<br>
><br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br>Lincoln Baxter, III<br><a href="http://ocpsoft.org" target="_blank">http://ocpsoft.org</a><br>"Simpler is better."<br>