Hi folks,<div><br></div><div>I haven't got the chance to look at the issue, but it looks to me that the test should be changed to support the fact that we already format our java classes?</div><div><br></div><div>Cheers,</div>
<div>Ivan<br><br><div class="gmail_quote">On Wed, May 23, 2012 at 2:36 AM, Lincoln Baxter, III <span dir="ltr"><<a href="mailto:lincolnbaxter@gmail.com" target="_blank">lincolnbaxter@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Well, in this case I think that's acceptable because this test is not really intended to test brace positioning. This is to test generation functionality.<div class="HOEnZb">
<div class="h5"><br><br><div class="gmail_quote">On Tue, May 22, 2012 at 7:26 PM, Thomas Frühbeck <span dir="ltr"><<a href="mailto:fruehbeck@aon.at" target="_blank">fruehbeck@aon.at</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">as Lincoln already mentioned the problem is mainly a formating issue.<br>
There are to sides to the problem:<br>
- pure indentation changes: \t to " "<br>
- change in positioning of braces: Java style to C# style<br>
The Code Conventions for Java Programming Language is very clear about<br>
that, so this is kinda question of taste.<br>
<br>
One possibility would be to normalize all whitespace like<br>
content.replaceAll("(\r|\n|\\s)+"," ")<br>
but then the idea of the test would become somewhat absurd, because this<br>
is, what the test should test.<br>
And then it would _not_ solve the braces positioning issue :-/<br>
<br>
Thomas<br>
_______________________________________________<br>
forge-dev mailing list<br>
<a href="mailto:forge-dev@lists.jboss.org" target="_blank">forge-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/forge-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/forge-dev</a><br>
</blockquote></div><br><br clear="all"><br></div></div><div class="HOEnZb"><div class="h5">-- <br>Lincoln Baxter, III<br><a href="http://ocpsoft.org" target="_blank">http://ocpsoft.org</a><br>"Simpler is better."<br>
</div></div><br>_______________________________________________<br>
forge-dev mailing list<br>
<a href="mailto:forge-dev@lists.jboss.org">forge-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/forge-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/forge-dev</a><br>
<br></blockquote></div><br></div>