Yes, please upload it :) You don't need to worry, we aren't mean, and you write really nice code.<br>Also... it won't be in the repository until we add it there, but more people will see it and be able to review.<br>
<br>I'm not exactly sure what the problem is, so I'd like to try it myself!<br><br>Thanks!<br>~Lincoln<br><br><div class="gmail_quote">On Thu, Jun 28, 2012 at 2:18 PM, Jevgeni Zelenkov <span dir="ltr"><<a href="mailto:jevgeni.zelenkov@gmail.com" target="_blank">jevgeni.zelenkov@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Ryan and Lincoln,<br>
<br>
Thanks for your feedback. I tried a number of different package<br>
combinations, including 'org.jboss.undo.forge.UndoFacet' but I still<br>
get the same error.<br>
<br>
Lincoln, the plugin is pretty much untested so I don't feel<br>
comfortable uploading potentially broken plugin (even as an<br>
intermediate commit). If you really think it's OK, I'll do it. Also, I<br>
will have to upload my changes to forge-git-tools.<br>
<br>
Cheers,<br>
Jevgeni<br>
<div class="HOEnZb"><div class="h5"><br>
<br>
On Thu, Jun 28, 2012 at 6:22 PM, Ryan Bradley <<a href="mailto:rbradley@redhat.com">rbradley@redhat.com</a>> wrote:<br>
> Jevgeni,<br>
><br>
> I'm not sure if this is the same problem that you have, but a while ago<br>
> I had some problems regarding facets being loaded.<br>
><br>
> I assume that your UndoFacet (interface and implementation) are in the<br>
> same project that you are executing 'forge source plugin' on, if they<br>
> aren't, then they should be (or you will need to run 'mvn clean install'<br>
> to add those JARs to your local Maven repo).<br>
><br>
> As well, I had problems using the group ID 'org.jboss.forge'. Any<br>
> dependencies in my plugin with this group ID were assumed to be part of<br>
> the core, and Forge would mark these as scope provided and cause some<br>
> problems.<br>
><br>
> Once again, I don't think these problems should occur if UndoFacet and<br>
> its implementation are in the same project as UndoPlugin, but just an<br>
> idea of something to look for.<br>
><br>
> Cheers,<br>
> Ryan<br>
><br>
> On 06/28/2012 12:01 PM, Jevgeni Zelenkov wrote:<br>
>> Hi guys,<br>
>><br>
>> I am trying to test the undo plugin on a working forge instance but I<br>
>> am getting a strange error.<br>
>><br>
>> As described here:<br>
>> <a href="https://docs.jboss.org/author/display/FORGE/Make+your+Plugin+available+to+Forge" target="_blank">https://docs.jboss.org/author/display/FORGE/Make+your+Plugin+available+to+Forge</a><br>
>> I have added the undo-plugin using 'forge source-plugin' command. It<br>
>> was added successfully, I can even see undo-plugin commands when I<br>
>> call 'list-commands'.<br>
>><br>
>> But when I execute 'undo setup' command (should simply install the<br>
>> plugin), I get the following exception:<br>
>><br>
>> The requested Facet of type [org.jboss.forge.undo.UndoFacet] could not<br>
>> be loaded.<br>
>><br>
>> UndoFacet class is located in the same package as the UndoPlugin class<br>
>> (org.jboss.forge.undo). I also tried moving both classes into<br>
>> "org.jboss.forge" but that didn't help either.<br>
>><br>
>> Does anybody have any ideas what could it be?<br>
>><br>
>> Best Regards,<br>
>> Jevgeni<br>
>> _______________________________________________<br>
>> forge-dev mailing list<br>
>> <a href="mailto:forge-dev@lists.jboss.org">forge-dev@lists.jboss.org</a><br>
>> <a href="https://lists.jboss.org/mailman/listinfo/forge-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/forge-dev</a><br>
> _______________________________________________<br>
> forge-dev mailing list<br>
> <a href="mailto:forge-dev@lists.jboss.org">forge-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/forge-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/forge-dev</a><br>
<br>
<br>
</div></div><div class="im HOEnZb">On Thu, Jun 28, 2012 at 6:08 PM, Lincoln Baxter, III<br>
<<a href="mailto:lincolnbaxter@gmail.com">lincolnbaxter@gmail.com</a>> wrote:<br>
> Hey Jevgeni,<br>
><br>
> I'm not sure how you have your plugin project set up (I can't find your<br>
> repository, could you move it to here?<br>
> <a href="https://github.com/forge/plugin-undo" target="_blank">https://github.com/forge/plugin-undo</a>), but you can't use "org.jboss.forge"<br>
> as a package name.<br>
><br>
> You should use something like, "org.jboss.undo.forge" (I think that should<br>
> work.) We can work out a better package name later, but for right now, it<br>
> doesn't really matter.<br>
><br>
> That might resolve your problem :) Let me know!<br>
> ~Lincoln<br>
><br>
</div><div class="im HOEnZb">> On Thu, Jun 28, 2012 at 12:01 PM, Jevgeni Zelenkov<br>
> <<a href="mailto:jevgeni.zelenkov@gmail.com">jevgeni.zelenkov@gmail.com</a>> wrote:<br>
>><br>
>> Hi guys,<br>
>><br>
>> I am trying to test the undo plugin on a working forge instance but I<br>
>> am getting a strange error.<br>
>><br>
>> As described here:<br>
>><br>
>> <a href="https://docs.jboss.org/author/display/FORGE/Make+your+Plugin+available+to+Forge" target="_blank">https://docs.jboss.org/author/display/FORGE/Make+your+Plugin+available+to+Forge</a><br>
>> I have added the undo-plugin using 'forge source-plugin' command. It<br>
>> was added successfully, I can even see undo-plugin commands when I<br>
>> call 'list-commands'.<br>
>><br>
>> But when I execute 'undo setup' command (should simply install the<br>
>> plugin), I get the following exception:<br>
>><br>
>> The requested Facet of type [org.jboss.forge.undo.UndoFacet] could not<br>
>> be loaded.<br>
>><br>
>> UndoFacet class is located in the same package as the UndoPlugin class<br>
>> (org.jboss.forge.undo). I also tried moving both classes into<br>
>> "org.jboss.forge" but that didn't help either.<br>
>><br>
>> Does anybody have any ideas what could it be?<br>
>><br>
>> Best Regards,<br>
>> Jevgeni<br>
>> _______________________________________________<br>
>> forge-dev mailing list<br>
>> <a href="mailto:forge-dev@lists.jboss.org">forge-dev@lists.jboss.org</a><br>
>> <a href="https://lists.jboss.org/mailman/listinfo/forge-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/forge-dev</a><br>
><br>
><br>
><br>
><br>
</div><div class="im HOEnZb">> --<br>
> Lincoln Baxter, III<br>
> <a href="http://ocpsoft.org" target="_blank">http://ocpsoft.org</a><br>
> "Simpler is better."<br>
><br>
</div><div class="HOEnZb"><div class="h5">> _______________________________________________<br>
> forge-dev mailing list<br>
> <a href="mailto:forge-dev@lists.jboss.org">forge-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/forge-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/forge-dev</a><br>
><br>
<br>
_______________________________________________<br>
forge-dev mailing list<br>
<a href="mailto:forge-dev@lists.jboss.org">forge-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/forge-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/forge-dev</a><br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br>Lincoln Baxter, III<br><a href="http://ocpsoft.org" target="_blank">http://ocpsoft.org</a><br>"Simpler is better."<br>