<html><head></head><body bgcolor="#FFFFFF"><div>Hi fiorenzo,</div><div><br></div><div>You may want to create a different branch for each issue. This is how we do, so you will be able to submit a pull request per branch.<br><br>Em 16/08/2012, às 21:01, JFlower &lt;<a href="mailto:fiorenzino@gmail.com">fiorenzino@gmail.com</a>&gt; escreveu:<br><br></div><div></div><blockquote type="cite"><div>Hi,<div><br></div><div>i created&nbsp;<a href="https://issues.jboss.org/browse/FORGE-655">https://issues.jboss.org/browse/FORGE-655</a>.</div><div>I created my branch [<a href="https://github.com/fiorenzino/core/tree/FORGE-655">https://github.com/fiorenzino/core/tree/FORGE-655</a>] and committed my simple changes,&nbsp;</div>
<div>but&nbsp;i added also my starting code for&nbsp;<a href="https://issues.jboss.org/browse/FORGE-610">https://issues.jboss.org/browse/FORGE-610</a></div><div><br></div><div>i think i should revert my changes for FORGE-610, branch from origin, and finally add my changes and commit...</div>
<div><br></div><div>but i don't know how... [perhaps using git rebase..]</div><div><br></div><div>...ops...</div><div><br></div><div>fiorenzo</div><div><br></div><div><br><br><div class="gmail_quote">2012/8/17 JFlower <span dir="ltr">&lt;<a href="mailto:fiorenzino@gmail.com" target="_blank">fiorenzino@gmail.com</a>&gt;</span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi George,<div><br></div><div>i will try..&nbsp;</div><div>i'm a beginner git user..</div><div><br></div><div>Fiorenzo</div>
<div class="HOEnZb"><div class="h5"><div><br><br><div class="gmail_quote">2012/8/17 George Gastaldi <span dir="ltr">&lt;<a href="mailto:ggastald@redhat.com" target="_blank">ggastald@redhat.com</a>&gt;</span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div bgcolor="#FFFFFF"><div>Awesome ! Can you create a pull request with that ?</div><div><br></div><div>Thanks<br><br>

Em 16/08/2012, às 19:31, JFlower &lt;<a href="mailto:fiorenzino@gmail.com" target="_blank">fiorenzino@gmail.com</a>&gt; escreveu:<br><br></div><div><div><div></div><blockquote type="cite"><div>Another stupid thing,<div>
<br></div><div>&nbsp;in the resource folder the image&nbsp;jboss-community.png doesn't exist (it's used in the error page:</div><div>&nbsp;<a href="https://github.com/forge/core/blob/master/scaffold-faces/src/main/resources/scaffold/faces/error.xhtml" target="_blank">https://github.com/forge/core/blob/master/scaffold-faces/src/main/resources/scaffold/faces/error.xhtml</a>)</div>


<div><br></div><div>fiorenzo</div><div><br><div class="gmail_quote">2012/8/17 JFlower <span dir="ltr">&lt;<a href="mailto:fiorenzino@gmail.com" target="_blank">fiorenzino@gmail.com</a>&gt;</span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">


<div>Hi,</div><div><br></div><div>i would suggest 2 thinks to improve the scaffold from entities.</div><div><br></div><div>With forge 1.0.6, the project generated usign scaffold from-entity have wrong link in the nav bar for the principal link (with brand class).</div>



<div>In my case, i created a "flower" app and the html div is:</div><div><br></div><div>&lt;div class="navbar navbar-fixed-top"&gt;</div><div><span style="white-space:pre-wrap">                </span>&lt;div class="navbar-inner"&gt;</div>



<div><span style="white-space:pre-wrap">                        </span>&lt;div class="container"&gt;</div><div><span style="white-space:pre-wrap">                                </span>&lt;a href="/index.xhtml" class="brand"&gt;Flower&lt;/a&gt;</div>



<div><span style="white-space:pre-wrap">                                </span>&lt;div class="nav-collapse collapse"&gt;</div><div><span style="white-space:pre-wrap">                                        </span>&lt;ul class="nav"&gt;</div>
<div><span style="white-space:pre-wrap">                                                </span>&lt;li&gt;&lt;a href="<a href="http://forge.jboss.org/docs/important_plugins/ui-scaffolding.html" target="_blank">http://forge.jboss.org/docs/important_plugins/ui-scaffolding.html</a>"&gt;How to Customize&lt;/a&gt;&lt;/li&gt;</div>



<div><span style="white-space:pre-wrap">                                        </span>&lt;/ul&gt;</div><div><span style="white-space:pre-wrap">                                </span>&lt;/div&gt;</div><div><span style="white-space:pre-wrap">                        </span>&lt;/div&gt;</div>
<div><span style="white-space:pre-wrap">                </span>&lt;/div&gt;</div><div>&lt;/div&gt;</div><div><br></div><div>In pageTemplate (<a href="https://github.com/forge/core/blob/master/scaffold-faces/src/main/resources/scaffold/faces/pageTemplate.xhtml" target="_blank">https://github.com/forge/core/blob/master/scaffold-faces/src/main/resources/scaffold/faces/pageTemplate.xhtml</a>) the link should be:</div>



<div><br></div><div>&lt;h:link &nbsp;id="brandLink" outcome="@{targetDir}/index.xhtml" styleClass="brand"&gt; &lt;h:outputText value="@{appName}" /&gt;&lt;/h:link&gt;</div><div>in place of:</div>



<div>&lt;a href="@{targetDir}/index.xhtml" class="brand"&gt;@{appName}&lt;/a&gt;</div><div><br></div><div>[to avoid a wrong redirect to <a href="http://localhost:8080/index.xhtml" target="_blank">http://localhost:8080/index.xhtml</a>]</div>



<div><br></div><div>And to eliminate the annoying log jboss server log:</div><div>23:59:54,914 AVVERTENZA [javax.enterprise.resource.webcontainer.jsf.context] (http--127.0.0.1-8080-1) JSF1091: No mime type could be found for file favicon.ico. &nbsp;To resolve this, add a mime-type mapping to the applications web.xml</div>



<div><br></div><div>you should add on web.xml:</div><div><br></div><div>&nbsp; &nbsp;&lt;mime-mapping&gt;</div><div>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&lt;extension&gt;ico&lt;/extension&gt;</div><div>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&lt;mime-type&gt;image/x-icon&lt;/mime-type&gt;</div>



<div>&nbsp; &nbsp; &nbsp;&lt;/mime-mapping&gt;</div><div><br></div><div><br></div><div>Best regards</div><div><br></div><div>fiorenzo</div><div><p></p><p style="margin:0pt;padding:0pt;color:rgb(51,51,51);font-family:arial,helvetica,sans-serif;font-size:13.600000381469727px">



</p></div>
</blockquote></div><br></div>
</div></blockquote></div></div><blockquote type="cite"><div><span>_______________________________________________</span><br><span>forge-dev mailing list</span><br><span><a href="mailto:forge-dev@lists.jboss.org" target="_blank">forge-dev@lists.jboss.org</a></span><br>

<span><a href="https://lists.jboss.org/mailman/listinfo/forge-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/forge-dev</a></span><br></div></blockquote></div><br>_______________________________________________<br>


forge-dev mailing list<br>
<a href="mailto:forge-dev@lists.jboss.org" target="_blank">forge-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/forge-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/forge-dev</a><br>
<br></blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</div></blockquote><blockquote type="cite"><div><span>_______________________________________________</span><br><span>forge-dev mailing list</span><br><span><a href="mailto:forge-dev@lists.jboss.org">forge-dev@lists.jboss.org</a></span><br><span><a href="https://lists.jboss.org/mailman/listinfo/forge-dev">https://lists.jboss.org/mailman/listinfo/forge-dev</a></span><br></div></blockquote></body></html>