Hey Fiorenzo!<br><br>I've FINALLY had a chance to take a look at this. It looks great! One comment about your tests though :)<br><br>You do a lot of this:<br>`<span class="n">assertTrue</span><span class="o">(</span><span class="n">content</span><span class="o">.</span><span class="na">contains</span><span class="o">(</span><span class="s">"javax.ejb.TransactionAttributeType"</span><span class="o">));`</span><br>
<div class="gmail_quote"><br>Instead, however, you should probably call:<br><br>`javaSource.hasImport("<span class="s">javax.ejb.TransactionAttributeType"</span>)`<br><br>and <br><br>javaSource.hasAnnotation("javax.ejb.TransactionAttribute");<br>
<br>instead of doing string comparisons.<br><br>Otherwise, though, this looks awesome! Does your plugin help with configuring @MessageDriven beans to actually connect to a JMS queue? Just a thought maybe for the next version :)<br>
<br>~Lincoln<br><br><br>On Wed, Sep 12, 2012 at 7:25 PM, JFlower <span dir="ltr"><<a href="mailto:fiorenzino@gmail.com" target="_blank">fiorenzino@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi Lincoln,<div><br></div><div>my ejb plugin is ready to meet your eyes:</div><div><a href="https://github.com/fiorenzino/core/tree/FORGE-610/javaee-impl/src/main/java/org/jboss/forge/spec/javaee/ejb" target="_blank">https://github.com/fiorenzino/core/tree/FORGE-610/javaee-impl/src/main/java/org/jboss/forge/spec/javaee/ejb</a></div>
<div><br></div><div>initial test:</div><div><a href="https://github.com/fiorenzino/core/blob/FORGE-610/javaee-impl/src/test/java/org/jboss/forge/spec/ejb/EJBPluginTest.java" target="_blank">https://github.com/fiorenzino/core/blob/FORGE-610/javaee-impl/src/test/java/org/jboss/forge/spec/ejb/EJBPluginTest.java</a></div>
<div><br></div><div>i need to do some works before close:</div><div>- add more tests (for all functionality)</div><div>- add more parameters on mdb configuration</div><div>- add clusterable annotation</div><div>- add transaction on methods</div>
<div>- permit undo/change (revert/change configuration)</div><div><br></div><div><b><span style="line-height:18px;color:rgb(51,51,51);font-size:13px;font-family:arial,sans-serif">I'm waiting for your comments on my slow work (..u</span><span style="line-height:18px;color:rgb(51,51,51);font-size:13px;font-family:arial,sans-serif">nfortunately my free time is limited...)</span></b></div>
<div><b><span style="line-height:18px;color:rgb(51,51,51);font-size:13px;font-family:arial,sans-serif"><br></span></b></div><div>bye</div><div><br></div><div>fiorenzo</div><div><br></div>
<div><br></div><div>PS: the fucked Mdb annotation at end was:</div><div><br></div><div><div>javaClass.addImport(ActivationConfigProperty.class);</div><div>javaClass.addImport(MessageDriven.class);</div><div>javaClass.addImport(Message.class);</div>
<div>javaClass.addInterface(MessageListener.class);</div><div>javaClass.addMethod("public void onMessage(Message message) {}");</div><div>javaClass.addAnnotation(javaClassType.MESSAGEDRIVEN.getAnnotation())</div>
<div><span style="white-space:pre-wrap"> </span>.setLiteralValue("name", "\"" + name + "\"")</div><div><span style="white-space:pre-wrap"> </span>.setLiteralValue("activationConfig",</div>
<div><span style="white-space:pre-wrap"> </span>"{@ActivationConfigProperty(propertyName = \"destinationType\", propertyValue = \""+ destinationType+ "\"), " + </div>
<div><span style="white-space:pre-wrap"> </span>"@ActivationConfigProperty(propertyName = \"destination\", propertyValue = \""+ destinationName + "\")" + "}");</div>
</div><div><div class="gmail_quote"><br></div></div>
<br>_______________________________________________<br>
forge-dev mailing list<br>
<a href="mailto:forge-dev@lists.jboss.org">forge-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/forge-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/forge-dev</a><br>
<br></blockquote></div><br><br clear="all"><br>-- <br>Lincoln Baxter, III<br><a href="http://ocpsoft.org" target="_blank">http://ocpsoft.org</a><br>"Simpler is better."<br>