<p dir="ltr">Thoughts?</p>
<p dir="ltr">---<br>
Lincoln Baxter's Droid<br>
<a href="http://ocpsoft.org">http://ocpsoft.org</a><br>
"Keep it Simple"</p>
<div class="gmail_quote">---------- Forwarded message ----------<br>From: "Lincoln Baxter, III" <<a href="mailto:lincolnbaxter@gmail.com">lincolnbaxter@gmail.com</a>><br>Date: Apr 30, 2013 8:31 AM<br>Subject: Re: [core] FORGE-874: Proxy settings not used for maven web project (#314)<br>
To: "forge/core" <<a href="mailto:reply%2Bi-13796837-9f0837d6c9164cfde977b60d4c0f19df2d4d9f6b-362329@reply.github.com">reply+i-13796837-9f0837d6c9164cfde977b60d4c0f19df2d4d9f6b-362329@reply.github.com</a>><br>
Cc: "forge/core" <<a href="mailto:core@noreply.github.com">core@noreply.github.com</a>><br><br type="attribution"><p dir="ltr">Now that I see what you did to fix this, I think this makes sense to do earlier in the forge life cycle. I don't see why it should be tied either to projects or to plugins, do you?</p>
<p dir="ltr">This should probably go into an @Observes PostStartup event method. Somewhere in the core.</p>
<p dir="ltr">Wdyt?</p>
<p dir="ltr">---<br>
Lincoln Baxter's Droid<br>
<a href="http://ocpsoft.org" target="_blank">http://ocpsoft.org</a><br>
"Keep it Simple"</p>
<div class="gmail_quote">On Apr 30, 2013 4:33 AM, "Yann Albou" <<a href="mailto:notifications@github.com" target="_blank">notifications@github.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<hr>
<h4>You can merge this Pull Request by running</h4>
<pre> git pull <a href="https://github.com/myannou/forge-core" target="_blank">https://github.com/myannou/forge-core</a> FORGE-874</pre>
<p>Or view, comment on, or merge it at:</p>
<p> <a href="https://github.com/forge/core/pull/314" target="_blank">https://github.com/forge/core/pull/314</a></p>
<h4>Commit Summary</h4>
<ul>
<li>FORGE-874: Proxy settings not used for maven web project</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/forge/core/pull/314/files#diff-0" target="_blank">shell/src/main/java/org/jboss/forge/shell/plugins/builtin/ForgePlugin.java</a>
(21)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/forge/core/pull/314/files#diff-1" target="_blank">shell/src/main/java/org/jboss/forge/shell/project/ProjectInitializer.java</a>
(26)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href="https://github.com/forge/core/pull/314.patch" target="_blank">https://github.com/forge/core/pull/314.patch</a></li>
<li><a href="https://github.com/forge/core/pull/314.diff" target="_blank">https://github.com/forge/core/pull/314.diff</a></li>
</ul>
</blockquote></div>
</div>