<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div>Sounds great! Go for it!</div><div><br>Em 24/07/2013, às 16:05, Lennart Jörelid <<a href="mailto:lennart.jorelid@gmail.com">lennart.jorelid@gmail.com</a>> escreveu:<br><br></div><blockquote type="cite"><div><div dir="ltr">Hello George (and all),<div><br></div><div>I understand. As a suggestion, could I make a case (implying a JIRA issue and following patch, I presume :) ) for placing the codestyle configuration for IDEs and Maven plugins within a "Codestyle" maven project, placed within the root of the the Forge Core repository? (Or somewhere else, if you deem there is a better location).</div>
<div><br></div><div>The approach has been used smoothly within several large-scale projects, so I feel decently confident that it works well. </div><div>Moreover, I have an somewhat documented example of this approach if you feel like taking a look:</div>
<div><br></div><div><div><ol><li>Maven site documentation and partial explanation found at <font color="#0b5394"><a href="https://bytebucket.org/lennartj/nazgul_tools/wiki/mavenSite/2.0.8/codestyle/index.html">https://bytebucket.org/lennartj/nazgul_tools/wiki/mavenSite/2.0.8/codestyle/index.html</a></font></li>
<li>Repository available for cloning at <font color="#0b5394">hg clone <a href="https://bitbucket.org/lennartj/nazgul_tools">https://bitbucket.org/lennartj/nazgul_tools</a></font></li></ol></div></div><div><br></div><div>
Let me know if you feel this is not worth investigating. Otherwise, I will place a JIRA, create a patch, introduce some code quality plugins in Maven and provide a Intellij IDEA integration, hopefully with the exact same codestyle as the current Eclipse one.</div>
<div>Fair?</div><div><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">2013/7/24 <span dir="ltr"><<a href="mailto:ggastald@redhat.com" target="_blank">ggastald@redhat.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
Hello Lennart, <br>
<br>
Welcome to the forge-dev list! My name is George and I am one of the
core developers of JBoss Forge. Please find your answers below:<br>
<br>
1) The only code formatter we use in Forge core is the
<a href="https://github.com/forge/core/blob/master/eclipse-code-formatter-profile.xml" target="_blank">https://github.com/forge/core/blob/master/eclipse-code-formatter-profile.xml</a>
<br>
2) Absolutely, code quality plugins are very important and we would
appreciate using them as part of the build. <br>
<br>
As always, pull-requests with an associated JIRA (
<a href="http://issues.jboss.org/browse/FORGE" target="_blank">http://issues.jboss.org/browse/FORGE</a>)
are more than welcome! :)<br>
<br>
Best Regards and Keep Forgin' ! <br>
<br>
George Gastaldi<div><div class="h5"><br>
<br>
<br>
<div>On 07/24/2013 02:15 PM, Lennart Jörelid
wrote:<br>
</div>
</div></div><blockquote type="cite"><div><div class="h5">
<div dir="ltr">Hello all,
<div><br>
</div>
<div>Hope you are enjoying some high-quality vacation time this
time of the year.</div>
<div><br>
</div>
<div>Two Forge-Dev newbie questions here:</div>
<div><br>
</div>
<div>
<div>
<ol>
<li>
I am in the process of creating a few patches or
suggestions for Forge, and wonder if we have a codestyle
XML or JAR for IntelliJ IDEA which matches the codestyle
used in Forge. I have snooped around a tad on the site
and in the repo, but so far could not find any. </li>
<li>While it is nice to use any IDE to define codestyle,
it is even better if some code quality plugins run
within Maven can validate/enforce the code quality
within our development. I can find some (rather
nonintrusive) plugin version definitions within the
jboss-parent-10.pom, but not any actual codestyle
enforcements (at least not within the Forge project).
Have I missed them, or have the dev community agreed
that we do not need code quality plugins run?</li>
</ol>
<div>Thanks in advance.</div>
</div>
</div>
<div><br>
</div>
<div>:)</div>
<div><span style="font-family:monospace;font-size:medium">
<pre>--
+==============================+
| Bästa hälsningar,
| [sw. "Best regards"]
|
| Lennart Jörelid
| EAI Architect & Integrator
|
| jGuru Europe AB
| Mölnlycke - Kista
|
| Email: <a href="mailto:lj@jguru.se" target="_blank">lj@jguru.se</a>
| URL: <a href="http://www.jguru.se" target="_blank">www.jguru.se</a>
| Phone
| (skype): jgurueurope
| (intl): <a href="tel:%2B46%20708%20507%20603" value="+46708507603" target="_blank">+46 708 507 603</a>
| (domestic): 0708 - 507 603
+==============================+</pre>
</span>
</div>
</div>
<br>
<fieldset></fieldset>
<br>
</div></div><pre>_______________________________________________
forge-dev mailing list
<a href="mailto:forge-dev@lists.jboss.org" target="_blank">forge-dev@lists.jboss.org</a>
<a href="https://lists.jboss.org/mailman/listinfo/forge-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/forge-dev</a></pre><span class="HOEnZb"><font color="#888888">
</font></span></blockquote><span class="HOEnZb"><font color="#888888">
<br>
<div>-- <br>
<b>George Gastaldi</b> | <i>Senior Software Engineer</i> <br>
JBoss Forge Team<br>
Red Hat<br>
</div>
</font></span></div>
<br>_______________________________________________<br>
forge-dev mailing list<br>
<a href="mailto:forge-dev@lists.jboss.org">forge-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/forge-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/forge-dev</a><br></blockquote></div><br><br clear="all"><div><br></div>-- <br><span style="font-family:monospace;font-size:medium"><pre>--
+==============================+
| Bästa hälsningar,
| [sw. "Best regards"]
|
| Lennart Jörelid
| EAI Architect & Integrator
|
| jGuru Europe AB
| Mölnlycke - Kista
|
| Email: <a href="mailto:lj@jguru.se" target="_blank">lj@jguru.se</a>
| URL: <a href="http://www.jguru.se" target="_blank">www.jguru.se</a>
| Phone
| (skype): jgurueurope
| (intl): +46 708 507 603
| (domestic): 0708 - 507 603
+==============================+</pre></span>
</div>
</div></blockquote><blockquote type="cite"><div><span>_______________________________________________</span><br><span>forge-dev mailing list</span><br><span><a href="mailto:forge-dev@lists.jboss.org">forge-dev@lists.jboss.org</a></span><br><span><a href="https://lists.jboss.org/mailman/listinfo/forge-dev">https://lists.jboss.org/mailman/listinfo/forge-dev</a></span></div></blockquote></body></html>